From: Jiri Olsa <olsajiri@gmail.com>
To: Tao Chen <chen.dylane@linux.dev>
Cc: song@kernel.org, kpsingh@kernel.org, mattbobrowski@google.com,
ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
martin.lau@linux.dev, eddyz87@gmail.com, yonghong.song@linux.dev,
john.fastabend@gmail.com, sdf@fomichev.me, haoluo@google.com,
rostedt@goodmis.org, mhiramat@kernel.org,
mathieu.desnoyers@efficios.com, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH bpf-next v2 2/2] bpf: Add show_fdinfo for kprobe_multi
Date: Mon, 16 Jun 2025 09:40:24 +0200 [thread overview]
Message-ID: <aE_KaH3DAo4-Yq7m@krava> (raw)
In-Reply-To: <20250615150514.418581-2-chen.dylane@linux.dev>
On Sun, Jun 15, 2025 at 11:05:14PM +0800, Tao Chen wrote:
> Show kprobe_multi link info with fdinfo, the info as follows:
>
> link_type: kprobe_multi
> link_id: 3
> prog_tag: e8225cbcc9cdffef
> prog_id: 29
> type: kprobe_multi
> kprobe_cnt: 8
> missed: 0
> func: bpf_fentry_test1+0x0/0x20
> cookie: 1
> func: bpf_fentry_test2+0x0/0x20
> cookie: 7
> func: bpf_fentry_test3+0x0/0x20
> cookie: 2
> func: bpf_fentry_test4+0x0/0x20
> cookie: 3
> func: bpf_fentry_test5+0x0/0x20
> cookie: 4
> func: bpf_fentry_test6+0x0/0x20
> cookie: 5
> func: bpf_fentry_test7+0x0/0x20
> cookie: 6
> func: bpf_fentry_test8+0x0/0x10
> cookie: 8
>
> Signed-off-by: Tao Chen <chen.dylane@linux.dev>
> ---
> kernel/trace/bpf_trace.c | 33 +++++++++++++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
>
> diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c
> index 9a8ca8a8e2b..d060c61e4e4 100644
> --- a/kernel/trace/bpf_trace.c
> +++ b/kernel/trace/bpf_trace.c
> @@ -2623,10 +2623,43 @@ static int bpf_kprobe_multi_link_fill_link_info(const struct bpf_link *link,
> return err;
> }
>
> +#ifdef CONFIG_PROC_FS
> +static void bpf_kprobe_multi_show_fdinfo(const struct bpf_link *link,
> + struct seq_file *seq)
> +{
> + struct bpf_kprobe_multi_link *kmulti_link;
> + char sym[KSYM_NAME_LEN];
> +
> + kmulti_link = container_of(link, struct bpf_kprobe_multi_link, link);
> +
> + seq_printf(seq,
> + "type:\t%s\n"
> + "kprobe_cnt:\t%u\n"
> + "missed:\t%lu\n",
> + kmulti_link->flags == BPF_F_KPROBE_MULTI_RETURN ? "kretprobe_multi" :
> + "kprobe_multi",
> + kmulti_link->cnt,
> + kmulti_link->fp.nmissed);
> +
> + for (int i = 0; i < kmulti_link->cnt; i++) {
> + sprint_symbol(sym, kmulti_link->addrs[i]);
I think you could use specifier to do the translation for you,
check Documentation/core-api/printk-formats.rst:
%pS versatile_init+0x0/0x110 [module_name]
> + seq_printf(seq,
> + "func:\t%s\n"
> + "cookie:\t%llu\n",
> + sym,
> + kmulti_link->cookies[i]
> + );
bracket should be on the previous line
jirka
> + }
> +}
> +#endif
> +
> static const struct bpf_link_ops bpf_kprobe_multi_link_lops = {
> .release = bpf_kprobe_multi_link_release,
> .dealloc_deferred = bpf_kprobe_multi_link_dealloc,
> .fill_link_info = bpf_kprobe_multi_link_fill_link_info,
> +#ifdef CONFIG_PROC_FS
> + .show_fdinfo = bpf_kprobe_multi_show_fdinfo,
> +#endif
> };
>
> static void bpf_kprobe_multi_cookie_swap(void *a, void *b, int size, const void *priv)
> --
> 2.48.1
>
next prev parent reply other threads:[~2025-06-16 7:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-15 15:05 [PATCH bpf-next v2 1/2] bpf: Add show_fdinfo for uprobe_multi Tao Chen
2025-06-15 15:05 ` [PATCH bpf-next v2 2/2] bpf: Add show_fdinfo for kprobe_multi Tao Chen
2025-06-16 7:40 ` Jiri Olsa [this message]
2025-06-16 8:34 ` Tao Chen
2025-06-16 7:40 ` [PATCH bpf-next v2 1/2] bpf: Add show_fdinfo for uprobe_multi Jiri Olsa
2025-06-16 8:39 ` Tao Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aE_KaH3DAo4-Yq7m@krava \
--to=olsajiri@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=chen.dylane@linux.dev \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mathieu.desnoyers@efficios.com \
--cc=mattbobrowski@google.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).