From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B1EE286411 for ; Fri, 17 Oct 2025 08:36:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760690195; cv=none; b=P/8ig0osFVNrurK3kLvrX+Jm5q48KnVjfulyokMhG/e4TEwqU77Fk5SSooIw2Y1Kqddkb57Atjct4uw/WmywGOYIBOlK8yutznbzbvPPm5zfLxdGvt0hHDsiA1zYRxJMYAuezrMjPzptvBe/P7kn1ZVc7P+23X1EmaKq4+CxXcA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760690195; c=relaxed/simple; bh=H7neXrmmaHliUo9sEr0qz6ILP0qyJTC4U2kyqhJouQY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mTi5vSMpfTOOesk3p1AI6n38cxB2ILfr8cuFduCsYd7bDkFp7hhYzPO7W8inm2DbNxl9cm8gYjgWOX2GFz9Zo24lKUtF3j/HNxnWK7ma/K8LhwqYCbyWn08pb4rPbXwr0DKxwcxqKYvwoDub+3zpfaZxBmmjfpzfawKNxKENL9U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=usPIGogo; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="usPIGogo" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-3ee15b5435bso1103204f8f.0 for ; Fri, 17 Oct 2025 01:36:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1760690192; x=1761294992; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8PbyCiuHUJUF033svwvjOYrdhpWf8nguQ+4KJNq1qik=; b=usPIGogoFwjEjHBIFMjnIsMGXDsrnUoXcytgkYC170NVjL95Grr8hDuWwBUg+Q/xmi KC1OPSwUjdBRmU1GskAucMtXlyrl9ZEZE8dniCY7l5XElqc/MaQzmjlQq2endchTFAyp d88y8D+eQlUuzqZBNCiWMdVZn+MH7iwbZLI8t7N3wBn6E3Mua0AlSLMaAPWexGxKxq2m XPepDMMxTueYEHsP7miVF6IewJGit8VvMBP61ukMevQMQYTUcjr9fYPcxRoePdKCo1jt 1zgl/e+lAbx3+AlPcrId1EthadeDpeeuQqtELIwTLwwKWdIMNazzDFhwQyGzo6zi8mbj 0+/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760690192; x=1761294992; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8PbyCiuHUJUF033svwvjOYrdhpWf8nguQ+4KJNq1qik=; b=D5Sdl2p1xBbU0ANO9ItYaJGFlda07Py8P9Az17nwD6vclgLdf0O88thEiHyKY5LSVN DWBn/76tCbJ6TkgZr5ffLi8snpeBzYUO20OTZttqB2CGvaTfISlI9BDOLgux+j+Ev7S0 2dJcpoCuftbOzBuDEJP2UIIuErJ6nPiZf/mxZ8jZsImInvVUE1Ki0exj1HWKezyf/fYW bL2K8fMdBczpXfvGBQ9aWLofYV3Ym4lciTlApTI47PMIzbD48H3qfBaDswhCPXo/ujfS AtIHX8QlrXOULjDsdmENv7lI1rDg+MJmGXRodwwlHfmskjgOCFaobv80zgz/w733AT/T +4Hw== X-Forwarded-Encrypted: i=1; AJvYcCU39nLTsdSxlDvHH4LLi4tIDJZw2C/4okQSYSYFK750HeFYN/tumBskic29lmPhlep1sC7jXoN1nA10pIgDlibvwTU=@vger.kernel.org X-Gm-Message-State: AOJu0YyyhJ3xZrvBMMe681V0xfr7LN3mqP7SQLsbm9NcpCLqLdN+vEuH ggpZYLqtzMVruXt9dpyZj+ddYU4wkdec9JdQtSwlXSoOkrOAs4N2xgGfLXGg9p0DIA== X-Gm-Gg: ASbGncv3EVelYtGZUP4G1O539veOK3sxpUpS4lF4st+83QwIoIRO8xwKLSPyfhWN24U /FMOFS/Axnd5uxFMIg+ZcJGsGSShl+QZxC9uyB6At9ax4oPDaBT+piikF1utgxuUutWS8CfTAiP xRgCI1fAeWJq+s77NctbpA7XC9DZAtyrsKibBmuXO79QJM2kK8BSiS018kxx9ECvGk59PAod/1U n17+lX5y0n/vKEUc4L/BqwXTfngqNHvMiUAkmqdCDeDWpFleS7TD52oo0vR+f7C3D3axiI25Kdi p08oGGzwipN66LDDHgU12zA+Oj5fiMJEOzoIwfGPcc8ArBDgzVlMyakPlIVwpCtLCGI5uujcT7z wWso15Dw7KgQNyMbhtWTiqXQbX3FIsNRsTAdSZi+JLSNSMAdHbdG7/BtvDpTKG11HvB6xQfbynX ptZ4wCBWHScHgCM2Q2fkiUblnxE/yLiZtnB433v/obIA0uu4WWxMHiNE6yvR5Kcg== X-Google-Smtp-Source: AGHT+IH72Zzon///3YHUGrfdJjvES6bGUL67+sdtzqRk2m12B632kNe5kfL2AL8JY16sBojJ3cT0Wg== X-Received: by 2002:a05:6000:1867:b0:427:6a4:93da with SMTP id ffacd0b85a97d-42706a496dcmr779835f8f.49.1760690190913; Fri, 17 Oct 2025 01:36:30 -0700 (PDT) Received: from google.com (218.131.22.34.bc.googleusercontent.com. [34.22.131.218]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42707b482b3sm2142688f8f.50.2025.10.17.01.36.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Oct 2025 01:36:30 -0700 (PDT) Date: Fri, 17 Oct 2025 09:36:27 +0100 From: Vincent Donnefort To: Steven Rostedt Cc: mhiramat@kernel.org, mathieu.desnoyers@efficios.com, linux-trace-kernel@vger.kernel.org, maz@kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, jstultz@google.com, qperret@google.com, will@kernel.org, aneesh.kumar@kernel.org, kernel-team@android.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 14/28] tracing: Add a trace remote module for testing Message-ID: References: <20251003133825.2068970-1-vdonnefort@google.com> <20251003133825.2068970-15-vdonnefort@google.com> <20251016170645.15416c8a@gandalf.local.home> <20251016171155.0d871fc3@gandalf.local.home> Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251016171155.0d871fc3@gandalf.local.home> On Thu, Oct 16, 2025 at 05:11:55PM -0400, Steven Rostedt wrote: > On Thu, 16 Oct 2025 17:06:45 -0400 > Steven Rostedt wrote: > > > On Fri, 3 Oct 2025 14:38:11 +0100 > > Vincent Donnefort wrote: > > > > > diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig > > > index 918afcc1fcaf..52131d89993c 100644 > > > --- a/kernel/trace/Kconfig > > > +++ b/kernel/trace/Kconfig > > > @@ -1244,4 +1244,12 @@ config TRACE_REMOTE > > > config SIMPLE_RING_BUFFER > > > bool > > > > > > +config TRACE_REMOTE_TEST > > > + tristate "Test module for remote tracing" > > > + select TRACE_REMOTE > > > + select SIMPLE_RING_BUFFER > > > + help > > > + This trace remote includes a ring-buffer writer implementation using > > > + "simple_ring_buffer". This is solely intending for testing. > > > + > > > > Nit, this should go up a few places so that it's with the other "test module" selections. > > And when I tried to build it, I hit this: > > GEN .vmlinux.objs > MODPOST Module.symvers > ERROR: modpost: "simple_ring_buffer_reserve" [kernel/trace/remote_test.ko] undefined! > ERROR: modpost: "simple_ring_buffer_commit" [kernel/trace/remote_test.ko] undefined! > ERROR: modpost: "simple_ring_buffer_unload" [kernel/trace/remote_test.ko] undefined! > ERROR: modpost: "trace_remote_free_buffer" [kernel/trace/remote_test.ko] undefined! > ERROR: modpost: "trace_remote_alloc_buffer" [kernel/trace/remote_test.ko] undefined! > ERROR: modpost: "simple_ring_buffer_init" [kernel/trace/remote_test.ko] undefined! > ERROR: modpost: "trace_remote_register" [kernel/trace/remote_test.ko] undefined! > ERROR: modpost: "simple_ring_buffer_reset" [kernel/trace/remote_test.ko] undefined! > ERROR: modpost: "simple_ring_buffer_swap_reader_page" [kernel/trace/remote_test.ko] undefined! > ERROR: modpost: "simple_ring_buffer_enable_tracing" [kernel/trace/remote_test.ko] undefined! > WARNING: modpost: suppressed 1 unresolved symbol warnings because there were too many) > make[3]: *** [/work/git/linux-trace.git/scripts/Makefile.modpost:147: Module.symvers] Error 1 > make[2]: *** [/work/git/linux-trace.git/Makefile:1960: modpost] Error 2 > make[1]: *** [/work/git/linux-trace.git/Makefile:248: __sub-make] Error 2 > make[1]: Leaving directory '/work/build/nobackup/debiantesting-x86-64' > make: *** [Makefile:248: __sub-make] Error 2 And of course, I forgot to check CONFIG_REMOTE_TEST=M ... The following snippet should do. Do you want a v8 now (and with your previous comment) or shall I wait a bit more? -- diff --git a/fs/tracefs/inode.c b/fs/tracefs/inode.c index 0c023941a316..aa305be834f9 100644 --- a/fs/tracefs/inode.c +++ b/fs/tracefs/inode.c @@ -665,6 +665,7 @@ struct dentry *tracefs_create_file(const char *name, umode_t mode, fsnotify_create(d_inode(dentry->d_parent), dentry); return tracefs_end_creating(dentry); } +EXPORT_SYMBOL_GPL(tracefs_create_file); static struct dentry *__create_dir(const char *name, struct dentry *parent, const struct inode_operations *ops) diff --git a/kernel/trace/simple_ring_buffer.c b/kernel/trace/simple_ring_buffer.c index c2ec6017c37c..02303161aab7 100644 --- a/kernel/trace/simple_ring_buffer.c +++ b/kernel/trace/simple_ring_buffer.c @@ -162,6 +162,7 @@ int simple_ring_buffer_swap_reader_page(struct simple_rb_per_cpu *cpu_buffer) return 0; } +EXPORT_SYMBOL_GPL(simple_ring_buffer_swap_reader_page); static struct simple_buffer_page *simple_rb_move_tail(struct simple_rb_per_cpu *cpu_buffer) { @@ -267,6 +268,7 @@ void *simple_ring_buffer_reserve(struct simple_rb_per_cpu *cpu_buffer, unsigned return &rb_event->array[1]; } +EXPORT_SYMBOL_GPL(simple_ring_buffer_reserve); void simple_ring_buffer_commit(struct simple_rb_per_cpu *cpu_buffer) { @@ -280,6 +282,7 @@ void simple_ring_buffer_commit(struct simple_rb_per_cpu *cpu_buffer) */ smp_store_release(&cpu_buffer->status, SIMPLE_RB_READY); } +EXPORT_SYMBOL_GPL(simple_ring_buffer_commit); static u32 simple_rb_enable_tracing(struct simple_rb_per_cpu *cpu_buffer, bool enable) { @@ -337,6 +340,7 @@ int simple_ring_buffer_reset(struct simple_rb_per_cpu *cpu_buffer) return 0; } +EXPORT_SYMBOL_GPL(simple_ring_buffer_reset); int __simple_ring_buffer_init(struct simple_rb_per_cpu *cpu_buffer, struct simple_buffer_page *bpages, @@ -427,6 +431,7 @@ int simple_ring_buffer_init(struct simple_rb_per_cpu *cpu_buffer, struct simple_ { return __simple_ring_buffer_init(cpu_buffer, bpages, desc, __load_page, __unload_page); } +EXPORT_SYMBOL_GPL(simple_ring_buffer_init); void __simple_ring_buffer_unload(struct simple_rb_per_cpu *cpu_buffer, void (*unload_page)(void *)) @@ -449,6 +454,7 @@ void simple_ring_buffer_unload(struct simple_rb_per_cpu *cpu_buffer) { return __simple_ring_buffer_unload(cpu_buffer, __unload_page); } +EXPORT_SYMBOL_GPL(simple_ring_buffer_unload); int simple_ring_buffer_enable_tracing(struct simple_rb_per_cpu *cpu_buffer, bool enable) { @@ -459,3 +465,4 @@ int simple_ring_buffer_enable_tracing(struct simple_rb_per_cpu *cpu_buffer, bool return 0; } +EXPORT_SYMBOL_GPL(simple_ring_buffer_enable_tracing); diff --git a/kernel/trace/trace_remote.c b/kernel/trace/trace_remote.c index dc6bc387ebca..e54cc3e75dc5 100644 --- a/kernel/trace/trace_remote.c +++ b/kernel/trace/trace_remote.c @@ -895,6 +895,7 @@ int trace_remote_register(const char *name, struct trace_remote_callbacks *cbs, return ret; } +EXPORT_SYMBOL_GPL(trace_remote_register); void trace_remote_free_buffer(struct trace_buffer_desc *desc) { @@ -910,6 +911,7 @@ void trace_remote_free_buffer(struct trace_buffer_desc *desc) free_page(rb_desc->page_va[id]); } } +EXPORT_SYMBOL_GPL(trace_remote_free_buffer); int trace_remote_alloc_buffer(struct trace_buffer_desc *desc, size_t desc_size, size_t buffer_size, const struct cpumask *cpumask) @@ -960,6 +962,7 @@ int trace_remote_alloc_buffer(struct trace_buffer_desc *desc, size_t desc_size, trace_remote_free_buffer(desc); return ret; } +EXPORT_SYMBOL_GPL(trace_remote_alloc_buffer); static int trace_remote_enable_event(struct trace_remote *remote, struct remote_event *evt, bool enable)