From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E0542EA726 for ; Mon, 20 Oct 2025 08:19:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760948394; cv=none; b=rKMMCYbI7gT8py2ZrjY5yLPYX4ruYHLdfbH5Mx1w+Ji5YhEvKa2v3BwNdsO9Eg6/Xyw4n3RoOEFU2UU9iIkvPeI6RKO7tNCEqh0MW8ODLhtBjDmTPwhiYYxCH49tA7a1pLWroNTwvGMq5xuNY3XzhFAP7HaDbrG+iunSmI95AEU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760948394; c=relaxed/simple; bh=S9UDMbWilPhdpfJwIjrQRamIzFyU9QD+ikxKlb0Oz8k=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UiKhBRoYgOXeRVigkzfDvq9lG1e81lP0o2UyPcqZf2aHSGSFfKKkbNPIGv0bAVOaipU2qwtTyqaCVPdzUuoDpFOHzIdmesw0rryHHXjAdrElwGIZe2l7D85c1qTsMLANfXrMgsae9ruiG1kS17sogKdPu1sN49k0vlehyvE4D+s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bVZ9iUnl; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bVZ9iUnl" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-46b303f7469so31129325e9.1 for ; Mon, 20 Oct 2025 01:19:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760948390; x=1761553190; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=oVCb1IezkGjRWpLaVOS0OWSE2fmBa+Fn1PR1cAjcc/Q=; b=bVZ9iUnldHZyholn32ZBdwQ5q63nZfV4CZBTcmun6SnylwJAoVevsOPEbON3m8A9ZN 4NK4QDvWabkDtnIHXZpg6XPSMW2HHq3+7BJ8T8JzCLawP1VEYT6F8vFIS35r5cI+7yp1 cM1u/ZbP8KjIDW2c8ciNMy3ZBpqGfnYYVhvsGO7nDvEeXPO3orPKZDBCocgXU+yGuwRf 2h+X2m8aTnZofw+Zww5k3azv5NCd/kEsvZMATVMg0TNRGHhBLrFBWbcMEcGuTHLUkhT4 BSK28K5VKPhov24DP4boUdw4HgMLj6SFEv5LokavJbbdHQAPwAaXwXFuGDGtZwgRSqX5 6f/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760948390; x=1761553190; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oVCb1IezkGjRWpLaVOS0OWSE2fmBa+Fn1PR1cAjcc/Q=; b=vQlcsO+epsKq9ExjeC25e484IOUPVIqRlTGS0YX1HDI7zogn2wDCZ2rP2uVEeVp1bN hBEZEJ8N6pX0jfYDaLOTw1qr2DD+f5/OOZ+0oDlAR8eErWe2vaJvw1JYCqZaQzzaO+Mi Yc2An2xRbzyxnCJ0UpERnL9iDUmTxvqItH5uA2R2XQ836bRAS2TlO5e8kdaLpDESmeZ9 ckqzqVeiWXuRzW6NN+EKcyDyQVkUWcxZ8ZuQffrJ0BJxdTEFwA34s0tCYt4K3Y7VZLRq frQ18lc36+ndfigzqsbxVtdQnSyrQpSeyi9a24tGYxHeiSVYUnY8O/2jNhSF3w06Ynw5 jO+w== X-Forwarded-Encrypted: i=1; AJvYcCWbUWJ+4jP1xI6Sx3fS3alvTvjyZNw3KTs2rr/05gSBNrUcQgFdhxS1ktxrODfhQe4lBGjfUpBakOszOKlV+QdNPTY=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5ywmV+rCIj2sRMEPgwsdt9DOsCI8Fd5Q6/23yk1c2S2ZXgsdf bmX4IvoYDbuDE1VDqxFl9o0U1s6MqEhXl1yvhzNfxdlry7oGgA36RRzn X-Gm-Gg: ASbGnctlH+oFisQedFRbOJNKgmHk9hqRGIHGuCg3d6JwV+yZXnit8v3W3TzTUqJf8RE HmT1a/pwByE3OEG0jLrTZ5HUJLKZfurTi5fW4QR1oThHSQ1Td+Fsj5dTGolL5+8Ur2HFenQaCVV u/r/boxTaiQWwprpR4+40BLSqtSL2udwVDXrAwsMzqFToMWEozl/1Is9j4eJRmy2PkGFZ7yxwnI OeL1/cxs8zVTztSQdc1M+iioG9jNVOWw4+ODOxE60deHaZDqmIYh/nhGWYOyTVuZDRIxvoTYJTC yX6MjUs1KD7ibkBg/LBs9xJTm6XDGKnOz5BHOVA6lnkfF7vGNwEDJLkt9Wf7it+So0Kah3N0P7f ytI6YV+m77kWFa7FMDyTWR+DOJWaYQpxxE61p1xrD18+ITb27NOMZQgukhFvl X-Google-Smtp-Source: AGHT+IEXZFrAVjWLOtNUPtFNYd/eiqI5y9E0oS07a02DP0cVokTgitLvFo7ntPqbG7MXVqYU7Eyhaw== X-Received: by 2002:a05:600c:870b:b0:471:9da:5252 with SMTP id 5b1f17b1804b1-47117919c1cmr93063265e9.29.1760948389780; Mon, 20 Oct 2025 01:19:49 -0700 (PDT) Received: from krava ([2a02:8308:a00c:e200::31e0]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-471144b5c91sm216979455e9.11.2025.10.20.01.19.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Oct 2025 01:19:49 -0700 (PDT) From: Jiri Olsa X-Google-Original-From: Jiri Olsa Date: Mon, 20 Oct 2025 10:19:47 +0200 To: Menglong Dong Cc: ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com, andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, mattbobrowski@google.com, rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, leon.hwang@linux.dev, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH RFC bpf-next 5/5] selftests/bpf: add testcases for tracing session Message-ID: References: <20251018142124.783206-1-dongml2@chinatelecom.cn> <20251018142124.783206-6-dongml2@chinatelecom.cn> Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251018142124.783206-6-dongml2@chinatelecom.cn> On Sat, Oct 18, 2025 at 10:21:24PM +0800, Menglong Dong wrote: SNIP > +static void test_fsession_reattach(void) > +{ > + struct fsession_test *skel = NULL; > + int err, prog_fd; > + LIBBPF_OPTS(bpf_test_run_opts, topts); > + > + skel = fsession_test__open_and_load(); > + if (!ASSERT_OK_PTR(skel, "fsession_test__open_and_load")) > + goto cleanup; > + > + /* First attach */ > + err = fsession_test__attach(skel); > + if (!ASSERT_OK(err, "fsession_first_attach")) > + goto cleanup; > + > + /* Trigger test function calls */ > + prog_fd = bpf_program__fd(skel->progs.test1); > + err = bpf_prog_test_run_opts(prog_fd, &topts); > + if (!ASSERT_OK(err, "test_run_opts err")) > + return; goto cleanup > + if (!ASSERT_OK(topts.retval, "test_run_opts retval")) > + return; goto cleanup > + > + /* Verify first call */ > + ASSERT_EQ(skel->bss->test1_entry_called, 1, "test1_entry_first"); > + ASSERT_EQ(skel->bss->test1_exit_called, 1, "test1_exit_first"); > + > + /* Detach */ > + fsession_test__detach(skel); > + > + /* Reset counters */ > + memset(skel->bss, 0, sizeof(*skel->bss)); > + > + /* Second attach */ > + err = fsession_test__attach(skel); > + if (!ASSERT_OK(err, "fsession_second_attach")) > + goto cleanup; > + > + err = bpf_prog_test_run_opts(prog_fd, &topts); > + if (!ASSERT_OK(err, "test_run_opts err")) > + return; goto cleanup > + if (!ASSERT_OK(topts.retval, "test_run_opts retval")) > + return; goto cleanup > + > + /* Verify second call */ > + ASSERT_EQ(skel->bss->test1_entry_called, 1, "test1_entry_second"); > + ASSERT_EQ(skel->bss->test1_exit_called, 1, "test1_exit_second"); > + > +cleanup: > + fsession_test__destroy(skel); > +} > + > +void test_fsession_test(void) > +{ > +#if !defined(__x86_64__) > + test__skip(); > + return; > +#endif > + if (test__start_subtest("fsession_basic")) > + test_fsession_basic(); > + if (test__start_subtest("fsession_reattach")) > + test_fsession_reattach(); > +} > diff --git a/tools/testing/selftests/bpf/progs/fsession_test.c b/tools/testing/selftests/bpf/progs/fsession_test.c > new file mode 100644 > index 000000000000..cce2b32f7c2c > --- /dev/null > +++ b/tools/testing/selftests/bpf/progs/fsession_test.c > @@ -0,0 +1,178 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* Copyright (c) 2025 ChinaTelecom */ > +#include > +#include > +#include > + > +char _license[] SEC("license") = "GPL"; > + > +__u64 test1_entry_result = 0; > +__u64 test1_exit_result = 0; > +__u64 test1_entry_called = 0; > +__u64 test1_exit_called = 0; > + > +SEC("fsession/bpf_fentry_test1") > +int BPF_PROG(test1, int a) > +{ I guess we can access return argument directly but it makes sense only for exit session program, or we could use bpf_get_func_ret jirka > + bool is_exit = bpf_tracing_is_exit(ctx); > + > + if (!is_exit) { > + /* This is entry */ > + test1_entry_called = 1; > + test1_entry_result = a == 1; > + return 0; /* Return 0 to allow exit to be called */ > + } > + > + /* This is exit */ > + test1_exit_called = 1; > + test1_exit_result = a == 1; > + return 0; > +} > + > +__u64 test2_entry_result = 0; > +__u64 test2_exit_result = 0; > +__u64 test2_entry_called = 0; > +__u64 test2_exit_called = 0; > + SNIP