From: Dan Carpenter <dan.carpenter@linaro.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-trace-kernel@vger.kernel.org
Subject: [bug report] tracing: Have persistent ring buffer print syscalls normally
Date: Fri, 31 Oct 2025 08:37:09 +0300 [thread overview]
Message-ID: <aQRLBV_KzDHaaYiG@stanley.mountain> (raw)
Hello Steven Rostedt,
Commit 25bd47a59275 ("tracing: Have persistent ring buffer print
syscalls normally") from Oct 28, 2025 (linux-next), leads to the
following Smatch static checker warning:
kernel/trace/trace.c:4273 print_trace_fmt()
warn: if statement not indented
kernel/trace/trace.c
4260 if (trace_seq_has_overflowed(s))
4261 return TRACE_TYPE_PARTIAL_LINE;
4262
4263 if (event) {
4264 if (tr->trace_flags & TRACE_ITER_FIELDS)
4265 return print_event_fields(iter, event);
4266 /*
4267 * For TRACE_EVENT() events, the print_fmt is not
4268 * safe to use if the array has delta offsets
4269 * Force printing via the fields.
4270 */
4271 if ((tr->text_delta)) {
4272 /* ftrace and system call events are still OK */
--> 4273 if ((event->type > __TRACE_LAST_TYPE) &&
4274 !is_syscall_event(event))
I feel like there was a line of code here that was accidentally left out
of the commit.
4275 return print_event_fields(iter, event);
Or we could add another tab here, but my guess is there is a missing
statement.
4276 }
4277 return event->funcs->trace(iter, sym_flags, event);
4278 }
4279
4280 trace_seq_printf(s, "Unknown type %d\n", entry->type);
4281
4282 return trace_handle_return(s);
4283 }
regards,
dan carpenter
next reply other threads:[~2025-10-31 5:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-31 5:37 Dan Carpenter [this message]
2025-10-31 12:35 ` [bug report] tracing: Have persistent ring buffer print syscalls normally Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQRLBV_KzDHaaYiG@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox