From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f54.google.com (mail-yx1-f54.google.com [74.125.224.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1AFE23D7EE for ; Sat, 27 Dec 2025 19:35:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766864157; cv=none; b=O+NiPfmxdKalepnJ+/BG7IzP76IruY7C6mxwccejvnniCi2ZgRTWZnuU1KwIGFpmNUjZlQwJX9E2TqEMCbE3yauPIqvZRWff0XzC0/UeFfZg04DKERy0APvp6eJM2kIPQRUcXeS9zt9jDCXOoJtwWUmUrgP+pfCMvydbzbAcgt4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766864157; c=relaxed/simple; bh=Ays4sQx/Nq4nCe0PJ0q8Ts2Inf96vnJULh6aklwYDa8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YJKD4yqpiDDsQMi1oCOiWFnX2DERprscbeLUqnYSo2P1PLQrXV7OQ7qAWB27kI8zqTrvRqHe8TRUUSwzCwUSDInlfjvd8/A2TxeekJRFL177wBJS9MrDRaK/eeavJnpFS6G3Scrlfh3IrocppICqK0c8eB4et1xOjrcdIHjmYsw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=epiTrlKr; arc=none smtp.client-ip=74.125.224.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="epiTrlKr" Received: by mail-yx1-f54.google.com with SMTP id 956f58d0204a3-6446c1a7a1cso6666469d50.3 for ; Sat, 27 Dec 2025 11:35:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766864155; x=1767468955; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ZscOEY94JtpqTuF2Rte0ITMRfXFqnWcGnNUyPWqzXog=; b=epiTrlKrRr+3319mz8eBhkiRN2E1uvlHs0N9/cvoE8bCoHocXByn51TtrCX8qdGIeM kYkdIBK7msTBOMwURrZgfwdAJ1X0AkCM5wGt2Nru6873cVUx1Y8Ew9zQn1XKJcOcgQYz 4BF7NMnmFdmmthz6iZNe84T/iRGZrkNG/AhususXADiMkWX54HaWsF4YTdntA9sNd20K Jly+OiV60w3h8+Z0TFq1bG3kq1x8kMKTzwrY3Fwn+U/yewR6KpfvUSUd2N8X9btqhIs4 s+QKnfivX3+TRb/w97Jzbs6/HNOeyo9KtK43S90ipA72l+hm0ay1OF/IaRXaEtvLtTP9 eggw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766864155; x=1767468955; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZscOEY94JtpqTuF2Rte0ITMRfXFqnWcGnNUyPWqzXog=; b=I6+CNL/8FnCAOwHkq2SxjjE7A/jqjpRGjeaV6tWA8RKEkQHNRbcYmYNxLhlXxEWgYL zJi1BkwuhGHR73gtgAKiweLsCOzc3beAVyYbEdCZgGJHoZt5Xj5VeOVtCq6AWW47dAfW 8FQuS9AgvEMU6TUWgv4dJRLnomtSwojTwijHL3sGJwcFSeFJAfzkPU0Vvrgh2YRzdWZp 3DeHz2iMGxblCJuGKoqRancFdNrryX44j95nUHghZ9DrAcRFpYzuBLFMljYDdk8JoTJu NDZyfzc06Tar5eZ2BYrifSzgnoNWqVQGVra91KTyI2nvmkDvTOwSOdi6JwINzK5Fj4Mu S+Uw== X-Forwarded-Encrypted: i=1; AJvYcCVMQtCba3gumlYpqPliciyqqRA0kR0iMHjpZAl0Of69/UJJ/52u2KbJ/KTS+70oExYttl6eJeM9ot2MZCO3dUSAK3s=@vger.kernel.org X-Gm-Message-State: AOJu0YySblkP0uyIgiG2xVKOT2aYhd56O01DMXNf1wsLQLmXyVq1MFkE SCdZwc8lN6LoEKIuHowLv15x/8xa72b5WnOeSv6hkfXQ8Bqcs3SFUpxz X-Gm-Gg: AY/fxX6gFKff7g2H7blMZU9ImWCZovhoDpFkyAgvV1TRk4eXONKQ2NgnHsOkKL9rxJq gIj5RVeMTlghrf0D+fbe/DVC5s66Rnupyg9NL3azoS9rc/xQ7efRdNx/AMrQPOy++2GbVW/PljJ fMPPtDL/zZB0H6+yNmxuUuUcDD0zj6mQqrXZe1HQVwa6eFOV88miMQM0ShbtPnimEVom/hl2c30 VKxXIDMKQukD8yR6xDngtAdh/nZUvQjPyHaiRuMOXc/kafBoL/0+aEqHongg2snjf4iDgR8Mele bh13SagI2TZ61c+Fqvd9Rm6FhLeFQPXKxq7i83CWNcE0vDHIeGhcOVGeH3ixyLa882NorHaKZW1 v3upfKz6MLQfqpAg347HU1xNpUKGkKsXEzuSntOmUTFw9pX9TML7R5JV8qUO71ucKJe2BW1s/wN p3Wrz2jPA= X-Google-Smtp-Source: AGHT+IFTyqtO8AIMR6I5RrW0NJVOngvdnp5kCSpfYPRgSEcWGvPmUWwG/Vuj1vc27aG6932toBOBHQ== X-Received: by 2002:a05:690e:4106:b0:644:60d9:865e with SMTP id 956f58d0204a3-6466a8ede93mr19913042d50.97.1766864154604; Sat, 27 Dec 2025 11:35:54 -0800 (PST) Received: from localhost ([2601:346:0:79bd:f47d:8af8:869d:704b]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6466a8bd4c3sm12689811d50.8.2025.12.27.11.35.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Dec 2025 11:35:53 -0800 (PST) Date: Sat, 27 Dec 2025 14:35:52 -0500 From: Yury Norov To: Steven Rostedt Cc: Andy Shevchenko , Andrew Morton , Masami Hiramatsu , Mathieu Desnoyers , Christophe Leroy , Randy Dunlap , Ingo Molnar , Jani Nikula , Joonas Lahtinen , David Laight , Petr Pavlu , Andi Shyti , Rodrigo Vivi , Tvrtko Ursulin , Daniel Gomez , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-modules@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH v4 7/7] kernel.h: drop trace_printk.h Message-ID: References: <20251225170930.1151781-1-yury.norov@gmail.com> <20251225170930.1151781-8-yury.norov@gmail.com> <20251226115848.298465d4@gandalf.local.home> <20251227105701.5cbeb47e@robin> Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251227105701.5cbeb47e@robin> On Sat, Dec 27, 2025 at 10:57:01AM -0500, Steven Rostedt wrote: > On Sat, 27 Dec 2025 16:45:47 +0200 > Andy Shevchenko wrote: > > > > I'm fine for trying other ways to speed up the compilation, but removing > > > full access to trace_printk() isn't one of them. OK, then let's keep trace_printk() available for kernel.h users. Andrew, can you take the first 6 patches of the series, if no other objections? > > I interpreted this as if the header inclusion should be moved from kernel.h > > to printk.h as a compromise that satisfies all (?) stakeholders. Is it possible > > approach? > > I'm fine with putting the include of trace_printk.h into printk.h. If > you remove printk.h from kernel.h I would expect a lot more people to > complain about it. Including Linus himself. The difference is that printk() is not a debugging tool. It is used widely to report errors and info messages. Normally, I want to cleanup all debugging code from my module after finishing development. If trace_printk.h will be a part of printk.h, there's always a chance to miss trace_printk() somewhere. I'd prefer to keep them separate. Thanks, Yury