Linux Trace Kernel
 help / color / mirror / Atom feed
From: Naveen N Rao <naveen@kernel.org>
To: Hari Bathini <hbathini@linux.ibm.com>
Cc: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	 Madhavan Srinivasan <maddy@linux.ibm.com>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	 Michael Ellerman <mpe@ellerman.id.au>,
	linux-trace-kernel@vger.kernel.org,
	 Mark Rutland <mark.rutland@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	 Masami Hiramatsu <mhiramat@kernel.org>,
	llvm@lists.linux.dev, Maryam Moghadas <maryammo@ca.ibm.com>
Subject: Re: [PATCH 1/3] powerpc64: make clang cross-build friendly
Date: Fri, 9 Jan 2026 19:20:55 +0530	[thread overview]
Message-ID: <aWEHPEJFYccmCVQK@blrnaveerao1> (raw)
In-Reply-To: <8141c6eb-f2b7-4a19-b637-af699bb8d5c4@linux.ibm.com>

On Mon, Dec 08, 2025 at 09:32:06PM +0530, Hari Bathini wrote:
> Thanks for the review, Naveen.
> 
> On 24/11/25 11:19 am, Naveen N Rao wrote:
> > On Sun, Nov 09, 2025 at 02:34:03AM +0530, Hari Bathini wrote:
> > > ARCH_USING_PATCHABLE_FUNCTION_ENTRY depends on toolchain support for
> > > -fpatchable-function-entry option. The current script that checks
> > > for this support only handles GCC. Rename the script and extend it
> > > to detect support for -fpatchable-function-entry with Clang as well,
> > > allowing clean cross-compilation with Clang toolchains.
> > > 
> > > Signed-off-by: Hari Bathini <hbathini@linux.ibm.com>
> > > ---
> > >   arch/powerpc/Kconfig                                         | 5 +++--
> > >   ...-function-entry.sh => check-fpatchable-function-entry.sh} | 0
> > >   2 files changed, 3 insertions(+), 2 deletions(-)
> > >   rename arch/powerpc/tools/{gcc-check-fpatchable-function-entry.sh => check-fpatchable-function-entry.sh} (100%)
> > > 
> > > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> > > index 325c1171894d..dfb62e211c92 100644
> > > --- a/arch/powerpc/Kconfig
> > > +++ b/arch/powerpc/Kconfig
> > > @@ -568,8 +568,9 @@ config ARCH_USING_PATCHABLE_FUNCTION_ENTRY
> > >   	depends on FUNCTION_TRACER && (PPC32 || PPC64_ELF_ABI_V2)
> > >   	depends on $(cc-option,-fpatchable-function-entry=2)
> > >   	def_bool y if PPC32
> > > -	def_bool $(success,$(srctree)/arch/powerpc/tools/gcc-check-fpatchable-function-entry.sh $(CC) -mlittle-endian) if PPC64 && CPU_LITTLE_ENDIAN
> > > -	def_bool $(success,$(srctree)/arch/powerpc/tools/gcc-check-fpatchable-function-entry.sh $(CC) -mbig-endian) if PPC64 && CPU_BIG_ENDIAN
> > > +	def_bool $(success,$(srctree)/arch/powerpc/tools/check-fpatchable-function-entry.sh $(CC) -mlittle-endian) if PPC64 && CPU_LITTLE_ENDIAN && CC_IS_GCC
> > > +	def_bool $(success,$(srctree)/arch/powerpc/tools/check-fpatchable-function-entry.sh $(CC) -target ppc64le -mlittle-endian) if PPC64 && CPU_LITTLE_ENDIAN && CC_IS_CLANG
> > 
> > Can you instead pass $(CLANG_FLAGS) to retain the same command across
> > gcc/clang?
> 
> Should work, I guess.
> But do I need to test for any additional clang flags that
> may interfere with what we are trying to check here?

From what I can tell, $(CLANG_FLAGS) includes a fairly static set of 
flags which will be included alongside other $CFLAGS. So, I don't think 
anything special should be needed there.

- Naveen


  reply	other threads:[~2026-01-09 13:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-08 21:04 [PATCH 0/3] powerpc64/ftrace: fixes clang build issues Hari Bathini
2025-11-08 21:04 ` [PATCH 1/3] powerpc64: make clang cross-build friendly Hari Bathini
2025-11-24  5:49   ` Naveen N Rao
2025-12-08 16:02     ` Hari Bathini
2026-01-09 13:50       ` Naveen N Rao [this message]
2025-11-08 21:04 ` [PATCH 2/3] powerpc64/ftrace: fix OOL stub count with clang Hari Bathini
2025-11-08 21:04 ` [PATCH 3/3] powerpc64/ftrace: workaround clang recording GEP in __patchable_function_entries Hari Bathini
2025-11-24  5:55   ` Naveen N Rao
2025-12-08 16:08     ` Hari Bathini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aWEHPEJFYccmCVQK@blrnaveerao1 \
    --to=naveen@kernel.org \
    --cc=christophe.leroy@csgroup.eu \
    --cc=hbathini@linux.ibm.com \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=llvm@lists.linux.dev \
    --cc=maddy@linux.ibm.com \
    --cc=mark.rutland@arm.com \
    --cc=maryammo@ca.ibm.com \
    --cc=mhiramat@kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox