From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 489C233A03F for ; Fri, 16 Jan 2026 16:26:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768580817; cv=none; b=EY9j8VD21P9LAhe6WwN2IvfNM/edNctDayPTWXcj8QkUUyf2txEeuGpTifDwioY0Ls2YYqq+xqxLcXzSqTuvsg5Rf6BGGDSDkAeQ4iKfsjwqmMnWZ1VEhpMFRN4n7FmtCIQ+QB9JmHGexFveFUakCTqUvW4jf4ODdOAFeiSBZKU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768580817; c=relaxed/simple; bh=8AHs53fSvU5bHukwFUEWbX+8QI5Zs/IgwW6Go1qm7u0=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qPCbE52GfWLUYmYGFOwbJvfiXuPTLR1LRp0VnHMNp+6X+lUtygxSIxxVrMNJcC3ybdT3hYA7gHE3dH7GczWTo41a2zcceElXRqFt5uDOXpdBxt9xMk287a9zYGos6TcsUylsHaYtpJcMpKB82YXB4qsLr3wj0k0oSlLq6jE9WwY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jI2nmMNg; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jI2nmMNg" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-42fb4eeb482so1277092f8f.0 for ; Fri, 16 Jan 2026 08:26:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768580815; x=1769185615; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from:from:to :cc:subject:date:message-id:reply-to; bh=LpEcqtGHA2DG3RqR34GHiAvSZA6xSMmh8o8+NjypMPE=; b=jI2nmMNgKMgi+E7qsC39d4L4g2pQPQnUJhS8+fT0by3BZItCSJYx6rwNIuvsY5jjPQ D4skJvdk6oyhj87V8vXUz495z1Qc2B3quLCsbDqMIa8EsUPGLnTv+vImB6fD5Iq8CnDf SYs36KxLWRVU1RH5AJ/g5d0cQXNd1IhH4POmPYMcoeP9oyHTjyCUDbqwF4OtwZ+pObta TbM4DsCGi7LoccPSloIcxM8QbIk16Od/BSF0Pcgu+gSHRYtuwZw22xik0CFW5ghCnGFj eehv36qJ3Nm4c2XfFewJBLtBk+/oB/QZCMsZYN3gQi+AjG7NV8sb1vIZwTet9vOHTiyr B04Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768580815; x=1769185615; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LpEcqtGHA2DG3RqR34GHiAvSZA6xSMmh8o8+NjypMPE=; b=BDdYhhjIJUmEPG5UeFcJKDuEK/HSd46uKfE/TsvxDwpOchmb3gWcD3feakra4wh67J 3Yncf8tWZ81g/AuwV/yaGsgjLQT8JP/mA7syXdMRRT1hvm3JUb9/qdU1wbImkTjRa3zb w3KCT6tw0mwNqfCXuVygivGxIyrSItKSCjccYjpm4UszTf9niWKyfPMdAfLYX+ANr6U2 W7XbuAVT6Bp3LAG+++Oo2lUCmj3XNDYsLLOo3kxgIYnDBEPDKmz35FqwPZ4cPuMv4lTh qWt9+NCnz+NdZnNNUYiZPqG5oyina6U4lFnm8TvS8mgOj+qyDDdDBbCNREKxBrppBsRF VX5Q== X-Forwarded-Encrypted: i=1; AJvYcCXsgmhQkqBK21/dTncIdFp0weSJTkFzJdqijN1VnAaw5rO0+qdjFQ+5ZJhdT8NXgVPHKQyHNcqBAlKbZod8MDWgetE=@vger.kernel.org X-Gm-Message-State: AOJu0YyXfzs72sZxVtro++UoYt4nOsQn2TqnPipbyWoJBxHfAFv5et0W hem33j1ria44pb5ZVXWPqdCBWocjKX9DkLxKqOhm5Eb6iKruqTiPJ7nd X-Gm-Gg: AY/fxX5565u8thjeTf0WUasVnK9Ibe4zopyJ7V/5mqno3mzg79neYS9E/M7XJhjqO1f j/9WTkt/2WHy3LT9jfYcCIHAz9hkpwCp0IZe99giZuGa99iCzdJaVA4y8lfxz4wVdO+oPjvrE3s +UePID0jNn3p6Hx2GDysiYtI+iLA8UytEBDc+eMOTs/QZar/h0r2JzjRqe93tgtim2pE/y+SXdI WoCzj/mKy/QOV1bOQgnFgtP5rsao86FnxsAg8WKGZlsWdVnOEJm6yPhWCHzZgBg1R5+MPX82+6K 5SArCTSAaFMJAi47T7s95l3lWK58dUti3gjQvqd7iOV+3NWSI5lRruIzkzLPsdMscD3olsDOMmb WD6GZL+vmvbuVPEXp7dzzKw8p9M1boNAmRCU7foDnFNl2b0nOOUPIETcbTPjJAWMrPZ+YL3kpFr r4W4E= X-Received: by 2002:a05:600c:37cc:b0:480:1b65:b741 with SMTP id 5b1f17b1804b1-4801eac97b9mr38192555e9.15.1768580814334; Fri, 16 Jan 2026 08:26:54 -0800 (PST) Received: from krava ([2a00:102a:400f:3ccc:ffd6:980:bac0:cb06]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4801fe67780sm18796955e9.16.2026.01.16.08.26.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jan 2026 08:26:54 -0800 (PST) From: Jiri Olsa X-Google-Original-From: Jiri Olsa Date: Fri, 16 Jan 2026 17:26:50 +0100 To: Andrii Nakryiko Cc: Masami Hiramatsu , Steven Rostedt , Josh Poimboeuf , Peter Zijlstra , bpf@vger.kernel.org, linux-trace-kernel@vger.kernel.org, x86@kernel.org, Yonghong Song , Song Liu , Andrii Nakryiko , Mahe Tardy Subject: Re: [PATCH bpf-next 4/4] selftests/bpf: Allow to benchmark trigger with stacktrace Message-ID: References: <20260112214940.1222115-1-jolsa@kernel.org> <20260112214940.1222115-5-jolsa@kernel.org> Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Jan 15, 2026 at 10:48:29AM -0800, Andrii Nakryiko wrote: > On Mon, Jan 12, 2026 at 1:50 PM Jiri Olsa wrote: > > > > Adding support to call bpf_get_stackid helper from trigger programs, > > so far added for kprobe multi. > > > > Adding the --stacktrace/-g option to enable it. > > > > Signed-off-by: Jiri Olsa > > --- > > tools/testing/selftests/bpf/bench.c | 4 ++++ > > tools/testing/selftests/bpf/bench.h | 1 + > > .../selftests/bpf/benchs/bench_trigger.c | 1 + > > .../selftests/bpf/progs/trigger_bench.c | 18 ++++++++++++++++++ > > 4 files changed, 24 insertions(+) > > > > This now actually becomes a stack trace benchmark :) But I don't mind, > I think it would be good to be able to benchmark this. But I think we > should then implement it for all different tracing programs (tp, > raw_tp, fentry/fexit/fmod_ret) for consistency and so we can compare > and contrast?... yep, agreed > > > diff --git a/tools/testing/selftests/bpf/bench.c b/tools/testing/selftests/bpf/bench.c > > index bd29bb2e6cb5..8dadd9c928ec 100644 > > --- a/tools/testing/selftests/bpf/bench.c > > +++ b/tools/testing/selftests/bpf/bench.c > > @@ -265,6 +265,7 @@ static const struct argp_option opts[] = { > > { "verbose", 'v', NULL, 0, "Verbose debug output"}, > > { "affinity", 'a', NULL, 0, "Set consumer/producer thread affinity"}, > > { "quiet", 'q', NULL, 0, "Be more quiet"}, > > + { "stacktrace", 'g', NULL, 0, "Get stack trace"}, > > bikeshedding time: why "g"? why not -S or something like that? perf tool strikes back ;-) -S is better thanks, jirka