From: Crystal Wood <crwood@redhat.com>
To: Tomas Glozar <tglozar@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>,
John Kacur <jkacur@redhat.com>,
Luis Goncalves <lgoncalv@redhat.com>,
Costa Shulyupin <costa.shul@redhat.com>,
Wander Lairson Costa <wander@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>
Subject: Re: [PATCH 3/4] rtla/timerlat: Add example for BPF action program
Date: Tue, 21 Oct 2025 10:58:06 -0500 [thread overview]
Message-ID: <aa0bbfeec78bc90966e660af91eb39acccb77d73.camel@redhat.com> (raw)
In-Reply-To: <CAP4=nvT8VGpYrqQDztmB1WJPEb6JXvUuL201ksWq6eSV7kn-oA@mail.gmail.com>
On Tue, 2025-10-21 at 16:54 +0200, Tomas Glozar wrote:
> po 20. 10. 2025 v 19:53 odesílatel Crystal Wood <crwood@redhat.com> napsal:
> >
> > We should have the makefile build this, and add a test that uses it.
> >
>
> I agree. I tried to use the example, but it would be also good to
> check if the BPF program was actually executed.
>
> That is hard to do reliably for the current example, as it writes into
> the global tracefs instance, which might conflict with another user of
> the same instance. I will write another BPF program that will create a
> map instead, and a script that will check the map value via
> --on-threshold in the test.
Huh, so I guess BPF is an exception to the "no generic printk to the
global trace instance except for debugging that generates a big boot
splat" rule?
Speaking of which, why doesn't trace_osnoise.c call
trace_array_init_printk() given that it uses trace_array_printk_buf()?
-Crystal
next prev parent reply other threads:[~2025-10-21 15:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 14:46 [PATCH 0/4] rtla/timerlat: Add --bpf-action option Tomas Glozar
2025-10-17 14:46 ` [PATCH 1/4] rtla/timerlat: Support tail call from BPF program Tomas Glozar
2025-10-17 14:46 ` [PATCH 2/4] rtla/timerlat: Add --bpf-action option Tomas Glozar
2025-10-20 14:04 ` Wander Lairson Costa
2025-10-20 17:51 ` Crystal Wood
2025-10-17 14:46 ` [PATCH 3/4] rtla/timerlat: Add example for BPF action program Tomas Glozar
2025-10-20 17:53 ` Crystal Wood
2025-10-21 14:54 ` Tomas Glozar
2025-10-21 15:58 ` Crystal Wood [this message]
2025-10-21 17:02 ` Steven Rostedt
2025-10-21 17:32 ` Crystal Wood
2025-10-23 7:27 ` Tomas Glozar
2025-10-24 1:49 ` Crystal Wood
2025-10-27 10:34 ` Tomas Glozar
2025-10-27 12:30 ` Crystal Wood
2025-10-17 14:46 ` [PATCH 4/4] Documentation/rtla: Document --bpf-action option Tomas Glozar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa0bbfeec78bc90966e660af91eb39acccb77d73.camel@redhat.com \
--to=crwood@redhat.com \
--cc=acme@kernel.org \
--cc=costa.shul@redhat.com \
--cc=jkacur@redhat.com \
--cc=lgoncalv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglozar@redhat.com \
--cc=wander@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).