From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D1B432779E for ; Fri, 12 Sep 2025 14:28:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757687297; cv=none; b=llrAdve5fTXdSAXhHCAfSKg+hG/rDk2oDvOCdBOkMUyRKqooxe/BM8FSUXyq6ydhyvhlO6frg+dpKYU2PvZZMp7LhP/RwxsBVpqvnbof1JUS8AkeJ81lUGx9RmmZP7fDPqKU2m75WDv24shz5QP2ZdiG1NbL5FDjT9Kk8Ku/ntk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757687297; c=relaxed/simple; bh=FFF6t8Oxqef6MY0gV6yo/cf0Rgi3UB0q/cioF5yztmY=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=Kk4FyL20M9+jYYA4ufohV62CUxwwRWZb4zwGibiNF/tA2mxC4TSgNfuXJ4tNUNhLQL5ZRm54R7TRAdhrEBwCP/BqStbs4vRS/SV6IPcrdggczHgTZFpa3aIeLY0G7h3KV65AI6GWslF8tralX8XWkSwGMIFtNjMIuwoE7fRnxVw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Q+6mGi8j; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Q+6mGi8j" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757687295; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=6/INHoqs21znnh/5mPIsed1nkXIhXp3uhrFdBDsES6g=; b=Q+6mGi8jD4XAjcgQOAS4uudcZ7vg6DdGxHeuZHTcZAq96jfpJU/YA2uln0DGf0W3OtyzQP M9TcY5H5duokd97CXWHMlTsMYRwbnw/Gnp7z/iLBvhCnV/M9uObEnsTuwQx6t6IytDxbXq 9fB250yhgk9Dr6jmZqyIyLoXtXySg8k= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-550-MH-rne25MIuUoDY2XkC1IQ-1; Fri, 12 Sep 2025 10:28:14 -0400 X-MC-Unique: MH-rne25MIuUoDY2XkC1IQ-1 X-Mimecast-MFC-AGG-ID: MH-rne25MIuUoDY2XkC1IQ_1757687293 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-45cb4f23156so12363405e9.2 for ; Fri, 12 Sep 2025 07:28:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757687293; x=1758292093; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6/INHoqs21znnh/5mPIsed1nkXIhXp3uhrFdBDsES6g=; b=o8cKyLnpjQVRrmUYb/r+zD1hnqbNWANpO2fHZIkwnCdCIGSPnqThnfea1nDFlYEFpt 3z14qis8Lv9OIwn56hAT2taXibOK/tNFg/y83/KilnZP43ayjtKqXrzEg9RdE0WiGSNg gQPUc0/+rCSgG0nG7HaxEJ802tDeasZ6BJBF8arIXCQSE+8salCihX37lYp0a7IEGz9i +EfMcJ0Q4q9gOBIrDdPbsEnghktvJcoFUQX1vJpKP4v7YbH5gnfvnfNk00dv3WN9N62z QIptYnTj4SB24SqolTThbHFSvlb9hisXcjn4jMRyg5jsutE2Of6wPmTVBvO7KrYcXUDD mCag== X-Forwarded-Encrypted: i=1; AJvYcCXOclMJhFdOotKxgJwQXQBEzJ6JyCl+j7LSQvqn+OuxNLrb6fklwFsMnkji6KZtnWYkX+7TFKgPbB3VO6BRllsu910=@vger.kernel.org X-Gm-Message-State: AOJu0Yxh2QFvgjTb1qFV682Uy0k5O0pgYKg71qlViaLF/HsQfmcVG0lb +P//+Ny7I4VuK860T+wPtKt6YWvoCbY8Hif0DaMbG0vIU/so/W8fUTVVpCKApltV4IOUaU0cNZe 9KFuieXxeoRTQBYiGLxcpG+WORXGGbytj5+vg6ujc5UJfD3sLXchgWDq7anB8YnJBzgcWxELwFw == X-Gm-Gg: ASbGncsGneV/zaot4y2ATwnL3ocol953ZJqMYfI/bzZYRsXf4gKHFyZjqO9TEbaJEPB xy+btcVTxzC6Ec/ADFWSUTDKLcxhTEck41Jv6qx8CDSxDV6fqCgRyuGdQj/VlCU2PFSEXtrfWzR y7fxGJZ7JM/unCVOXxijFFUGymTCfKUctdffUa95lmYPVtnj9wF7yhQ+J04KSiGpUX04VHZu2py ZSprXPEUTBR4MibTCjtUcafjv0gqGeS8PA4BHH4sKDQ3PbF3ekMLtX5FYJrXcbdlzQ+9SCgqoDV VFMoqHQL0cehuTJojd8lEb0jjjq1+KwmIr2os4D/smBeYFy26sTvyDRcE+sSVHZDmD7PS8m86Xi 9Ytf49/QBu7Ap4KQ5OympLOw1EIja25zbzderrTD6TvkQ4iH+LTf0kXXYe+KF241Yo3w= X-Received: by 2002:a05:600c:a4b:b0:45c:b5eb:b0c6 with SMTP id 5b1f17b1804b1-45f211c856dmr37602795e9.5.1757687292756; Fri, 12 Sep 2025 07:28:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEbTRs/e3GPfZE3JTs6Oz0TWAjSTYauqRQbeN4IfxOKEi5vi5uxWU1if31ZxU9WsAv1EZxTuw== X-Received: by 2002:a05:600c:a4b:b0:45c:b5eb:b0c6 with SMTP id 5b1f17b1804b1-45f211c856dmr37602185e9.5.1757687292159; Fri, 12 Sep 2025 07:28:12 -0700 (PDT) Received: from ?IPV6:2003:d8:2f20:da00:b70a:d502:3b51:1f2d? (p200300d82f20da00b70ad5023b511f2d.dip0.t-ipconnect.de. [2003:d8:2f20:da00:b70a:d502:3b51:1f2d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45e015775f1sm68129895e9.8.2025.09.12.07.28.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Sep 2025 07:28:11 -0700 (PDT) Message-ID: Date: Fri, 12 Sep 2025 16:28:09 +0200 Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v11 00/15] khugepaged: mTHP support From: David Hildenbrand To: Kiryl Shutsemau , Nico Pache Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, ryan.roberts@arm.com, dev.jain@arm.com, corbet@lwn.net, rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, akpm@linux-foundation.org, baohua@kernel.org, willy@infradead.org, peterx@redhat.com, wangkefeng.wang@huawei.com, usamaarif642@gmail.com, sunnanyong@huawei.com, vishal.moola@gmail.com, thomas.hellstrom@linux.intel.com, yang@os.amperecomputing.com, aarcange@redhat.com, raquini@redhat.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, tiwai@suse.de, will@kernel.org, dave.hansen@linux.intel.com, jack@suse.cz, cl@gentwo.org, jglisse@google.com, surenb@google.com, zokeefe@google.com, hannes@cmpxchg.org, rientjes@google.com, mhocko@suse.com, rdunlap@infradead.org, hughd@google.com, richard.weiyang@gmail.com, lance.yang@linux.dev, vbabka@suse.cz, rppt@kernel.org, jannh@google.com, pfalcato@suse.de References: <20250912032810.197475-1-npache@redhat.com> <43f42d9d-f814-4b54-91a6-3073f7c7cedf@redhat.com> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <43f42d9d-f814-4b54-91a6-3073f7c7cedf@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: EkErJmod_6MiWwaafH0JieVGG6m5D9hFue7mLMEESKk_1757687293 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12.09.25 15:47, David Hildenbrand wrote: > On 12.09.25 14:19, Kiryl Shutsemau wrote: >> On Thu, Sep 11, 2025 at 09:27:55PM -0600, Nico Pache wrote: >>> The following series provides khugepaged with the capability to collapse >>> anonymous memory regions to mTHPs. >>> >>> To achieve this we generalize the khugepaged functions to no longer depend >>> on PMD_ORDER. Then during the PMD scan, we use a bitmap to track individual >>> pages that are occupied (!none/zero). After the PMD scan is done, we do >>> binary recursion on the bitmap to find the optimal mTHP sizes for the PMD >>> range. The restriction on max_ptes_none is removed during the scan, to make >>> sure we account for the whole PMD range. When no mTHP size is enabled, the >>> legacy behavior of khugepaged is maintained. max_ptes_none will be scaled >>> by the attempted collapse order to determine how full a mTHP must be to be >>> eligible for the collapse to occur. If a mTHP collapse is attempted, but >>> contains swapped out, or shared pages, we don't perform the collapse. It is >>> now also possible to collapse to mTHPs without requiring the PMD THP size >>> to be enabled. >>> >>> When enabling (m)THP sizes, if max_ptes_none >= HPAGE_PMD_NR/2 (255 on >>> 4K page size), it will be automatically capped to HPAGE_PMD_NR/2 - 1 for >>> mTHP collapses to prevent collapse "creep" behavior. This prevents >>> constantly promoting mTHPs to the next available size, which would occur >>> because a collapse introduces more non-zero pages that would satisfy the >>> promotion condition on subsequent scans. >> >> Hm. Maybe instead of capping at HPAGE_PMD_NR/2 - 1 we can count >> all-zeros 4k as none_or_zero? It mirrors the logic of shrinker. > > BTW, I thought further about this and I agree: if we count zero-filled > pages towards none_or_zero one we can avoid the "creep" problem. > > The scanning-for-zero part is rather nasty, though. Aaand, thinking again from the other direction, this would mean that just because pages became zero after some time that we would no longer collapse because none_or_zero would then be higher. Hm .... How I hate all of this so very very much :) -- Cheers David / dhildenb