From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f46.google.com (mail-dl1-f46.google.com [74.125.82.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 786C831F9A8 for ; Wed, 11 Mar 2026 05:11:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773205892; cv=none; b=ZXgvzO4NyOS0tfUPrDpMfqQuATn1w5gsN6XuURd4tynRWWzydZ9jnfGrbGBI4VW3xPzlZCa1rLMnv7ZToO3EMohvmJ3iyJfH5jL361iApTuvaGk54trJmaUEcW3Q7v0UPIDgAZ7N31+RFIZ4GiRWJyTPqCbHHxlt8KJkC8lvjxM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773205892; c=relaxed/simple; bh=SKQebgFHBXfmM2lGdrhEr42Q1f+W474nmfBE0BMUDwU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oNNMOllOyaXnqwj54vlBAKhwu0ldYmq/1ge6VKPOfX696BEIMG8EAjEpmuoCAOtfSpAJk5Ifgn5JTObUqWAoFMFtAfsNHcoYs4OoEmDcVJkhqfFazK9USVkWfRIgaSCAwCPHyg+1OOc9QKytdVniBLtVD7Q9gveASzq7fF2ND4g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=X6ymUCMH; arc=none smtp.client-ip=74.125.82.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X6ymUCMH" Received: by mail-dl1-f46.google.com with SMTP id a92af1059eb24-128b9b7e3edso574014c88.0 for ; Tue, 10 Mar 2026 22:11:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773205890; x=1773810690; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8PBbyOmDB5lQs1yLkLN/9EtPkXrISR2EjJXxH+dMHsM=; b=X6ymUCMHD47YPpSQVZeiyGQ4VRiONZq2Gfd2O0oWBh3unN6dyfVvFF/6nJ9aXSwpoG Kmke7o9CSbsRL1WhWj5BsOyqhI0/ns8C83AXZy2D60OsQAcQe1h7hWA/qIsra//aQu2Y QHg9gsxGxYm100jbBpqRBR+mgBHl0JWjnsHz43qnkEnYnCoQSa/5rkaMiJioIA2DiwKS drvFJWQhVhUeaxtaZcdA9zR9ME2Qeg1A3Ujy+ZNGjOx7U5uahsUd2uoMbBWK/AwEVh4f 3r0rKVBuWX0vgGAfkgQL6479UAt6bkLR+2UPkHBFCCQOLjdW1kpSkkeE+IuZPRgPyHE0 VxHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773205890; x=1773810690; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8PBbyOmDB5lQs1yLkLN/9EtPkXrISR2EjJXxH+dMHsM=; b=CirFPL7pI6FBoNdUbwSLZSfaeIWcKfvbDsXzzhg5hLTDU03nFnXCV3gkA6V2EDZq52 sSrI0Vg/bA7rkH1QXhSgzwE7pcoklTX53cnROC0jx5r+gBhyVP5PwLKWkF9k4y2h9Mgl 0hRhUuXycesEtzkRF08SMOWJS+0VAM2fdvAGoBycOFC7PDu2J1DPojZOoH9Q5AMQiayb wQ6OiNhqyqM9/h80STXYDSgucxItZvrmZXWOwX44NAOTaX9x7jNFz4bRHrtWJd1AddMk kN9Yxdw1z0wxb7SLKBiSAS7RrX+L0oNz+BhdNACH26cgQTpYv5QO005xOaBlYRMksoMr FUEQ== X-Forwarded-Encrypted: i=1; AJvYcCWUC/8u4UH/p6CYNlh20YyOi3V5gbzmVm2oZd4iTrjxVwXYd1xbCjQV8qGfCwAO4cZ8lrdfQCrAurv9Rgz9tmN6hoc=@vger.kernel.org X-Gm-Message-State: AOJu0YxG7v+ixQtJDUI4e9T4uJ4j3JQIt2DhNRRbyg/C2NEf/MXEGE3f UmxoKXU4QTbgroJkKRq5fbjSgZN9IfIXgG4+H7ZZmtc/y7sKHbNTymt5VUAbiQ== X-Gm-Gg: ATEYQzwkWWIDsqhxC8hMyIcXdZ3zYKMiSCFlnNglPtZQ+8ucVAm5ucAgQ1oWd0+N9Zy qiOkny5eQz9HL8fszt0hjYr61k0EAd+cRKW5VhssNP6jas5YV2luOGgt1V0BHvGRwAi9hIvjlW1 RNoADl4eBmtQQrvwwuKGo74EF2jfPw0PkwFSVjryXpVEmBA9WnB8BCTFvn7Daztr2kJ1nRVflqs 5h8zVM0NOcbY2kV/HKHdBRuZOxLjrgKHUkrtnjKI+uXoAABt/BrslHLd6/02pz+L+QVijHcW0sP ayWiKKTvvJ2rw3uVTv0dJ+yOQ46jGRtaKdEVZ+uKIlmzOH8tIoZfKZ3OEGhUew8EI/MRM2y576M WEiSUZLEN7POHcxPtUlOvtXwfOQ7eycgSuuHszNQKGGhVG/bz3qocaaPnK7ykQJ42FhLqorC+rU vQv0Zoek2otloNv7AsKeohNY2dMLC+Om/H7FfgukMNX3ltPWk8U5Xa098Suopn/p/g X-Received: by 2002:a05:7022:501:b0:123:331d:bdbb with SMTP id a92af1059eb24-128e781fe8amr639411c88.22.1773205890451; Tue, 10 Mar 2026 22:11:30 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:6e17:9d84:ffa0:986b]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-128e7c1ff96sm1369730c88.8.2026.03.10.22.11.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 22:11:30 -0700 (PDT) Date: Tue, 10 Mar 2026 22:11:27 -0700 From: Dmitry Torokhov To: Jingyuan Liang Cc: Jiri Kosina , Benjamin Tissoires , Jonathan Corbet , Mark Brown , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-input@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-trace-kernel@vger.kernel.org, devicetree@vger.kernel.org, hbarnor@chromium.org, Jarrett Schultz , Dmitry Antipov Subject: Re: [PATCH 02/12] HID: Add BUS_SPI support and define HID_SPI_DEVICE macro Message-ID: References: <20260303-send-upstream-v1-0-1515ba218f3d@chromium.org> <20260303-send-upstream-v1-2-1515ba218f3d@chromium.org> Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260303-send-upstream-v1-2-1515ba218f3d@chromium.org> On Tue, Mar 03, 2026 at 06:12:54AM +0000, Jingyuan Liang wrote: > From: Jarrett Schultz > > If connecting a hid_device with bus field indicating BUS_SPI print out > "SPI" in the debug print. > > Macro sets the bus field to BUS_SPI and uses arguments to set vendor > product fields. > > Signed-off-by: Dmitry Antipov > Signed-off-by: Jingyuan Liang > --- > drivers/hid/hid-core.c | 3 +++ > include/linux/hid.h | 2 ++ > 2 files changed, 5 insertions(+) > > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c > index a5b3a8ca2fcb..813c9c743ccd 100644 > --- a/drivers/hid/hid-core.c > +++ b/drivers/hid/hid-core.c > @@ -2316,6 +2316,9 @@ int hid_connect(struct hid_device *hdev, unsigned int connect_mask) > case BUS_I2C: > bus = "I2C"; > break; > + case BUS_SPI: > + bus = "SPI"; > + break; > case BUS_SDW: > bus = "SOUNDWIRE"; > break; > diff --git a/include/linux/hid.h b/include/linux/hid.h > index dce862cafbbd..957f322a0ebd 100644 > --- a/include/linux/hid.h > +++ b/include/linux/hid.h > @@ -786,6 +786,8 @@ struct hid_descriptor { > .bus = BUS_BLUETOOTH, .vendor = (ven), .product = (prod) > #define HID_I2C_DEVICE(ven, prod) \ > .bus = BUS_I2C, .vendor = (ven), .product = (prod) > +#define HID_SPI_DEVICE(ven, prod) \ > + .bus = BUS_SPI, .vendor = (ven), .product = (prod) > > #define HID_REPORT_ID(rep) \ > .report_type = (rep) Reviewed-by: Dmitry Torokhov Thanks. -- Dmitry