Re: [PATCHv3 bpf-next 22/24] selftests/bpf: Add tracing multi attach fails test

[Jiri Olsa <olsajiri@gmail.com>]

On Tue, Mar 17, 2026 at 11:06:58AM +0800, Leon Hwang wrote:

SNIP

> > +	/* fail#3 pattern and cookies */
> > +	opts.ids = NULL;
> > +	opts.cnt = 2;
> > +	opts.cookies = cookies;
> > +
> > +	skel->links.test_fentry = bpf_program__attach_tracing_multi(skel->progs.test_fentry,
> > +						"bpf_fentry_test*", &opts);
> > +	if (!ASSERT_ERR_PTR(skel->links.test_fentry, "bpf_program__attach_tracing_multi"))
> > +		goto cleanup;
> > +
> > +	/* fail#4 bogus pattern */
> > +	skel->links.test_fentry = bpf_program__attach_tracing_multi(skel->progs.test_fentry,
> > +						"bpf_not_really_a_function*", NULL);
> > +	if (!ASSERT_ERR_PTR(skel->links.test_fentry, "bpf_program__attach_tracing_multi"))
> > +		goto cleanup;
> > +
> > +	/* fail#5 abnormal cnt */
> > +	opts.ids = ids;
> > +	opts.cnt = INT_MAX;
> > +
> > +	skel->links.test_fentry = bpf_program__attach_tracing_multi(skel->progs.test_fentry,
> > +						NULL, &opts);
> > +	if (!ASSERT_ERR_PTR(skel->links.test_fentry, "bpf_program__attach_tracing_multi"))
> > +		goto cleanup;
> > +
> > +	/* fail#6 attach sleepable program to not-allowed function */
> > +	ids2 = get_ids(func, 1, NULL);
> > +	if (!ASSERT_OK_PTR(ids, "get_ids"))
>                            ^ ids2 ?

yes

> 
> > +		goto cleanup;
> > +
> > +	opts.ids = ids2;
> > +	opts.cnt = 1;
> > +
> > +	skel->links.test_fentry_s = bpf_program__attach_tracing_multi(skel->progs.test_fentry_s,
> > +						NULL, &opts);
> > +	ASSERT_ERR_PTR(skel->links.test_fentry, "bpf_program__attach_tracing_multi");
>                                    ^ test_fentry_s ?

yes, will fix, thnx

jirka