From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF57A3B583B for ; Tue, 7 Apr 2026 12:59:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775566760; cv=none; b=adXOd/pRbaGEtSz9HRZkwTCF7fUfdF0XAMSaIqxaVI+0nAeUMgoqcJ1idp/bj9625j71PLSz4TJ0usJRGPF7k5TDXXDyPv+FEp+nGqWtWgeH0vLIZSqHK3+ibS1JVXxEEDK7P+OGT17thZW7xXs7Z/T0DJlDDL0Oh6gON2b2FLI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775566760; c=relaxed/simple; bh=MRMavbZxCmCqu97ErQH2KvVIS98vfvYbGQ+qfUPr1Ko=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QrQxFJLJFjo3KxO6/SUi/PRUjg5lkTCaHxMVFVY8Pv66D3W3sGl0tRmHJ2VV1n817RCXUuWMDiszbsPGa0mVgZK1Fe6NnBWOZXnwxczhvtvRYgeX9v85dS1Q697plJo+EG3jXiqAOjP4mkMdZhz5hupkq+MgqPL+94MuRsjVHA4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kBcv96/r; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kBcv96/r" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-43b95e5b3afso2772284f8f.3 for ; Tue, 07 Apr 2026 05:59:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775566757; x=1776171557; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=OGNXMEdomMQOlLGOIDoXABUDmvC0Bd8MldldSKwLSgU=; b=kBcv96/rrTo2xLduUbuybkQiPVfjyBN1g6CAF2tlfNk1anGH2d21Dw/yD/DEjeAxHh +wS0kyy9FDvzHFJKr1HXGSC7S/kM5/F/1yYRY753AAV3ZweVTuyo7cg5FG3PJRe0QrvY gWRvMJLTYhyp8lf11I6yvnbflQaawNdU138a31O+R61hgQa1ya/qSkVwt/NLSmcKEZfd ZGBV/Ix84czcD+4NUsTd+Pb82TbyZf2DI+OK83tUIsts00hwN8LzHUzY0WAzEPuQvUM7 LYla06e55ACBK7sbFY6x7/87KnUaiCnx3QkimIiZV3LrRMMaelcPpVwTCQadbfWLoYM0 3A9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775566757; x=1776171557; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OGNXMEdomMQOlLGOIDoXABUDmvC0Bd8MldldSKwLSgU=; b=IZ5we2p3MtyNWUmwPwka97hhNf1GK83fFLm7yJKeKOfE9w06i7RJnrd3IA/6qou26Q Hyfm5iqkKUVZxX6IeSWpZ8SJHC6aRRC2q6g/c7sBTqOont2qLuBK0eb6/xoZQ4ZB7Pln enDUNmTFrTElwCXoifxVK0rUVIu+orcz4ausfhKYRAPtp1SsDuZgLNHDK0bnc6US5/6D n1eU5BicQy6kKidLBysSRM3rkTcvZtckdN/pPZAm76FqGmw1PvHj2Ffs2txosTxmtBcI mzMZY5eRxxrpKOtimEjFK/afayEfzciCt7CfclbZS6dR95VnqpCwxjCm8kmQNRUjNT11 dgzw== X-Forwarded-Encrypted: i=1; AJvYcCV9ZF39cUkSJ7sF0kuYNUrP98ZNle3FF77G2xtJDc8dKlEFG1pdbjzrszKX77qv6NJ6RFaHL3lZbqL4aeyHIq9cN/U=@vger.kernel.org X-Gm-Message-State: AOJu0YzuF2xjS62uBqRizJBbWdEigaeFV1IJ9G+fMOglzglqTHPJpFFf BxWSA3CyMthnFogfu8ltNcTnM3n0UFQh1oY5YNvornz3po7iMoJKCMSz X-Gm-Gg: AeBDievoxtNESjaYf95jQh/kqtu2K7zEiw27lOD6IgK2tZCOPBcHiiVn01iMwJf1qBo Wb7U+bSFugink9GXfyC7crn6Qmc9t51P7LMvgvjky3cSvn634A8r2p6eBPbFI6QPwCWEwbNlkbn 9jWus5qprjv3ybNf6k8u3K6mf1IaG14z0rBiPOWebDFXnFn9esorlDjWLsS1wt6MhwPZpy/Mmj8 GjPrtpRE+E/Y2Mklh/sI5RKB8Q51yvJkGncaD74j3c7o3srYQ7FJmHmmufcIxkwFN4dOCnxh5op 3v5CU8b3b8JjplXKuO3up84XpqoaVTz8oudk55xvy+S5iuijEpmLqJI8TFe3eodg7FMgRYujpn8 fQ+6BGm9fJf6evR/9VMpp8Z4aeBXSZhh9CCGaMVZAXlcoRU71+nyiZGP0aCJPyYjwN1adxQrkWZ A1sUwg33Flbys= X-Received: by 2002:a05:6000:2903:b0:43b:3d4f:e18d with SMTP id ffacd0b85a97d-43d292e8001mr24841203f8f.39.1775566756876; Tue, 07 Apr 2026 05:59:16 -0700 (PDT) Received: from krava ([176.74.159.170]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d1e2a6f73sm53750505f8f.8.2026.04.07.05.59.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 05:59:16 -0700 (PDT) From: Jiri Olsa X-Google-Original-From: Jiri Olsa Date: Tue, 7 Apr 2026 14:59:14 +0200 To: bot+bpf-ci@kernel.org Cc: andrey.grodzovsky@crowdstrike.com, bpf@vger.kernel.org, linux-trace-kernel@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, rostedt@goodmis.org, mhiramat@kernel.org, ihor.solodrai@linux.dev, emil@etsalapatis.com, linux-open-source@crowdstrike.com, martin.lau@kernel.org, eddyz87@gmail.com, yonghong.song@linux.dev, clm@meta.com Subject: Re: [RFC PATCH bpf-next v5 1/2] tracing: Prefer vmlinux symbols over module symbols for unqualified kprobes Message-ID: References: <20260406193158.754498-2-andrey.grodzovsky@crowdstrike.com> <669779524c357c9790196e8e9ce8da8b21a71756c96e828252fead311fdc44c3@mail.kernel.org> Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <669779524c357c9790196e8e9ce8da8b21a71756c96e828252fead311fdc44c3@mail.kernel.org> On Mon, Apr 06, 2026 at 08:15:10PM +0000, bot+bpf-ci@kernel.org wrote: > > Signed-off-by: Andrey Grodzovsky > > Suggested-by: Ihor Solodrai > > This commit fixes a bug introduced when module symbol counting was > added to number_of_same_symbols(). Would it be worth adding a > Fixes: tag? > > Suggested: > Fixes: 926fe783c8a6 ("tracing/kprobes: Fix symbol counting logic by looking at modules as well") there's also: 9d8616034f16 tracing/kprobes: Add symbol counting check when module loads jirka > > That commit added module_kallsyms_on_each_symbol() to > number_of_same_symbols(), which caused unqualified kprobe targets > matching both vmlinux and a module to return count > 1 and fail > with -EADDRNOTAVAIL. > > > --- > AI reviewed your patch. Please fix the bug or email reply why it's not a bug. > See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md > > CI run summary: https://github.com/kernel-patches/bpf/actions/runs/24047967861