Re: [PATCH 0/9] rtla/tests: Extend runtime test coverage

[Wander Lairson Costa <wander@redhat.com>]

On Thu, Apr 23, 2026 at 03:05:49PM +0200, Tomas Glozar wrote:
> This patchset introduces some new tests to cover more options, especially
> histogram and thread options. Most of the new tests use positive and negative
> output matches, sometimes in combination with action scripts, to verify that
> RTLA is applying the settings correctly.
> 
> Tests were reorganized a little, adding two new sections: thread tests and
> histogram tests, next to basic tests.
> 
> Additionally, coverage of existing tests is extended by adding new matches and
> by extending tests to cover both top and hist tools where possible. For the
> latter, new helpers check_top_hist and check_top_q_hist are added to engine.sh.
> 
> As part of the new action scripts, detection of measurement threads is made more
> robust by following child processes of either RTLA (user workload) or kthreadd
> (kernel workload) rather than grepping through the comms of all processes, which
> might have lead to false positives.
> 
> These changes significantly improve test coverage and make the test suite more
> against false positives from unrelated processes.

Reviewed-by: Wander Lairson Costa <wander@redhat.com>

> 
> Tomas Glozar (9):
>   rtla/tests: Cover both top and hist tools where possible
>   rtla/tests: Add get_workload_pids() helper
>   rtla/tests: Check -c/--cpus thread affinity
>   rtla/tests: Use negative match when testing --aa-only
>   rtla/tests: Extend timerlat top --aa-only coverage
>   rtla/tests: Cover all hist options in runtime tests
>   rtla/tests: Add runtime test for -H/--house-keeping
>   rtla/tests: Add runtime test for -k and -u options
>   rtla/tests: Add runtime tests for -C/--cgroup
> 
>  tools/tracing/rtla/tests/engine.sh            |  15 +++
>  tools/tracing/rtla/tests/osnoise.t            |  73 +++++++----
>  .../rtla/tests/scripts/check-cgroup-match.sh  |  17 +++
>  .../tracing/rtla/tests/scripts/check-cpus.sh  |   9 ++
>  .../tests/scripts/check-housekeeping-cpus.sh  |   4 +
>  .../rtla/tests/scripts/check-priority.sh      |   8 +-
>  .../scripts/check-user-kernel-threads.sh      |  16 +++
>  .../tests/scripts/lib/get_workload_pids.sh    |  11 ++
>  tools/tracing/rtla/tests/timerlat.t           | 113 +++++++++++-------
>  9 files changed, 194 insertions(+), 72 deletions(-)
>  create mode 100755 tools/tracing/rtla/tests/scripts/check-cgroup-match.sh
>  create mode 100755 tools/tracing/rtla/tests/scripts/check-cpus.sh
>  create mode 100755 tools/tracing/rtla/tests/scripts/check-housekeeping-cpus.sh
>  create mode 100755 tools/tracing/rtla/tests/scripts/check-user-kernel-threads.sh
>  create mode 100644 tools/tracing/rtla/tests/scripts/lib/get_workload_pids.sh
> 
> -- 
> 2.53.0
>