From: Lukasz Luba <lukasz.luba@arm.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: catalin.marinas@arm.com, will@kernel.org,
daniel.lezcano@linaro.org, mhiramat@kernel.org,
rui.zhang@intel.com, vschneid@redhat.com, bristot@redhat.com,
bsegall@google.com, dietmar.eggemann@arm.com,
juri.lelli@redhat.com, peterz@infradead.org, mingo@redhat.com,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, agross@kernel.org,
konrad.dybcio@linaro.org, andersson@kernel.org,
viresh.kumar@linaro.org, sudeep.holla@arm.com, rafael@kernel.org,
rostedt@goodmis.org, mgorman@suse.de, amit.kachhap@gmail.com,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] cpufreq: Add a cpufreq pressure feedback for the scheduler
Date: Thu, 14 Dec 2023 09:21:11 +0000 [thread overview]
Message-ID: <af7b67d1-c4a3-44e3-a632-5f0a4ea6eb25@arm.com> (raw)
In-Reply-To: <20231212142730.998913-2-vincent.guittot@linaro.org>
On 12/12/23 14:27, Vincent Guittot wrote:
> Provide to the scheduler a feedback about the temporary max available
> capacity. Unlike arch_update_thermal_pressure, this doesn't need to be
> filtered as the pressure will happen for dozens ms or more.
>
> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
> ---
> drivers/cpufreq/cpufreq.c | 48 +++++++++++++++++++++++++++++++++++++++
> include/linux/cpufreq.h | 10 ++++++++
> 2 files changed, 58 insertions(+)
>
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 44db4f59c4cc..7d5f71be8d29 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -2563,6 +2563,50 @@ int cpufreq_get_policy(struct cpufreq_policy *policy, unsigned int cpu)
> }
> EXPORT_SYMBOL(cpufreq_get_policy);
>
> +DEFINE_PER_CPU(unsigned long, cpufreq_pressure);
> +EXPORT_PER_CPU_SYMBOL_GPL(cpufreq_pressure);
Why do we export this variable when we have get/update functions?
Do we expect modules would manipulate those per-cpu variables
independently and not like we do per-cpumask in the update func.?
next prev parent reply other threads:[~2023-12-14 9:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 14:27 [PATCH 0/5] Rework system pressure interface to the scheduler Vincent Guittot
2023-12-12 14:27 ` [PATCH 1/4] cpufreq: Add a cpufreq pressure feedback for " Vincent Guittot
2023-12-13 7:17 ` Viresh Kumar
2023-12-13 8:05 ` Vincent Guittot
2023-12-14 0:41 ` Tim Chen
2023-12-14 5:36 ` Viresh Kumar
2023-12-14 5:43 ` Viresh Kumar
2023-12-14 7:57 ` Vincent Guittot
2023-12-14 9:08 ` Lukasz Luba
2023-12-14 9:40 ` Rafael J. Wysocki
2023-12-14 10:41 ` Lukasz Luba
2023-12-14 9:21 ` Lukasz Luba [this message]
2023-12-14 11:06 ` Vincent Guittot
2023-12-12 14:27 ` [PATCH 2/4] sched: Take cpufreq feedback into account Vincent Guittot
2023-12-15 16:03 ` Lukasz Luba
2023-12-12 14:27 ` [PATCH 3/4] thermal/cpufreq: Remove arch_update_thermal_pressure() Vincent Guittot
2023-12-15 15:38 ` Lukasz Luba
2023-12-12 14:27 ` [PATCH 4/4] sched: Rename arch_update_thermal_pressure into arch_update_hw_pressure Vincent Guittot
2023-12-14 8:31 ` Lukasz Luba
2023-12-14 8:36 ` Vincent Guittot
2023-12-14 8:54 ` Lukasz Luba
2023-12-14 8:54 ` Vincent Guittot
2023-12-14 8:22 ` [PATCH 0/5] Rework system pressure interface to the scheduler Lukasz Luba
2023-12-14 8:29 ` Vincent Guittot
2023-12-14 8:32 ` Lukasz Luba
2023-12-15 15:54 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af7b67d1-c4a3-44e3-a632-5f0a4ea6eb25@arm.com \
--to=lukasz.luba@arm.com \
--cc=agross@kernel.org \
--cc=amit.kachhap@gmail.com \
--cc=andersson@kernel.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=catalin.marinas@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=rostedt@goodmis.org \
--cc=rui.zhang@intel.com \
--cc=sudeep.holla@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=vschneid@redhat.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).