From: Thierry Reding <thierry.reding@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Artur Kowalski <arturkow2000@gmail.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
Thierry Reding <thierry.reding@kernel.org>,
Mikko Perttunen <mperttunen@nvidia.com>,
David Airlie <airlied@gmail.com>,
Simona Vetter <simona@ffwll.ch>
Subject: Re: [PATCH] gpu: host1x: trace: fix string fields in host1x traces
Date: Wed, 20 May 2026 14:03:17 +0200 [thread overview]
Message-ID: <ag2iF9bZJcBQ93lh@orome> (raw)
In-Reply-To: <20260519141059.77435501@fedora>
[-- Attachment #1: Type: text/plain, Size: 845 bytes --]
On Tue, May 19, 2026 at 02:10:59PM -0400, Steven Rostedt wrote:
> On Tue, 19 May 2026 12:16:43 +0200
> Artur Kowalski <arturkow2000@gmail.com> wrote:
>
> > Use __assign_str and __get_str as required by tracing subsystem. Fixes
> > string fields being rejected by the verifier and unreadable from
> > userspace.
>
> Does anyone use these tracepoints? The fact that they have been broken
> for 5 years and nobody noticed makes me think they are useless.
>
> I rather remove them than fix them, but if someone thinks that these
> are still useful then by all means apply this patch.
>
> Acked-by: Steven Rostedt <rostedt@goodmis.org>
I know that Mikko used them a lot early on, but this driver is pretty
mature now, so we rarely need this low level of tracing. I'll defer to
Mikko on whether we still need these.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2026-05-20 12:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 10:16 [PATCH] gpu: host1x: trace: fix string fields in host1x traces Artur Kowalski
2026-05-19 18:10 ` Steven Rostedt
2026-05-20 12:03 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ag2iF9bZJcBQ93lh@orome \
--to=thierry.reding@gmail.com \
--cc=airlied@gmail.com \
--cc=arturkow2000@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mperttunen@nvidia.com \
--cc=rostedt@goodmis.org \
--cc=simona@ffwll.ch \
--cc=thierry.reding@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox