From: Wander Lairson Costa <wander@redhat.com>
To: Crystal Wood <crwood@redhat.com>
Cc: Tomas Glozar <tglozar@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
linux-trace-kernel@vger.kernel.org,
John Kacur <jkacur@redhat.com>,
Costa Shulyupin <costa.shul@redhat.com>
Subject: Re: [PATCH v2] rtla: Stop the record trace on interrupt
Date: Tue, 9 Jun 2026 09:05:40 -0300 [thread overview]
Message-ID: <aigBcatMTt2LJvdD@wcosta-defaultstring.rmtbr.csb> (raw)
In-Reply-To: <20260512173731.2151841-1-crwood@redhat.com>
On Tue, May 12, 2026 at 12:37:31PM -0500, Crystal Wood wrote:
> Before, when rtla got a signal, it stopped the main trace but not the
> record trace. With "--on-end trace", this can lead to
> save_trace_to_file() failing to keep up, especially on a debug kernel.
> Plus, it adds post-stoppage noise to the trace file.
>
> Signed-off-by: Crystal Wood <crwood@redhat.com>
> ---
> v2: clarify that this matters for --on-end trace
>
> tools/tracing/rtla/src/common.c | 19 +++++++++++--------
> tools/tracing/rtla/src/common.h | 1 -
> tools/tracing/rtla/src/timerlat.c | 2 +-
> 3 files changed, 12 insertions(+), 10 deletions(-)
Reviewed-by: Wander Lairson Costa <wander@redhat.com>
prev parent reply other threads:[~2026-06-09 12:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 17:37 [PATCH v2] rtla: Stop the record trace on interrupt Crystal Wood
2026-06-09 12:05 ` Wander Lairson Costa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aigBcatMTt2LJvdD@wcosta-defaultstring.rmtbr.csb \
--to=wander@redhat.com \
--cc=costa.shul@redhat.com \
--cc=crwood@redhat.com \
--cc=jkacur@redhat.com \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglozar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox