From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F96A329E79; Thu, 11 Jun 2026 15:53:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781193193; cv=none; b=Y/KW82Xv9RqqH1cO6KHexDCzUoIVvsElQ/DjWYxgEuixDl+a34fAX0uEcFEYYI37X6B+dq4kmMSXDXgs2bgoTIddB9rdb6dO9OAupRWtUSzt/ogU6tSZiV0XcV70yUaZkEPGbS/fRKPv7sqlscyJpV+1sJMdLsY6dHLktSRojEU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781193193; c=relaxed/simple; bh=3tf8tVVdzCC9tsUBWHR2BG9ZmTnZKe5b69Q+i1FQsqE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=t2ErlIgVclMD35+dztDLUSHX9cbWHyi7Y4vx6LPVLAXYpuxCuEOMWuqFAPwqVgHS4cw/HFoEDtwqreQj72Z5kxtI2p0kaTlKEwbfOI5S6ZZKMvHlbGVLN6+98gj5WPmjbKFevsM6TQbw4TKq+fAREfVl66Y9dIY3et1NP7uN3FM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iRtpZ5ki; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iRtpZ5ki" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 472281F00893; Thu, 11 Jun 2026 15:52:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781193191; bh=nWWQcnr5s3ZKYSOjuOdhQYovdi3ZfrWWs+mggmJcT0A=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=iRtpZ5kieFw5S9ITnjIH6j0aWcKNh5JeuF+zK4u3Gb5BHGjXDX+63qYpICXZOqKKf FMpn/eSPdZ3uUDY2hsCqbr+TZrG/QR3UZsXMiEpeUFOJx1TvgaWPpU2Sve9CrFxXl+ FPqFy7tIGDmG52exo9PstHq6ST6VxUMQd8EOxUjVYsICVz7IejXX1Gsp7Nm89bi+jK mGw7lODaN60ngB2FLEwNaIgnCWslUjDqMZ+ZD+N8Eh+psAFgBJrySRm3icp1ZA6RjP 0zyMAq/g3K9uC6d61CATLKH+E8nSZtrkkgmOOG/Fc7JJu4bfrSi9nkah1Wa+lwiqQ1 d8kGPcHyRzcdA== Date: Thu, 11 Jun 2026 16:52:54 +0100 From: Lorenzo Stoakes To: Huang Shijie Cc: akpm@linux-foundation.org, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, muchun.song@linux.dev, osalvador@suse.de, david@kernel.org, surenb@google.com, mjguzik@gmail.com, liam@infradead.org, vbabka@kernel.org, shakeel.butt@linux.dev, rppt@kernel.org, mhocko@suse.com, corbet@lwn.net, skhan@linuxfoundation.org, linux@armlinux.org.uk, dinguyen@kernel.org, schuster.simon@siemens-energy.com, James.Bottomley@hansenpartnership.com, deller@gmx.de, djbw@kernel.org, willy@infradead.org, peterz@infradead.org, mingo@redhat.com, acme@kernel.org, namhyung@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com, james.clark@linaro.org, mhiramat@kernel.org, oleg@redhat.com, ziy@nvidia.com, baolin.wang@linux.alibaba.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, linmiaohe@huawei.com, nao.horiguchi@gmail.com, jannh@google.com, pfalcato@suse.de, riel@surriel.com, harry@kernel.org, will@kernel.org, brian.ruley@gehealthcare.com, rmk+kernel@armlinux.org.uk, dave.anglin@bell.net, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-parisc@vger.kernel.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, linux-perf-users@vger.kernel.org, linux-trace-kernel@vger.kernel.org, zhongyuan@hygon.cn, fangbaoshun@hygon.cn, yingzhiwei@hygon.cn Subject: Re: [PATCH v2 1/4] mm: use mapping_mapped to simplify the code Message-ID: References: <20260611061915.2354307-1-huangsj@hygon.cn> <20260611061915.2354307-2-huangsj@hygon.cn> Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260611061915.2354307-2-huangsj@hygon.cn> On Thu, Jun 11, 2026 at 02:18:57PM +0800, Huang Shijie wrote: > Use mapping_mapped() to simplify the code, make > the code tidy and clean. > > Signed-off-by: Huang Shijie Yeah as Pedro said this one could just be sent separately, and I in fact suggest you do that :) So: Reviewed-by: Lorenzo Stoakes Cheers, Lorenzo > --- > fs/hugetlbfs/inode.c | 4 ++-- > mm/memory.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c > index 78d61bf2bd9b..216e1a0dd0b2 100644 > --- a/fs/hugetlbfs/inode.c > +++ b/fs/hugetlbfs/inode.c > @@ -614,7 +614,7 @@ static void hugetlb_vmtruncate(struct inode *inode, loff_t offset) > > i_size_write(inode, offset); > i_mmap_lock_write(mapping); > - if (!RB_EMPTY_ROOT(&mapping->i_mmap.rb_root)) > + if (mapping_mapped(mapping)) > hugetlb_vmdelete_list(&mapping->i_mmap, pgoff, 0, > ZAP_FLAG_DROP_MARKER); > i_mmap_unlock_write(mapping); > @@ -675,7 +675,7 @@ static long hugetlbfs_punch_hole(struct inode *inode, loff_t offset, loff_t len) > > /* Unmap users of full pages in the hole. */ > if (hole_end > hole_start) { > - if (!RB_EMPTY_ROOT(&mapping->i_mmap.rb_root)) > + if (mapping_mapped(mapping)) > hugetlb_vmdelete_list(&mapping->i_mmap, > hole_start >> PAGE_SHIFT, > hole_end >> PAGE_SHIFT, 0); > diff --git a/mm/memory.c b/mm/memory.c > index 86a973119bd4..5335077765e2 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -4386,7 +4386,7 @@ void unmap_mapping_folio(struct folio *folio) > details.zap_flags = ZAP_FLAG_DROP_MARKER; > > i_mmap_lock_read(mapping); > - if (unlikely(!RB_EMPTY_ROOT(&mapping->i_mmap.rb_root))) > + if (unlikely(mapping_mapped(mapping))) > unmap_mapping_range_tree(&mapping->i_mmap, first_index, > last_index, &details); > i_mmap_unlock_read(mapping); > @@ -4416,7 +4416,7 @@ void unmap_mapping_pages(struct address_space *mapping, pgoff_t start, > last_index = ULONG_MAX; > > i_mmap_lock_read(mapping); > - if (unlikely(!RB_EMPTY_ROOT(&mapping->i_mmap.rb_root))) > + if (unlikely(mapping_mapped(mapping))) > unmap_mapping_range_tree(&mapping->i_mmap, first_index, > last_index, &details); > i_mmap_unlock_read(mapping); > -- > 2.53.0 > >