From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDC221A681C for ; Tue, 23 Jun 2026 00:16:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782173786; cv=none; b=dEP8Vk4H9DXwmYf4Rkvd2uEiOtD83dyDTt3BwCHBpWGBpDGUQpGy60KQJhAYeWSzWHvfJRUNn34O/xjp/izLo5J9BZBQ7vE0qlyXpRXVAAR+JQtkCkp2AUWl71m4UO2QVPe8Xw+wELQF55i/QL47S1eMJxZvZT/ukXwjUm3xHy4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782173786; c=relaxed/simple; bh=qLskmc5gvD/9BaiuXAI/iFKmnqqzh0h9QIDjBTZ0PXE=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=At8DOoctO/AjJl7T4aFFUzLZ5hmWBjNBVY41b2Oj4blRANXR8U7Frd+6XbentSyqz/MKA3oBD/cRMyKh7VOEK5lAoxcurLFzlAq069JgLAD9NrgHSPfhmMjuSgO3sbOwKPlFkXYJt79qjxE0ESkvz9qLB2d48WhDTcCrhS+4tBI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=n2nEmZ94; arc=none smtp.client-ip=209.85.214.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="n2nEmZ94" Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-2c0b35fa876so50217165ad.1 for ; Mon, 22 Jun 2026 17:16:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782173784; x=1782778584; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=ob/JScNjh/WWoydgNSe9txnAf4hRBZPGssYHA/PqDQI=; b=n2nEmZ94mxvA+lai+6Nh0ZiBIJzl7a/IMtTQRqW4JZZkk8uFufvvOREjC752eox1rF 7xkL2j0126JGecyQ5I/7SF3iHMBHZePNgbmQJWtqMQawBYe1yrLJ7iTe/42qNR6/cAae 09xvS6I0y5JnNS2+avc3np7u1mp0c09wv3dl93dH29PbAu2nPZNbKGogZ1prznqQ5lhp fdcTeignOfeIsdVTeiXj3Wyv/BR2syKrUHLeQcdrF0c3BjOnU1lMkxuV1MzsbPtCX7Tz PrYtJcs5aOabpuMh7oysafuGVSIcr0iupyunnP2E8sfdkw8GBkrtm2n+xqNvEEurt+Xf ogRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782173784; x=1782778584; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ob/JScNjh/WWoydgNSe9txnAf4hRBZPGssYHA/PqDQI=; b=nfodTd1XA1Nyfx5RENH3up9Lzn1CnQ1fdta9qn6AZw44Ahfbv5pROrvb5GusqNm0qZ jFtn/uW+MqwaaY8HXv95+HFGV5ZrKvQgzBB3Pu6UDXxoBtUs5+UbNV8tGSEkjN9WTMHX sZItgsVRo4xMYXc1HO0xizjWLzwwzVhf4j7BrYerLYMcC/He/unyJkhR+S3Q9ZXndNf2 wENQZ9PCm7DUmvD7po/x6xona3EkJyx59IWtCPrpRNlO2jpu8xSLJl3ira2eS7LsHuJu yIuPIapNS7sotUYZ15ibLHEFkJWFWGVTmoYGpxaDgv8WL2LXW5d4mUcDRd6by2BS1ADZ m7xA== X-Forwarded-Encrypted: i=1; AHgh+Rpy5StFhUosHMx0n1rBUrVgvKpidjPInc+fDzwsxIr9zCsMAbqnAl/Wqf9fOSzIMTAcR19GqJTldipIExqb79CWoZE=@vger.kernel.org X-Gm-Message-State: AOJu0Yxmn9xOnZwOZ5MKBOb+CL+aJVKK464CIcMi0FWJcQ552MEVZp3L j3/mh0RlxWsSSS/7uvu/mKxJUq2qG0RPnqytIwi6GzsZTH2PxXPBMIuPaF3UP2uSgQ6nozC8wvv oyYPuFQ== X-Received: from plbkx8.prod.google.com ([2002:a17:902:f948:b0:2bd:106:8ad0]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:da90:b0:2c7:c3a8:560b with SMTP id d9443c01a7336-2c7c3b7a5femr16356295ad.18.1782173782987; Mon, 22 Jun 2026 17:16:22 -0700 (PDT) Date: Mon, 22 Jun 2026 17:16:22 -0700 In-Reply-To: <8e53844c-f2f8-4a4b-bf72-f3140c170d43@gmail.com> Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260618-gmem-inplace-conversion-v8-0-9d2959357853@google.com> <20260618-gmem-inplace-conversion-v8-5-9d2959357853@google.com> <8e53844c-f2f8-4a4b-bf72-f3140c170d43@gmail.com> Message-ID: Subject: Re: [PATCH v8 05/46] KVM: Make CONFIG_KVM_VM_MEMORY_ATTRIBUTES selectable From: Sean Christopherson To: Julian Braha Cc: ackerleytng@google.com, aik@amd.com, andrew.jones@linux.dev, binbin.wu@linux.intel.com, brauner@kernel.org, chao.p.peng@linux.intel.com, david@kernel.org, jmattson@google.com, jthoughton@google.com, michael.roth@amd.com, oupton@kernel.org, pankaj.gupta@amd.com, qperret@google.com, rick.p.edgecombe@intel.com, rientjes@google.com, shivankg@amd.com, steven.price@arm.com, tabba@google.com, willy@infradead.org, wyihan@google.com, yan.y.zhao@intel.com, forkloop@google.com, pratyush@kernel.org, suzuki.poulose@arm.com, aneesh.kumar@kernel.org, liam@infradead.org, Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Jonathan Corbet , Shuah Khan , Shuah Khan , Vishal Annapurve , Andrew Morton , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Barry Song , Axel Rasmussen , Yuanchu Xie , Wei Xu , Youngjun Park , Qi Zheng , Shakeel Butt , Kiryl Shutsemau , Baoquan He , Jason Gunthorpe , Vlastimil Babka , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev Content-Type: text/plain; charset="us-ascii" On Fri, Jun 19, 2026, Julian Braha wrote: > Hi Ackerley, > > On 6/19/26 01:31, Ackerley Tng via B4 Relay wrote: > > > config KVM_VM_MEMORY_ATTRIBUTES > > - bool > > + depends on KVM_SW_PROTECTED_VM || KVM_INTEL_TDX || KVM_AMD_SEV > > + bool "Enable per-VM PRIVATE vs. SHARED attributes (for CoCo VMs)" > > Sorry for the style nitpick, but could you keep the type and prompt as > the first attribute in the Kconfig option definition (like the other > options do)? No need to be sorry, I've no idea why I put the "depends" first. I don't even know if that qualifies as a nit :-) Ackerley, if you can provide your SoB (for Fuad's feedback), I can fixup when applying (assuming nothing else necessitates v9).