From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9719C367298 for ; Thu, 9 Jul 2026 15:18:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783610331; cv=none; b=UVJzxx1d09CLZ6mo2wBjNPZReftq4obrYu3VjmJkTdDhfbAgzu6iGsVDG2nQ/oliwUgQycxPgyAVEuqnKqFAytO8+PuEyjC00P6BXmaGNQasKhe9eLpmrFzE9y88dzFu9EOSp8NNqj5l8F8thVG4omf2Qcn0HcEz0D2jISj4qsI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783610331; c=relaxed/simple; bh=EmhDmZEzfDqtz+/wM5OYtSnBNKhNR5z6WmgKAnKqYZg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=b6IRr/hWaJZww+koLV4wsba0EcYhIoGXliS7LHHfdt2Xql6/VHGqPxC2ZkQ6Xq3xQRIxNjCi0ngb1fCcMB08phLiXfTrJ/2Qt8f59T19jRSyjXvMbTkrzdBPxuZxKdj2gS8mbg/yO9Tvpm+ogZeOxyelSslOo1XO4YJDp+711Ak= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=XYuSc5IC; arc=none smtp.client-ip=209.85.160.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="XYuSc5IC" Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-51c08df8513so11890321cf.3 for ; Thu, 09 Jul 2026 08:18:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1783610327; x=1784215127; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=D66HPeIJnm5ZDnK+VorUOpyiniaZPeUCt2fPIKMnyb4=; b=XYuSc5IC+EVJbDWikpVPC9cDKrnWwVwEAM4vxRerghx9T5cLKor0lZn/3xvEy8MYvH P4G8QPzYbfEZ/SuD19iQ/Y1IHWEN8FQYvrl4gGGNvM85yYx5CoTWRnrwozvd8buW/yZu rTLr0Kl5kFm/eeBRVjl2lZuNMDx5WC8PeGDIx78E6vBCLlaGrNT+PUtAJ/u8INBmJnMf RbCmKrzJydlT8MQRk1duN94/X88hvDTJtAhpiVN/Uddledvv9UkLMBn9POBFDX+NJflU wUwaXNQ4tD3o84h7GQtBbwvEsPtUxnWPlr1FHKAANE+13sbK/9le7ZhU64POCONVaFwl Syjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783610327; x=1784215127; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=D66HPeIJnm5ZDnK+VorUOpyiniaZPeUCt2fPIKMnyb4=; b=UoG1OoRfhquwyCsECsa79dT+tHPN6QqhEIsgf/fWzUkgEMKod7ACXqIKIxqNXt24Rq R7ajRCuxe0FIhEeNceM4zNvv791x6HnaPsyggDWKQSe39F7NxM6HuG5tTw1Ggt6pdeNJ fn2m7DBjUIRE/BdBlEIDcT7Lcky6UgyMv1wagoMg63A/nY1Bw8bBGErRAs8bceKCx4pd fFn1BNlQknkhZuuhHQRp671TbsjCakZODYqO62PY6QtyTAbjoB5EJBz3mrHm14mHNj0z fzoDVKRj5DPf/kMMmExUYjuotvBCHuEjU9RaIaxpB9nO6W2t+qOw+CFg8VIlw7NDkr8g c3aw== X-Forwarded-Encrypted: i=1; AHgh+Rpk/e5G7kaoZ4Uh1AkJZ/K38zNFcW+3mZfKm/KK3P8/vdXfpAM5ZQgAxb56a4u5Hem2oyZ1rbf0vUfoA5SVCYPC93w=@vger.kernel.org X-Gm-Message-State: AOJu0YyTq339hFX1dXtjmnVTA1xc2MZVRxqK4CoHaj0yTwV9W/CPtMi0 tqpwC18OX4GQQCjhkwoJx0Mohjjo06prIX5caJ8PrlY0pT53Sq7hIcch9Y8zryajYkY= X-Gm-Gg: AfdE7cmjGE7l5sYziNurDvghAGGxUeZveXqdmBdWrZj/RMk6lyDg5Yo62/8S8rwNUnq bE/uE5HQ8W32LTgYjlhy+GSsquC5x5jUEQAAgHip7zPlCDXBJVNJhwEFse/fi+3kAh1mivPdflR aGohm4fq9YL7Le1d7Ti/4LPvPvmJEeoTr7nJ2DlIMg3o8HvgusWOekqNJB5iZKG1ZSRC+4kAuG/ FglE4HJX/Qo3O6hY2PW29gRGV6whQPTTFhT+HPV5GGxacNfbRlc1uDz7wJQJS3qiGlKYTUPxvjZ rrCeNBg+4zyEGMP8VLQ5DjWjIlPsVmFWF8ebo/nFEqfiGIU8fWIZFSj5lUfMBQu/Rolr6Cruvyf 3k3d+OpvWlntkCBZfuo5YWc+clM0OxTeVNPoTI/KWYY7s23KYty/ldOEypP6ZHAtSsi7GOdMQd7 Oif1E0tpT5Prf4HkdE+Rl7gKOXEH3xZJlamAisvCnhlRtFXRvpbfudXlm67cG/VRLQZNdtCyGK4 LL/sFs= X-Received: by 2002:ac8:5cd4:0:b0:51c:1c2c:a8c9 with SMTP id d75a77b69052e-51c8b3e2e32mr79753441cf.43.1783610327278; Thu, 09 Jul 2026 08:18:47 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-60-52.washdc.fios.verizon.net. [173.79.60.52]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51c41db4fb5sm158006781cf.25.2026.07.09.08.18.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 08:18:45 -0700 (PDT) Date: Thu, 9 Jul 2026 11:18:40 -0400 From: Gregory Price To: Lorenzo Stoakes Cc: Andrew Morton , Russell King , Dinh Nguyen , Simon Schuster , "James E . J . Bottomley" , Helge Deller , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Ian Abbott , H Hartley Sweeten , Lucas Stach , David Airlie , Simona Vetter , Patrik Jakobsson , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Tomi Valkeinen , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Christian Koenig , Huang Rui , Ankit Agrawal , Alex Williamson , Alexander Viro , Christian Brauner , Dan Williams , Muchun Song , Oscar Salvador , David Hildenbrand , Suren Baghdasaryan , "Liam R . Howlett" , Matthew Wilcox , Marek Szyprowski , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Masami Hiramatsu , Oleg Nesterov , Steven Rostedt , SeongJae Park , Miaohe Lin , Hugh Dickins , Mike Rapoport , Kees Cook , Paolo Bonzini , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-parisc@vger.kernel.org, linux-sgx@vger.kernel.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-tegra@vger.kernel.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, linux-mm@kvack.org, iommu@lists.linux.dev, linux-perf-users@vger.kernel.org, linux-trace-kernel@vger.kernel.org, kasan-dev@googlegroups.com, damon@lists.linux.dev, Pedro Falcato , Rik van Riel , Harry Yoo , Jann Horn Subject: Re: [PATCH 13/30] mm/vma: refactor vmg_adjust_set_range() for clarity Message-ID: References: Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jun 29, 2026 at 01:23:24PM +0100, Lorenzo Stoakes wrote: > Add comments with ASCII diagrams to describe what we're doing, avoid > dubious use of PHYS_PFN(), and use vma_start_pgoff(). > > The most complicated scenario represented here is vmg->__adjust_next_start > - when this is set, vmg->[start, end] actually indicate the range to be > retained, so take special care to describe this accurately. > > No functional change intended. > > Signed-off-by: Lorenzo Stoakes Reviewed-by: Gregory Price > + /* > + * vmg->start vmg->end > + * | | > + * v merge v > + * <-------------> > + * delta > + * <------> > + * |------|----------------| > + * | prev | middle | > + * |------|----------------| > + * ^ > + * | > + * middle->vm_start > + */ Even with these diagrams, it's a bit difficult to understand what the actual intent/result of this chunk is (but that may be a limitation of me not spending enough time reading the surrounding code, not a comment of your work here). ~Gregory > + /* > + * Originally: > + * > + * vmg->start vmg->end > + * | | > + * v merge v > + * <------------> > + * . . > + * merge_existing_range() updates to: > + * . . > + * vmg->start vmg->end . > + * | | . > + * v retain v . > + * <----------> . > + * delta . > + * <-----> . > + * |----------------|------| > + * | middle | next | > + * |----------------|------| > + * ^ > + * | > + * next->vm_start > + */