From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 504D145BD5F for ; Tue, 30 Jun 2026 15:46:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782834415; cv=none; b=cjZc08Gecfh/M3ANduPoBz3T//Cd5sbi0cWMoEReL0LPXrJchyIdFozk7q0txtBmxzyo5BbQ/pVRe3FhD/HCyoczrviYJ0z6qsyAM1P+zLcHfYdgaExTz62iQ5ZmRamBa1nZRyjD2ad7pHwarD4kpgAp5Qr0TkhCYf3REs7ztxE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782834415; c=relaxed/simple; bh=dDmXL5XwXaYV+8+puY+mAXsJDpis0aF3tebQ04m+2HU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=f/Q9iOzO8tccuHYYy+KSPPXRRYoyHFDMwFjOXVAXe1Ujxo6Q31/m9Phyzp8U37lcsbbTGDrvjj1FrHor9JmKpcJTtxZrZC7kCcBqt6MHo2YQtpa0ikJJnSQROzl0moB8jckHDcXpe/BubBaMRNzcPqQHPtg7gAmFmTaM8N0WU28= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=vDUgBP8D; arc=none smtp.client-ip=209.85.222.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="vDUgBP8D" Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-92e663c828dso66768785a.0 for ; Tue, 30 Jun 2026 08:46:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1782834412; x=1783439212; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=z3V1BQpPjw58FUuLj010lwChkcBGTpKii5KT4CVPULY=; b=vDUgBP8DSx3vav8BjJqPGsXsvPB3didQ/5jzaChUmCxi3DxsAfKWPAk5Pj4i9ciiZK gnS6f1JSsry5+xa1W76dJ0jOwDjXQBqpJ9D2KltXzw0CVFROF6zoZkpLu2y8xe8eZWJz lF9FPyA9sA7EDl7L39UlzMn24nQCENSz5s3ctgtoSQICOcj6zdJWPMfzL75AaBLoH28y 6xm4rwSp3HbvuQu/pMTID5HZWQsaMBx93pxeF2wECsXSF61m5NEgiqCjZ58g9XZlcEm/ kQE8xXs1T5IOepP6GiwqZaBEXHdL2pxmwPzwFOAlbbQrLipTQZU50SDPh8Fk2Qku94VZ 8rfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782834412; x=1783439212; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z3V1BQpPjw58FUuLj010lwChkcBGTpKii5KT4CVPULY=; b=m3iuu0WmlaN47sbi0Tm82t51ApwRRf/jT1gXCD+mtVAq+aLHgoNN3askxeDDEptLlU WhLgvFImbv3eBK7mUvGul4jQhPUoJQ4WuGlLTfTgYhzTVNGS0CkQc+vpz/G+oMOrEWKy iuoeQaVbfe2aqR+vH6YCE4fxn/ri+IyLwWMFei2++lM/VVw/1EMbOqXtLqDMEoeH0gkt 5otif6F6zbObvQcZUiZ386ylovGCmCyNe8IGSGkhd6YYFqx/3wD3meKe5trq1rANrErq c1GK6GYVNT0ocY0vnPmW/DxeLpShbolimZj7UQ6x8kmph927Fbc4pwh5YDE4bl/CUnQE o2nw== X-Forwarded-Encrypted: i=1; AFNElJ+eP3zDttUy0XUYz6PGA2Q/A8TSctG+Yn4DIYNeugAgIvLGM1FxBAixEB3+SVqAD9Rq9N1kZOpSEUPraegeUMREZPQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3BGWoW7lZSSTCn9Zl/5ypsEGTjGaxU6z1aXMHoOZfgRUrQ3SI Jy/oi8bhf5iAwr02Z15l/wwkw1tFFFSH/VzusY71MmKfs/NvMeb6nKG+Jh+gqBBMiGw= X-Gm-Gg: AfdE7cm09+rGzm2GU78mXMa3vVes5ZU36fM9PkTrGY8YLycifP+vmBHsrPqDczqOgzs nNbm7Niznuhvto8ZPvOBgKlpScZt6Zb9N4h2UegOnu5YSWOkEmo/O/94iYnJPDfsa40r8+2n2Xx YgxjTr/lCIbVpzIlLV9s+GLlcdUpp9RNZf6ryHDzjvSN4kNzF0Zy4MjTEBVXoeMnlk5wvxglGhQ 29CSs4XHTG6+zL6lyJh2yZBSwcIR8X1bcUNLT0q5QdAONmJ2PStAkzgCccHZtlEtGrfCbB7h74A Vy9gpHfNvBIY3MyWa+nv7Br+K7qk5/xxxIoCWkwUoXlXVvM2NZwvJnMm0F9LRp2zNXXuNFSuj0Y mt+F6oakpxTZSc5/makJAkpL3geabKEb+wE6Sghh9qhDdeVX/R0DKO1Baz6Uw781dOiovQ1Grue bNkFvd0RyWoAL/rgzhn72HwzQ1KCntKOkC4XHVEqv/VOuZZTMAuWtChKWP1RL1/AGWJAWL X-Received: by 2002:a05:620a:2913:b0:915:a47c:f721 with SMTP id af79cd13be357-92e6974d636mr316697685a.21.1782834412151; Tue, 30 Jun 2026 08:46:52 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-60-52.washdc.fios.verizon.net. [173.79.60.52]) by smtp.gmail.com with ESMTPSA id af79cd13be357-92e6233a5acsm267797785a.35.2026.06.30.08.46.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2026 08:46:51 -0700 (PDT) Date: Tue, 30 Jun 2026 11:46:46 -0400 From: Gregory Price To: Lorenzo Stoakes Cc: Andrew Morton , Russell King , Dinh Nguyen , Simon Schuster , "James E . J . Bottomley" , Helge Deller , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Ian Abbott , H Hartley Sweeten , Lucas Stach , David Airlie , Simona Vetter , Patrik Jakobsson , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Tomi Valkeinen , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Christian Koenig , Huang Rui , Ankit Agrawal , Alex Williamson , Alexander Viro , Christian Brauner , Dan Williams , Muchun Song , Oscar Salvador , David Hildenbrand , Suren Baghdasaryan , "Liam R . Howlett" , Matthew Wilcox , Marek Szyprowski , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Masami Hiramatsu , Oleg Nesterov , Steven Rostedt , SeongJae Park , Miaohe Lin , Hugh Dickins , Mike Rapoport , Kees Cook , Paolo Bonzini , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-parisc@vger.kernel.org, linux-sgx@vger.kernel.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-tegra@vger.kernel.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, linux-mm@kvack.org, iommu@lists.linux.dev, linux-perf-users@vger.kernel.org, linux-trace-kernel@vger.kernel.org, kasan-dev@googlegroups.com, damon@lists.linux.dev, Pedro Falcato , Rik van Riel , Harry Yoo , Jann Horn Subject: Re: [PATCH 09/30] mm/rmap: parameterise anon_vma_interval_tree_*() by anon_vma Message-ID: References: <1c1df7b905ef340cbf2effef769a4e770a8e0eb1.1782735110.git.ljs@kernel.org> Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1c1df7b905ef340cbf2effef769a4e770a8e0eb1.1782735110.git.ljs@kernel.org> On Mon, Jun 29, 2026 at 01:23:20PM +0100, Lorenzo Stoakes wrote: > Similar to what we did with mapping_interval_tree*(), let's declare > anon_vma_interval_tree*() in terms of anon_vma rather than rb_root_cached. > > In each case the rb tree referenced is &anon_vma->rb_root, so just pass > anon_vma and the functions can figure this out themselves. > > Additionally, rename 'node' to 'avc', 'index' to 'pgoff_start', and 'last' > to 'pgoff_last' to make clear what is being passed. > would it be possible to split the pure rename changes out from the changed function declarations? It's hard to pick out this as something that needs to be looked at as more than just a %s/x/y/ > +void anon_vma_interval_tree_insert(struct anon_vma_chain *avc, > + struct anon_vma *anon_vma) ... > - __anon_vma_interval_tree_insert(node, root); > + __anon_vma_interval_tree_insert(avc, &anon_vma->rb_root); an annoying request, sorry ~Gregory