From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48E8C4657E0 for ; Tue, 30 Jun 2026 15:55:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782834921; cv=none; b=HtvBxYBnsPdxLf7ngSU+/TkFe581t1lKDv8ENTOjDGP4zphBStSwxiGXDBuzSqxQaxOeBi75VbaA/W3vEb+vex3bSdMwY0BqPV7Jz6z0C/lCSNDjhuBQHMB0UgVyYrSgKUfz/pn3JuKoYc+sPLBVm9LpUdEvwdl/vtOULIIbxl0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782834921; c=relaxed/simple; bh=q/CdBZIJ6A6qBJyymYNRI6oVTAoCPywZ7vcualAVIBs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=T9PKZvwPuK9327aTMIugPYnbquhK4EsE6HqDs51Tr9t8LgOJ0YUTu7IhAPluph2RvaJDpL7vKhC7f+kYe/+7M1XaOj8sKN+KTRKMF9ps6LOz4gYMd7fyiAof2mHs9onE/3rzS/duE/IfH6fh3uJIRmtHe0UbbOKuvsdMnwv9XsY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=hAXgfuyB; arc=none smtp.client-ip=209.85.160.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="hAXgfuyB" Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-516d0db9372so37578051cf.2 for ; Tue, 30 Jun 2026 08:55:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1782834918; x=1783439718; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BHpENWZilS5aqo8aP9kraE35F/fs2tmonTK7cFttpS4=; b=hAXgfuyBmNSRLBE9y2YF+F07dfSGqHp1xa4sOxR62JYnFeKn0O8SVUpt0MG/md/bBA JctoHB5oCxWZ0Vqte8bR8RSDqbwrPbLPyAVhB0DByHbOdA2IOjZEXwL28LDk2LiqVjrv z7cG0BHGgqC45FdoWw1cu4SJuJyQa88fRtGXXXfw7jyqkOqfCXplQUZeMMFCZELfo79Z 1rk+m2RY+h+2uqsjj4YAZSp59JxW4a4ytdwsdrD3N7DKSKtyf+EXlgO8ty+/hiKhPyOz 5gPFlMDUP1DBAOlIJqYE17f25yvB/zUT9IPprAkfMavu6WBQtA17ghH9sjittg5ZdSha jlVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782834918; x=1783439718; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BHpENWZilS5aqo8aP9kraE35F/fs2tmonTK7cFttpS4=; b=bwqV+gSZzx3Z8R5z7GdF/tJNs1HV0kq0e9NaKzJQSYwIG2/oWekBwGDLugLWYm1Niy JVgYUnSfNuh+bFXqyA/9+YfjcQ5eqmhoSOKSoaXReN6il8bgDdIlw7mTyHTFZP11jwz7 L7kDKVCTYOkDmm6IxCZojo8fovfEcQZ79J8D233Nwq1HqXyz06g2pB5iBfOctj0mQSi4 sRt68+18WtTFQOxzNEDl3yQyGbTpALKrlTggLHDj3zORO5dAaw39QknRDxSWX/gCch1A yC6HVQeQQQKalHeuaUh1DR8i4rv5HsLsFCTbWmJr+1ui610rh0uBKn6ktfF+xk+7kvvW yJHg== X-Forwarded-Encrypted: i=1; AFNElJ8Z7o/a4SxFw41LGXawDKXSbCLmv+HCma6QlVxdX2KDzL57s4wQdDQxoSloERrQIlSS3Kb62LNhYZQCSgMabxTyeyk=@vger.kernel.org X-Gm-Message-State: AOJu0YyOteQaTBFSfx+gWBWajTwMJcN+iNqL05rkhAhBQl8qLHR4Ru2k DPY02FjlHtUNuF4cx9uHXb5zd5aOolOZNWvUYA+z8IfU/eZnzCZbuyC6w5zubZ9Dxzc= X-Gm-Gg: AfdE7cmZ9Nvdj/vtKYV7hL73Gp9tiJw8pQ12sII+62kcHK4fvUpubLl9Ezzxz38ijLr ucT5je9lnJwNsj8lL5R8rRnR3+bAK4lk+FSfnoqFMTEMSUdgEMw6nTXR6u6fzYtYs5jZs3NzKGT u2t2QGZDqWs7QpR0g+YngL4t7o6YdiitpniA0f0XG5jXmg022GpW8gEhT3+8IyY1W324mMxbFc3 xhHSBclAe8wB1s3VNX9sgRXLrABxPVRCrJ0aYlBaFUUN7k0Gcuw1wXD/btCjNIigXd31g5RN2Q5 9nGvWFZSA2qTsxxUFf/fHNyLPUOLcx04zi5jBSipXSKWWrhPgHEYJ7qK5OjTJ3asVaFni9rHqjn EsyMwGpJo8dzvysnwV+O1oDKnwLZJMqQcwjwT+vQM01OAwytj7Zh+jDX3q0K9S50Ff+4xSQrhp3 feDHWGs1jQAALBEcEuctj6cBT86P1BLfsvdzN3BHCjn70Jwtb32WWKeSiE3JL/UJJ8+KS8 X-Received: by 2002:a05:622a:586:b0:51a:8c97:fb94 with SMTP id d75a77b69052e-51c10911601mr53620781cf.61.1782834918282; Tue, 30 Jun 2026 08:55:18 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-60-52.washdc.fios.verizon.net. [173.79.60.52]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51c1080d149sm23102481cf.1.2026.06.30.08.55.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2026 08:55:17 -0700 (PDT) Date: Tue, 30 Jun 2026 11:55:12 -0400 From: Gregory Price To: Lorenzo Stoakes Cc: Andrew Morton , Russell King , Dinh Nguyen , Simon Schuster , "James E . J . Bottomley" , Helge Deller , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Ian Abbott , H Hartley Sweeten , Lucas Stach , David Airlie , Simona Vetter , Patrik Jakobsson , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Tomi Valkeinen , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Christian Koenig , Huang Rui , Ankit Agrawal , Alex Williamson , Alexander Viro , Christian Brauner , Dan Williams , Muchun Song , Oscar Salvador , David Hildenbrand , Suren Baghdasaryan , "Liam R . Howlett" , Matthew Wilcox , Marek Szyprowski , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Masami Hiramatsu , Oleg Nesterov , Steven Rostedt , SeongJae Park , Miaohe Lin , Hugh Dickins , Mike Rapoport , Kees Cook , Paolo Bonzini , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-parisc@vger.kernel.org, linux-sgx@vger.kernel.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-tegra@vger.kernel.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, linux-mm@kvack.org, iommu@lists.linux.dev, linux-perf-users@vger.kernel.org, linux-trace-kernel@vger.kernel.org, kasan-dev@googlegroups.com, damon@lists.linux.dev, Pedro Falcato , Rik van Riel , Harry Yoo , Jann Horn Subject: Re: [PATCH 09/30] mm/rmap: parameterise anon_vma_interval_tree_*() by anon_vma Message-ID: References: <1c1df7b905ef340cbf2effef769a4e770a8e0eb1.1782735110.git.ljs@kernel.org> Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jun 30, 2026 at 04:49:45PM +0100, Lorenzo Stoakes wrote: > On Tue, Jun 30, 2026 at 11:46:46AM -0400, Gregory Price wrote: > > On Mon, Jun 29, 2026 at 01:23:20PM +0100, Lorenzo Stoakes wrote: > > > Similar to what we did with mapping_interval_tree*(), let's declare > > > anon_vma_interval_tree*() in terms of anon_vma rather than rb_root_cached. > > > > > > In each case the rb tree referenced is &anon_vma->rb_root, so just pass > > > anon_vma and the functions can figure this out themselves. > > > > > > Additionally, rename 'node' to 'avc', 'index' to 'pgoff_start', and 'last' > > > to 'pgoff_last' to make clear what is being passed. > > > > > > > would it be possible to split the pure rename changes out from the > > changed function declarations? It's hard to pick out this as something > > that needs to be looked at as more than just a %s/x/y/ > > Hmmm do I have to? :P I mean, no :] > I mean sure I can on a respin potentially, but it is a > pretty trivial change? Just mechnically as above. > And yeah certainly not worth a respin. Just learning some of the friction points of reviewing as I spend a little more time doing it every day. ~Gregory