From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A012D416D18 for ; Thu, 9 Jul 2026 15:57:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783612640; cv=none; b=I9ihzTMAxZx2XmkRWmLIgavG04y5pLDiQlckLR9Z8oF3cxploiC1LZMidX1Vr0zEyd3weXR7r4eugTeRslAqAYofqFqd6r3IGOV35RA5AFqW50LMQHi4vVTf1vOUyzCYDhG9l1ifXAjI29XjFXbfmX3luXHjNToZTpQYsJCnMIE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783612640; c=relaxed/simple; bh=zOqJj5IGDkUHkuE0A0VjkQNttgCPQIdWlZYAcSbicnE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZBoTrE32ZzGvfdSyBWQBp6mDpep1U31XGISMJD1mBaGelfAZoH7kiYWwLz+qK3/DyQ99OZQW3FVfHcirmNiCZng0xCrv8J0dWX9Cqw7TvjGfHOtU8ysBlMu4dJTMSITp+HQbovnhh/hJKTExiq7t7F44CuxbTKpbN6RA4iAMOAM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=JaiPRMxW; arc=none smtp.client-ip=209.85.219.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="JaiPRMxW" Received: by mail-qv1-f46.google.com with SMTP id 6a1803df08f44-8eefd4a8057so1011976d6.0 for ; Thu, 09 Jul 2026 08:57:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1783612635; x=1784217435; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=T5BtG8ZZnILhla7gs7f63UlRSUpFIkMkPS04TXxov0k=; b=JaiPRMxWcQcvwomxKrNgkR+V+GW/eBHpnGZNau6MH5y450xJl98VMTJJHAF9jRsuXC Xt7mR7KeawTZPVnKboCCSGbsxow5a2PgFeiSY8/XWddVDWFrEWmFXtO5W/Dl0nrr5olU FHib07hylrfhwz/tO61AsseU9KRqyHxGgKPeBcjHWB/NVjmWrN59d0H3M1NQXERgA5Mw SBvOCnVFfjsbezQ1DAbcIXDOTZgXYgBqCjS4/QI1RF06UoQPY6hmEkM7zoDzdAY2dn+j Mu9hGDFmirDa4O7n5AJQfExMa5HZRVOJt/+stBKx4vf5W+gioGtJL2bg1Fid5qnDWQi0 ldYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783612635; x=1784217435; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=T5BtG8ZZnILhla7gs7f63UlRSUpFIkMkPS04TXxov0k=; b=PtwwQr2+jm1tbrcz8cXivwuGjUA9/Gu+g3ZigPz5JGB8dfkcx/mu3L+vPtlT2WdLOa hSUIJF6wXY3l4vCVczp5PD//Er0rEeLZ4CkgC1Op6TVpjRV/pF0zZhp7khhNltoQY3Ph Q/l9i99YKoVREpIhrfhQA1hQAGFwCeFKyGTY7lSshTPJY8+mY4YImkltxofLtjw7ZlS2 Ane2VZG7JAbK/I55EhyW+c5Z6stFfhKayTtFw6VPrq+gJZX5pia93m9FqHdqtJ4dFQ2z tHL/5IW+X5xN8uw14utCVjDQdANw8iXr5mQR1fKE3bvouzDVrtyxt8XqJcbEBPWF+txW avbA== X-Forwarded-Encrypted: i=1; AHgh+RpDg4e+JnKU6UoH6GQE7ycIZpMQjkIUPemNY06pCc+O3SJTx5RXVEvqXstljF1Q9SFjZWXDBGoM2f9M/y2YGBSPOPQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxefBP7nBl5tIBqiiwz9v8hOfaLIfg3JUvCBDjZoHKTcCbyC6CD gwjBrWNszHKw3EfA4R5gPonYHIALXVuejCWMCtvoWLtdJoE2HhTnqS16qA+APmZ2tR4= X-Gm-Gg: AfdE7ckCCYtTRus8HfIriKK8OkIMru+lTU2lGJLLjCgO6cqBVatCiM07WxEzbsCSfdX 9tRJHdTx9Jo19243YCmr+JnW0QwCdqpJBudvkmwABPHXjc+VGAxuVQyhaLKZC1dlVHRHF9klc+f jg+29uSRDyIg+bdF2Ynt9nKlb3QAf16SAZx/d9KtSMMufwr3SHZ9poxB6kbn0BoTqyDg0+O6GO9 CxzQesHuWodasXmvz5g4ZxrZFwzrghssMAEw8kpF3el10iOhYS+aXuTliyGs9KM9q3C8D34IHXr wtLH9PKeUmG1oC3hwCx6zvbfM2NyNeMMIQ8EQKtTHwqdMzq+PmQbQpnTJF1bneaLnDQX3eCttlP s7TjcKX0FV3e7aUbfKK1/2C9rdCgVZAeK+bZki0DFS8VsCm8YqHMFitpqC79B8JGXzymiKb7f+0 BddQozcJtNNT2bxAvECeZhzKLaamhSWqSDQiKiQezpeE83Z5n7dPJoQbh23j0CApKcDclUIz/87 uuIQzk= X-Received: by 2002:a05:6214:2aa6:b0:8f3:e0ce:6119 with SMTP id 6a1803df08f44-8fec0ead52amr91789316d6.21.1783612635560; Thu, 09 Jul 2026 08:57:15 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-60-52.washdc.fios.verizon.net. [173.79.60.52]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8ffd86d43e2sm20317526d6.43.2026.07.09.08.57.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 08:57:15 -0700 (PDT) Date: Thu, 9 Jul 2026 11:57:09 -0400 From: Gregory Price To: Lorenzo Stoakes Cc: Andrew Morton , Russell King , Dinh Nguyen , Simon Schuster , "James E . J . Bottomley" , Helge Deller , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Ian Abbott , H Hartley Sweeten , Lucas Stach , David Airlie , Simona Vetter , Patrik Jakobsson , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Tomi Valkeinen , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Christian Koenig , Huang Rui , Ankit Agrawal , Alex Williamson , Alexander Viro , Christian Brauner , Dan Williams , Muchun Song , Oscar Salvador , David Hildenbrand , Suren Baghdasaryan , "Liam R . Howlett" , Matthew Wilcox , Marek Szyprowski , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Masami Hiramatsu , Oleg Nesterov , Steven Rostedt , SeongJae Park , Miaohe Lin , Hugh Dickins , Mike Rapoport , Kees Cook , Paolo Bonzini , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-parisc@vger.kernel.org, linux-sgx@vger.kernel.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-tegra@vger.kernel.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, linux-mm@kvack.org, iommu@lists.linux.dev, linux-perf-users@vger.kernel.org, linux-trace-kernel@vger.kernel.org, kasan-dev@googlegroups.com, damon@lists.linux.dev, Pedro Falcato , Rik van Riel , Harry Yoo , Jann Horn Subject: Re: [PATCH 19/30] mm: use linear_page_[index, delta]() consistently Message-ID: References: Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Jul 09, 2026 at 11:55:54AM -0400, Gregory Price wrote: > > @@ -2462,7 +2463,7 @@ static int comedi_vm_access(struct vm_area_struct *vma, unsigned long addr, > > { > > struct comedi_buf_map *bm = vma->vm_private_data; > > unsigned long offset = > > - addr - vma->vm_start + (vma->vm_pgoff << PAGE_SHIFT); > > + addr - vma->vm_start + (vma_start_pgoff(vma) << PAGE_SHIFT); > > > > Obviously correct, but was this intended for a different patch? > > ~Gregory bleh already caught, sorry for the noise :]