From: Oleg Nesterov <oleg@redhat.com>
To: Christian Brauner <brauner@kernel.org>
Cc: Bradley Morgan <include@grrlz.net>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Marco Elver <elver@google.com>,
Aleksandr Nogikh <nogikh@google.com>,
Thomas Gleixner <tglx@kernel.org>,
Adrian Huang <adrianhuang0701@gmail.com>,
Kexin Sun <kexinsun@smail.nju.edu.cn>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] signal: make send_signal_locked() take const siginfo
Date: Mon, 6 Jul 2026 15:33:38 +0200 [thread overview]
Message-ID: <akuusnRXP_tyuiel@redhat.com> (raw)
In-Reply-To: <20260706-karpfen-beruhen-ausschalten-9f2b0a55b8de@brauner>
Just in case, I can't read the code until Wednesday, but...
On 07/06, Christian Brauner wrote:
>
> > send_signal_locked() should not change the caller's siginfo. Make that
> > part of the type and keep the local rewrite on its copy.
> >
> > Suggested-by: Oleg Nesterov <oleg@redhat.com>
> > Signed-off-by: Bradley Morgan <include@grrlz.net>
>
> Reviewed-by: Christian Brauner (Amutable) <brauner@kernel.org>
Agreed, but IIRC this change should be rebased on top of -mm tree (I sent
the patch which changes send_signal_locked(), and thanks for your review btw!)
And, again iirc, with that patch "make siginfo const" become really trivial,
we only need to add "const" to every "kernel_siginfo *info" in the
send_signal_locked()'s callchain.
Oleg.
next prev parent reply other threads:[~2026-07-06 13:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260622164029.11474-1-include@grrlz.net>
2026-06-22 20:25 ` [PATCH v2 1/2] signal: avoid shared siginfo namespace rewrites Bradley Morgan
2026-06-23 11:37 ` Oleg Nesterov
2026-06-24 15:29 ` Eric W. Biederman
2026-06-24 15:52 ` Oleg Nesterov
2026-06-24 15:54 ` Bradley Morgan
2026-06-24 16:32 ` Oleg Nesterov
2026-06-28 19:11 ` Andrew Morton
2026-07-06 12:39 ` Christian Brauner
2026-06-22 20:25 ` [PATCH v2 2/2] signal: make send_signal_locked() take const siginfo Bradley Morgan
2026-06-23 10:39 ` Oleg Nesterov
2026-06-23 14:49 ` Bradley Morgan
2026-07-06 12:39 ` Christian Brauner
2026-07-06 13:33 ` Oleg Nesterov [this message]
2026-07-06 13:38 ` Bradley Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akuusnRXP_tyuiel@redhat.com \
--to=oleg@redhat.com \
--cc=adrianhuang0701@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=elver@google.com \
--cc=include@grrlz.net \
--cc=kexinsun@smail.nju.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=nogikh@google.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox