From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2F653803D0 for ; Fri, 10 Jul 2026 18:59:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783709965; cv=none; b=TPScCuM9sc/L9FRuE/mEJJw0MfsjRE87zyG5vSnWMuvV2Tc55Nexlu3xGLBVTNelBuQh9I17lvG3bS8ZlkgA84k6yJX8DCSXqVaIWjwnEvMi9H6jr3YL+Ylj/td9QavhHviTQbMj/vpd340/vwUisclgRCJAcBdQLKh27Jt2Rjc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783709965; c=relaxed/simple; bh=L1PtE+Fge/ce+F2DBwYJ3SZFAaV5kA0gEoEabNlaIYA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EorUh2eb2h+9+smWfZUx+13NxoeNbbIHJRpCSt2ehCEa0YQszNbhRL3JOvgbzEWi1OA53PCMu9qeYYO1j05md3CgHptXJBf8OrV/vAY+Vk8gVTOXgsgmhPwbZaOm6Y/iZy5B6Wk4At0YaWbM5J3XmgZ+s8wM5l2nBHdZwTaIhOQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=PB7oBmn8; arc=none smtp.client-ip=209.85.160.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="PB7oBmn8" Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-51c0c45c580so8640891cf.0 for ; Fri, 10 Jul 2026 11:59:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1783709962; x=1784314762; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=74B4rm3uR5k1lRSPUh5wFwkcdLxEy4GniWsMlOdHPw0=; b=PB7oBmn8rFdXuF6beB/vgXJAJUCb5Wiflj2c0r3WO5cmiDQzPm/ethlo/sbnW7mgCr 3o7ztziuDHX30UmZN++fI8CpkIsthHTQQ2bJAiL6sImi87C+qTC1GAn82Iq9uazMFTfO QfEwUcCldmMKjGyZy+6yP/N7aAyAldDa65gvulGMOoGz0V9ZSHnFIOqvjnsJ5ZU6RTdp 1jm7WtF/6Tl2z0LlUvF9vI+tCPYhwOkph1I/MfdX11JPSe/Y/iUI9R07HVt50p5i77sB tO8wvSNPxWUl5eYxL6kmLj/79pyhsOdO8Nc162WbqFC/q/La2DldEC4WQ3/tPX0i/Bl3 +ONw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783709962; x=1784314762; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=74B4rm3uR5k1lRSPUh5wFwkcdLxEy4GniWsMlOdHPw0=; b=qpbWy/C44bUipnpOvYgeoEP+ZYJ2X6cWawivzO/2T1F/nehtcDlUrcEgvvKMTFcFkZ Gn7sFQD6Yix68kRdiQQ2+OGbpDue4bmh+GRdez76nLt8U8WSUpmKiF0QUDNaQ9q2Wbbt Re2CDhpZzk28+/YxCa/Sxwa7N5AMyUZi77F1UfJdlKQJh7v/2INqQY/V0bio3PIiDPDE PO23yIT1Fnou1ZLwP4gJcdtqvG5RlGCl7CE/6qPk3uqL8wG8RISZN5ILTh9bcrAx6QdT R+qrHy4Kh9aVvtrBVxkuCUJjArxY4MZrtFAKXXOKCHLrx+mi3x2NgKn06hIsWG77gowb kKbQ== X-Forwarded-Encrypted: i=1; AHgh+Rr0HMo5LBbYQ05oUjfCSIB2uRta6CnzQJNiJ22lSujRbHSVwJkHmQhyb+A6ZX6jFPRjEYkMOcC6SSnNEVU97uWAuzo=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/K9XbXR0p4JLysSYs02V46GR2c0QpgMzcH8NUyNchxrOzhsVN E5DWfg/5Q09HnmiyWXRNsm+QA53bA0qTOiqGLBN8Bc1KZAatDqoqPmtSfgnRsCtBbRY= X-Gm-Gg: AfdE7cml8CmoEQomXKe9LAos1CWPCVlSB9SUWQhSAGPwtBgsGZb8GD8xZV8ga+HueIt d1/tbkKfjczB+l3ffA4xdoGWi1IDIACva8KYYnDX/d4oX9kUAemhvk0VeybT8wVAjzEsoju4afL Q+4JMaTL3Sn1N/RCLUbUE3C+SJiKxj1nNvafXnVV4rxrKqBTHtQ4NsR/Wv1mJSGKuVoEuE49zg7 pZZcqphPlwq1OLph9okhWwA7rB73sL+1Gt8Lj49X9t8dI5kYeXuN/9CgpJbeztPvfSR11kCHYHP lH+AxQZ5JerZ1rb8NsVsD/Pqr2SzdHoATY0FZmXOuu5sVm4851yBt7ujrsf8Ww8/0gpS0A6zFWj 9VAtjhzpudgaBKM582pIddSr2azaiPNr8YuDhXvBYoM/Q/t7NdJ3Lr/yrOlST2rWGJEI/hQbR0m Srbz2ymLK/e0PVOOxLcC7l281jkrrZ9jbR7zS71lwr7J/t6xywA6m5aUOT+wdtRTQk0LrW X-Received: by 2002:a05:622a:1b17:b0:51c:2101:ef with SMTP id d75a77b69052e-51cbf156814mr1787851cf.19.1783709961653; Fri, 10 Jul 2026 11:59:21 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-60-52.washdc.fios.verizon.net. [173.79.60.52]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51cb884e0cfsm12321961cf.29.2026.07.10.11.59.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 11:59:21 -0700 (PDT) Date: Fri, 10 Jul 2026 14:59:16 -0400 From: Gregory Price To: Lorenzo Stoakes Cc: Andrew Morton , Russell King , Dinh Nguyen , Simon Schuster , "James E . J . Bottomley" , Helge Deller , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Ian Abbott , H Hartley Sweeten , Lucas Stach , David Airlie , Simona Vetter , Patrik Jakobsson , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Tomi Valkeinen , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Christian Koenig , Huang Rui , Ankit Agrawal , Alex Williamson , Alexander Viro , Christian Brauner , Dan Williams , Muchun Song , Oscar Salvador , David Hildenbrand , Suren Baghdasaryan , "Liam R . Howlett" , Matthew Wilcox , Marek Szyprowski , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Masami Hiramatsu , Oleg Nesterov , Steven Rostedt , SeongJae Park , Miaohe Lin , Hugh Dickins , Mike Rapoport , Kees Cook , Paolo Bonzini , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-parisc@vger.kernel.org, linux-sgx@vger.kernel.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-tegra@vger.kernel.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, linux-mm@kvack.org, iommu@lists.linux.dev, linux-perf-users@vger.kernel.org, linux-trace-kernel@vger.kernel.org, kasan-dev@googlegroups.com, damon@lists.linux.dev, Pedro Falcato , Rik van Riel , Harry Yoo , Jann Horn Subject: Re: [PATCH 24/30] mm/vma: update vma_shrink() to not pass unnecessary pgoff parameter Message-ID: References: <6dd744d57d778f94d2fef8fd623d7c4ed8010d93.1782735110.git.ljs@kernel.org> Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6dd744d57d778f94d2fef8fd623d7c4ed8010d93.1782735110.git.ljs@kernel.org> On Mon, Jun 29, 2026 at 01:23:35PM +0100, Lorenzo Stoakes wrote: > vma_shrink() does not need to adjust vma->vm_pgoff, we were passing this > parameter solely to satisfy vma_set_range()'s requirement for pgoff being > specified. > > Since vma_set_range() is now isolated to vma.c, we can simply introduce > __vma_set_range() which sets only vma->vm_[start, end], and invoke this > instead, removing pgoff from vma_shrink() altogether. > > No functional change intended. > > Signed-off-by: Lorenzo Stoakes Reviewed-by: Gregory Price