From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 629D83845CB; Sat, 5 Sep 2026 07:55:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.21 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788594925; cv=none; b=t6qAsG3PfZg2TCkaBI37A06sQR/DpK/Lr9vT+z7u1qXX7JOjUar/mbrdoZ3mcUmnbux3Nm2iAtrHagfs73MLvQ2UFOJQ2IpcukHa8TKG7UTJP55ntRY22LpfpSzBJLNLFnFU3IbUDnVcOgwgKIU3jh5Zltsx0lHmeIlWTpG3Dyo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788594925; c=relaxed/simple; bh=nVoM4RkYZfBPC9WAJEVNQ4+CpJomELlbuzuYSgYBRRs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=k+3DGj4o97qqMp5oMC5xoIL6m4FteQhYlEI8N+tmQqafXpP3C8DDA+GEo864Hwq2ABWaoU2OgnRoQoICEsUnrTrF8i1b8n+LZ6O0HKqyWfwoQZ+zkfAiMiE8TqYrvOdaMHIwmMuP/M9m+8kuUkY9RdGsJtkc5sXwNpeSeMDgj7Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=HHyLHpAP; arc=none smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="HHyLHpAP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1788594924; x=1820130924; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=nVoM4RkYZfBPC9WAJEVNQ4+CpJomELlbuzuYSgYBRRs=; b=HHyLHpAPAm05JgjkhpwKwPO4HkO3E+OG4b4YyLjlAbje4L0BddcT6okT 3CLMvlcvCLDmBUcl2+buAkRGdugRhkFD7XBY7XZ/oQZ5cn5c5vqOmWZPz IaTWOu1SFf4JUnNdWtKewExdd0N3DGMgixdmsEwRRPaJmcsUYZBylS39U kXc8r19KReZcHBwSsl6XZYGLkANPRSC2v5rjPLY2J4DWQ43hPV9SHY6U5 p78ikW+JWsBkBJl9pBzJ+ysrq/Syrmd19BlFKzC7rXsMLwj/RM5EcefBI crX42Pyqua/BnCHqDaJUyeU2UtC95AjZSAoDfPgp41GH87RBY5FGceteL w==; X-CSE-ConnectionGUID: wYnvnd8KS6aQAQ0mHnjxUg== X-CSE-MsgGUID: CH1F+no4SOOpYIfX/0qNIA== X-IronPort-AV: E=McAfee;i="6800,10657,11896"; a="88933091" X-IronPort-AV: E=Sophos;i="6.25,263,1779174000"; d="scan'208";a="88933091" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2026 00:55:23 -0700 X-CSE-ConnectionGUID: EEhu5k1rQMWULfktoCCXzQ== X-CSE-MsgGUID: lwmOrv2pTjCcruQ2CcFOzw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,263,1779174000"; d="scan'208";a="267010278" Received: from fpallare-mobl4.ger.corp.intel.com (HELO localhost) ([10.245.245.105]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2026 00:55:14 -0700 Date: Sat, 5 Sep 2026 10:55:12 +0300 From: Andy Shevchenko To: Frank.Li@oss.nxp.com Cc: Jacky Huang , Shan-Chun Hung , Vinod Koul , Frank Li , Paul Cercueil , Eugeniy Paltsev , Binbin Zhou , Patrice Chotard , =?iso-8859-1?Q?Am=E9lie?= Delaunay , Maxime Coquelin , Alexandre Torgue , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Thierry Reding , Jonathan Hunter , Ludovic Desroches , Viresh Kumar , Keguang Zhang , Andreas =?iso-8859-1?Q?F=E4rber?= , Manivannan Sadhasivam , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Kelvin Cao , Logan Gunthorpe , Laxman Dewangan , Vignesh Raghavendra , linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-trace-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-actions@lists.infradead.org, linux-sunxi@lists.linux.dev, imx@lists.linux.dev, Frank Li Subject: Re: [PATCH v3 2/4] dmaengine: use dma_chan_name() helper to get per-channel device name Message-ID: References: <20260904-dma-chan_dev-rename-v3-0-685601b0b788@nxp.com> <20260904-dma-chan_dev-rename-v3-2-685601b0b788@nxp.com> Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260904-dma-chan_dev-rename-v3-2-685601b0b788@nxp.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Fri, Sep 04, 2026 at 05:49:44PM -0400, Frank.Li@oss.nxp.com wrote: > Use the existing dma_chan_name() helper to obtain the per-channel device > name instead of open-coding: dev_name(chan->dev->device) / > dev_name(chan2dev()) > > Simplify the code and improve consistency. > > No functional change intended. ... > @@ -507,7 +507,7 @@ static int idma64_alloc_chan_resources(struct dma_chan *chan) > struct idma64_chan *idma64c = to_idma64_chan(chan); > > /* Create a pool of consistent memory blocks for hardware descriptors */ > - idma64c->pool = dma_pool_create(dev_name(chan2dev(chan)), > + idma64c->pool = dma_pool_create(dma_chan_name(chan), > chan->device->dev, > sizeof(struct idma64_lli), 8, 0); For example here it may now be condensed to less LoC: idma64c->pool = dma_pool_create(dma_chan_name(chan), chan->device->dev, sizeof(struct idma64_lli), 8, 0); Consider that in case you will need a new version (no need to address it separately). -- With Best Regards, Andy Shevchenko