From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv2-f12.google.com (mail-qv2-f12.google.com [74.125.230.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 067B83C660C for ; Wed, 9 Sep 2026 22:14:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.230.140 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788992081; cv=none; b=MkD2ecTKPk5Rmp/eILuOF64tjpd0xMgMyi9ZRkXqEbi/5FjDhFS2FdwE3zPJxCM+0IBrlNz864YzVwq71xmh3uRzuv1soLilKA1f3Sbn1gxtpwmvc6tW9hbnZXyDT6nGn9tOFcBuW5Ay/DobywIrI3oTxMf4XO/LAu+/s1bcyDI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788992081; c=relaxed/simple; bh=aQvz0ZYLQXdqqzd85lD3v43R3LA7HgRcKMR5C2XkRss=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Hzf7J929/2YPDgWg7lB03r0YNwu1ar74bs1rykj17dv0yPU3CBuSYKyebBno0P7N5rzZvyBwwklz/5vmgpLEvpSowXg69Q4MwzfOeBHmo52TebqnNMpgsfZY0TPau0yqECqoi/WF4WhcpDtRFyhz0ll/odNcrZE6vybVTur+sUw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=fnpdwSN4; arc=none smtp.client-ip=74.125.230.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="fnpdwSN4" Received: by mail-qv2-f12.google.com with SMTP id 6a1803df08f44-90cdfc6db0aso9977286d6.1 for ; Wed, 09 Sep 2026 15:14:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1788992078; x=1789596878; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=C5NkJw6oWjdsiphJVaybRhCdoPAeWbsi0cRS0OiEPYM=; b=fnpdwSN41Bd+nnSwZXD6W0gZ8eetbtEli2koOI5k6o2p/h7yS80w3XqZmsAcB0S7tC rlBEAKgyCm2vYnBGj1pW6sW9JZNN1TUVAXB1nw2NHkMJew3X+9bbwGs+8lNnznKSSrlO I327dzeyexcEYxFLf4xRuBu25dekSSqijcF8IvX31Zn+fbBi0w71OaADpEgR8fFiVeao RG42i7/xclhYVIYtPmE6evMDntSEZN6eOF2DBDdLkeGS/1heYbdXs26/V4GbzDo9UgM0 eMxaYopC9+m5yXS87uifPq0UhH2vm6QtyBePAG0QqFe3/eA4t4jyjM06d+KiES0jsiGj iiMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788992078; x=1789596878; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=C5NkJw6oWjdsiphJVaybRhCdoPAeWbsi0cRS0OiEPYM=; b=aEhQRVpiVSHP6OlJcXWDd6QG2eWuC2fLrCLoRn4Gv10Xf02ViV0igAd7A2L+ZZcFdH 1GRuQQRgQL/4gLiGwDJ0J6SM2DE7r0yIUWFkaKSYf6YO6dToEsuW7vM7Ib+mvWt1D+KV GuRqKkD5xK4HKuPbZL4isUz/4oWvGnmAvXgWfTqyv48EmBVnCHzmuL4cumf4ujJRTR4I ZTtTVrZjaRocgVLPhJ1eaDI3CS9p7fJXF3It0hTyKHWnj1wYGfx91ahw/vyVSlr2yRpW xKkKFrsoY6aLyQOyqp+KgnI22SIT3h0I6I06z+1ivxAeRIk2+Kqhxv8Srbk2XKdt6TAM Ccow== X-Forwarded-Encrypted: i=1; AKwUvBzqbizuKHOzNpoG5rOuC0JGr2MDyd7G8kJFFgFKkjEIuAvGY2Vl4RgQVhlZtXDztBXrds582iYZHOSv2WTqFlZP+Ms=@vger.kernel.org X-Gm-Message-State: AFuF++kUOGl9H2oQvH6J1nsT5RgM9w8/OOm5iNUn1U+6Xt5KrfbNzcNW cxnGZ3QcSrtC0VuoBiW0Xu2DHE1SdD/WkWdVA1GfzZMS9BkOfLqaRJKKU7E+aFbW/z4= X-Gm-Gg: AYBFou0FPceiFjxxAZ6BxcgWTOnQk/N/Ojk0yT96jjJ2ooSOBBHTGX8dlbQwZgXBDq9 M7RVQ/FNg3r0Z29kinP2rijSR8/uxr5G9/FqwcvXzdzKfdvYJxGQ2/ZH4s6QgWdWQZZVD549p8g iMUClUjQwIAKGLtvKhfIBQzAoEw87uMG1dqevk0ysB2bCAok/X76CIOLNnlPOD/JXIoy0MFq6/U UGl17QfcOr/b4atRYX0a1m2zBcNI2zhxc72EhHhT/yMAp3b3jt7JftdUmVLY/QuJ9iabddyVvRj knwCKLvtfYc+SwFBE8RUrVOxxnvTRSWkAgBgzPMOaK/zZMByDnZGEgGLdCO3sPFhZbuXZUnIrIh y1TvCVzVmKtwDEH+wUsVrovJmHbuq/4ag+FfPtB3gb2lg5Ih2ZP5SX1rO7X1uD9x3pQHCtgxXby 8PGcWRjX1OmUhPj/c7Zp1rr+yoqgOPtIhggB73NjmwYltM8FR5hWaxoCd9HgjkQAE8qL7zHkQvC QUKUhUs0sGDpY3KNIn7X7ha0XwmR1mdUcCVU9x1UvLwdLjr1qTte9k= X-Received: by 2002:a05:6214:761:b0:8f2:fbb1:cec4 with SMTP id 6a1803df08f44-910d104c019mr49748076d6.19.1788992077664; Wed, 09 Sep 2026 15:14:37 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-60-52.washdc.fios.verizon.net. [173.79.60.52]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-910406475f5sm151951376d6.9.2026.09.09.15.14.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2026 15:14:36 -0700 (PDT) Date: Wed, 9 Sep 2026 18:14:33 -0400 From: Gregory Price To: Oleg Nesterov Cc: K Prateek Nayak , Ye Liu , Thomas Gleixner , Peter Zijlstra , "Rafael J. Wysocki" , Andrew Morton , Ingo Molnar , Will Deacon , Boqun Feng , "Paul E. McKenney" , Frederic Weisbecker , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Uladzislau Rezki , Juri Lelli , Vincent Guittot , Steven Rostedt , Masami Hiramatsu , Josh Poimboeuf , Ye Liu , Michal Hocko , mic@digikod.net, david@kernel.org, linmiaohe@huawei.com, nao.horiguchi@gmail.com, gnoack3000@gmail.com, ljs@kernel.org, sj@kernel.org, rientjes@google.com, shakeel.butt@linux.dev, xu.xin16@zte.com.cn, chengming.zhou@linux.dev, tony.luck@intel.com, reinette.chatre@intel.com, x86@kernel.org, paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com, pavel@kernel.org, lance.yang@linux.dev, pmladek@suse.com, longman@redhat.com, mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com, qiang.zhang@linux.dev, dietmar.eggemann@arm.com, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, mark.rutland@arm.com, Dave.Martin@arm.com, james.morse@arm.com, babu.moger@amd.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, rcu@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [PATCH v2 5/8] kernel: convert process/thread iterators to for_each_*_rculock Message-ID: References: <20260907081334.1152889-1-ye.liu@linux.dev> <20260907081334.1152889-6-ye.liu@linux.dev> Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Sep 08, 2026 at 08:35:16AM +0200, Oleg Nesterov wrote: > On 09/08, K Prateek Nayak wrote: > > > > On 9/8/2026 3:24 AM, Oleg Nesterov wrote: > > >> This might be my - admittedly shallow - understanding of scoped_guard, > > >> but does scoped guard handle goto correctly? > > > > > > Yes, it does, > > > > > >> and why it's generally discouraged to mix cleanup.h and goto. > > > > > > Hmm, why? I didn't know... > > > > Apparently older GCC would allow subtle bugs with cleanup + goto to slip > > by but clang has always caught those bugs and refused to compile so as > > long as clang builds are happy, things should be good. > > > > Here is an older explanation from Peter: > > https://lore.kernel.org/lkml/20260327154136.GL3739106@noisy.programming.kicks-ass.net/ > > Ah, but in this case the code is buggy, "goto unregister" jumps > into the scope of __free. > > Anyway, I agree that mixing cleanup and goto can make the code > confusing or buggy, but this particular case still looks fine > to me... > Seems jump-out is ok, thanks for the confirmation Peter. I do agree the general improvement is nice, but maybe worth considering taking cleanup.h all the way if we're going to use it - that's all. The improvement is clearly welcome. ~Gregory