From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 931BC40EBA9 for ; Mon, 12 Oct 2026 12:49:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791809351; cv=none; b=qV7EJOkBcTegCpdK710oxyYa11T5Kf1H2iq0/44gssDoMFG8Gn14w/ZsQF33UVoAmx5LJWlYABfiAFoE2yyvtLfWYjpFuq26nJCIMkURjyXaHcv8/T16EJQwtm993iH0kMbG/G0FUNtW7hQ0j7+VAktFYjDGzpQLqATT+3u8vKw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791809351; c=relaxed/simple; bh=14phVvYRrJPhd267XL2Fy1Y5N819k4Yyec3jG7Q2YLY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PPhC6l7+iiMGgmLqkC/RXjn8F2t3eP3RY0anQfqI95NffwCITTyZAUxuMWl+7wA8QESYWEkZcnhap4fRmRDh0FI/yButjkFzBUd4ERsuOOpOReWbg6+h0hSTS3nb/nME9jFfkRW4pcpI5dUUC6dv41TWOJmf8xNUH0UNhm0lENM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=Ra/N470Z; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="Ra/N470Z" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-48af27fe287so1588753f8f.0 for ; Mon, 12 Oct 2026 05:49:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1791809349; x=1792414149; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=aJj4Wm615H/imfpMwNI2qT79o5fgFKI50ixCq2u6D9Q=; b=Ra/N470Z1rsPNexi1MkPGilCztbpAqLRTW6jMpuEWn2YIib0mG1MiGaIyDZLnH/+3g hMm1y+CAYDcisPYApU+3yeRA0fM6aI56iIZgsun/ZLG4FEsBP1rlcS5xfSmI63tgncBK jobB9tZ6hGPmY/Yt3AMPy6WqFbU397+4GRtz8S+UskPjLIUThPWE2cleFWRO70ASbBSY s/QkZz1dxNGwo1hm8ZWq2gizqCmkd/iVz5jpt9KCN6Jkuvmx87Kc5Uj9ZD1Rd0eIsucM 5rpJDfH9QXlnw8QnI30qPobTJGBY+6OKlH2VOYhXvtoW/mhWmocaOTZut4onJ3T5DqcX BHog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791809349; x=1792414149; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=aJj4Wm615H/imfpMwNI2qT79o5fgFKI50ixCq2u6D9Q=; b=eiXVjwujteIwVrZxpq6SNauNHZo9juHU+QIOcgKlgTge64LdquuZSQl5vr8975s0Wf LH4eXLM1b5+/mHlWdTm8bMzZQSoszankcL7BC3ZsG3p2BR0BpOIxKGbYs0crlfcw1C5L fio/EWYyv7AWREmeY5G6yHX9DKv7ds7qxox05S4BDhBjEPJVSdtbg5rirjmxGiWacgmt r/GNwiN5e5UIF3tDVUB+Sr/Y+BzyQmx5per/ZhTlHfPt/Snx0k7bvcDgS2fUsFUyYTNg SAbypgqXuWE8Uict1B2D1Tw0SeiXrtz3V3SZHUzpF7VtRKkNyp2zz1BZi6I4L/zxvNHn s83A== X-Forwarded-Encrypted: i=1; AKwUvByiTR3cD3PXHvhO4xVA6VeLAHlBFUWznwp8nymccMZ5oTX6/0etbzDzB3sG7dMmHEFc5n+eLRKFy17GrIyfj3vea+4=@vger.kernel.org X-Gm-Message-State: AFq9FYIzxwgsStrQ/1L7Gmdiw7Lfm+U1EsAkLngTg6dFi9OrGMdZOjeD /qkvFMP4mrTURAKyEsD/YszE6AksO4+9dpy9kvXp8VpSsJ2hYBpsFFtQiT1v3e9mnXo= X-Gm-Gg: AYBFou0OZs8li6JYD2afuCjEmd3mwyXY3RN91Yq6BJY9couDalK4+1unrFkikn8MFF6 AHRMJ2tMh+Rqt/chEzLM0ifln7K/AoxLNSalRPuF6rQdOQNMK4/zutKXYs5d6flAbCdhYcP1uNw p33GFd26TyQV7SUVrNtu3Wf4HRM5cHyQT5j07ki/nX1AeRxEUCQma4UJqI54f371JHUxQITXswM yMckyMTG8DKDMOShJc//APsCqlWlFelYP5fkrxRU7ydzAaQ+y6nxY2S1UCvAqTwpxu4BnngV6HN u451Zy9X/lWbCoJ+FNLbdXrVqzy3XkhJ4mVphGdcnhgp7VHpNWAODYUD2Rg55aTSumsXO96QXS1 u4T7UDFVxKIdYSfhwUZWA9okWQSxmtBd0xCzpfAV3LZmIr0AwGU6OWuw3tqN7uGju3xUrOFRYTy 1vbAw7hRwg5LbHif9deYf5nDV2TFrSLQQmLYPjiS+C3hTvxbGwLhaXVArTfgab X-Received: by 2002:a5d:43c4:0:b0:48d:ba3b:af36 with SMTP id ffacd0b85a97d-48dbaae8e33mr13956577f8f.37.1791809348520; Mon, 12 Oct 2026 05:49:08 -0700 (PDT) Received: from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-48db97ce3aasm19818827f8f.21.2026.10.12.05.49.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2026 05:49:07 -0700 (PDT) Date: Mon, 12 Oct 2026 14:49:06 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Jingyuan Liang Cc: Jiri Kosina , Benjamin Tissoires , Jonathan Corbet , Mark Brown , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-input@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-trace-kernel@vger.kernel.org, devicetree@vger.kernel.org, hbarnor@chromium.org, tfiga@chromium.org, fqwqf@fqwqf.xyz, daleyo@gmail.com, Jarrett Schultz , Dmitry Antipov Subject: Re: [PATCH v5 08/11] HID: spi-hid: add device tree support for HID over SPI Message-ID: References: <20261009-send-upstream-v5-0-384af01da3ee@chromium.org> <20261009-send-upstream-v5-8-384af01da3ee@chromium.org> Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ey244vnbkokc4rpq" Content-Disposition: inline In-Reply-To: <20261009-send-upstream-v5-8-384af01da3ee@chromium.org> --ey244vnbkokc4rpq Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Subject: Re: [PATCH v5 08/11] HID: spi-hid: add device tree support for HID over SPI MIME-Version: 1.0 Hello, On Fri, Oct 09, 2026 at 10:25:33PM +0000, Jingyuan Liang wrote: > +#include > [...] > +#include Drop , the spi header already provides the needed *_device_id with less dependencies. > +static const struct of_device_id spi_hid_of_match[] = { > + { .compatible = "hid-over-spi", .data = &timing_data }, > + {} { } please > +}; > +MODULE_DEVICE_TABLE(of, spi_hid_of_match); > + > +static const struct spi_device_id spi_hid_of_id_table[] = { > + { "hid", 0 }, > + { "hid-over-spi", 0 }, > + { } > +}; Please use named initializers and drop the unused zeros. > +MODULE_DEVICE_TABLE(spi, spi_hid_of_id_table); > + > +static struct spi_driver spi_hid_of_driver = { > + .driver = { > + .name = "spi_hid_of", > + .owner = THIS_MODULE, > + .of_match_table = spi_hid_of_match, > + .probe_type = PROBE_PREFER_ASYNCHRONOUS, > + .dev_groups = spi_hid_groups, > + }, > + .probe = spi_hid_of_probe, > + .remove = spi_hid_core_remove, > + .id_table = spi_hid_of_id_table, Very inconsistent alignment of =, if you ask me, just use a single space before a =. > +}; Best regards Uwe --ey244vnbkokc4rpq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmrM1z8ACgkQj4D7WH0S /k5u4wf8DQCuk6roFME/n1pKDY6+qOflxre3Nf6NmaZ05olJWzf7xMLHiGj0xlvH rCXdQWSaJaWnBK8rKxyK28S+MmDDqDnW+WAK6FXQVv8Srv4/7Uiy7+5hoTWAw9CP Vxuzr9RagEgpRyi0DyMZlaoFh3bqtZmx/IDNDD22FCwEJcVhvEpBv4TVYHn9L/wj XXmPB4PiOuJszPGD+WIhrsdC1Zz17JoO0v9K42vVKKAkYir7a9ABA4fxMMjVxgqf ixRyg7HTQo8ggOzmpFjoj/atoZ3XOBVYSQ7RLbU8ZgRcEu4xgL4yKP96cUXwQ334 ebpZbkR6VGklGZOq1SeOk7zN55irKQ== =nzgN -----END PGP SIGNATURE----- --ey244vnbkokc4rpq--