Linux Trace Kernel
 help / color / mirror / Atom feed
From: Frederic Weisbecker <frederic@kernel.org>
To: Peng Wang <peng_wang@linux.alibaba.com>
Cc: Anna-Maria Behnsen <anna-maria@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>, Thomas Gleixner <tglx@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Danilo Krummrich <dakr@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Waiman Long <longman@redhat.com>, Tejun Heo <tj@kernel.org>,
	He Rongguang <herongguang@linux.alibaba.com>,
	linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
	driver-core@lists.linux.dev, linux-trace-kernel@vger.kernel.org,
	cgroups@vger.kernel.org
Subject: Re: [RFC PATCH v2 1/2] tick/nohz: Add a policy dependency for full dynticks
Date: Wed, 28 Oct 2026 16:58:47 +0100	[thread overview]
Message-ID: <auIbt5JAC2cHw5jr@localhost.localdomain> (raw)
In-Reply-To: <atuMJiJEwbzGjiu4@MacBook-Pro.local>

Le Sat, Oct 24, 2026 at 12:32:38AM +0800, Peng Wang a écrit :
> On Fri, Oct 23, 2026 at 05:00:22PM +0200, Frederic Weisbecker wrote:
> > Le Sat, Oct 17, 2026 at 09:13:41PM +0800, Peng Wang a 殂rit :
> > > Cloud hosts may pin vCPU threads one-to-one to host CPUs. At full
> > > allocation this includes the housekeeping CPUs, which always retain
> > > their non-idle tick. Operators want comparable performance for otherwise
> > > equivalent vCPUs. Retaining the non-idle tick on nohz_full CPUs as well
> > > avoids one placement-dependent difference in host tick interference.
> > > With spare capacity, selected CPUs may stop the tick to reduce host
> > > scheduler-tick interference with vCPUs.
> > > 
> > > Allocation changes as VMs are created or destroyed while other VMs
> > > remain running. A vCPU thread may be the only runnable task in either
> > > state, so existing tick dependencies do not express this policy.
> > 
> > I'm not sure I understand correctly what you are trying to solve.
> > Are you saying that you want to keep the tick running when there
> > is more than one vCPU per CPU? Because the scheduler already takes
> > care of that.
> 
> Hi Frederic,
> 
> No. We pin vCPU threads one-to-one to host CPUs, without
> oversubscription. By "full allocation" I meant that all allocatable
> host CPUs are in use, including CPUs outside the nohz_full set.
> 
> For example, on an eight-CPU host booted with isolcpus=nohz,1-7,
> CPU0 is outside the nohz_full set:
> 
> - With eight pinned vCPUs, CPU0 retains its non-idle tick while
>   CPUs1-7 may stop theirs. Retaining the tick on CPUs1-7 too avoids
>   this placement-dependent difference in tick interference between
>   otherwise equivalent vCPUs.
> 
> - With seven or fewer pinned vCPUs, we can leave CPU0 without a
>   vCPU and keep them on CPUs1-7. We can then allow tick suppression
>   on CPUs1-7, subject to the existing dependencies. This gives
>   these vCPUs a common tick policy while reducing host tick
>   interference.
> 
> If the vCPU on CPU0 is released while the other seven remain
> running, we allow CPUs1-7 to suppress their ticks. If a new vCPU
> is later assigned to CPU0, we retain the ticks on CPUs1-7 again
> to avoid the difference in tick interference.
> 
> Throughout these transitions, CPU1 can still have its original
> pinned vCPU thread as its only runnable task. Its runnable task
> count does not change merely because CPU0 gains or loses a vCPU,
> so the scheduler's existing tick dependency cannot express this
> allocation policy.

Ok now I understand what you want to do, I just don't understand why.
Why it matters to turn off nohz_full on all CPUs when vCPUs run on housekeeping?

> > > Add a per-CPU POLICY dependency within the boot-time nohz_full set.
> > > Permission defaults to enabled. The policy can be changed without
> > > taking CPUs offline. Revoking permission uses the existing asynchronous
> > > kick; granting it leaves all other dependencies effective. Preserve
> > > POLICY across CPU hotplug and report it in tick_stop tracing.
> > > 
> > > Idle tick suppression, nohz_full membership, context tracking, RCU
> > > offloading and housekeeping configuration are unchanged.
> > 
> > This still keeps the overhead of nohz_full even if the tick stays on, right?
> > (RCU nocb, kernel <-> user overhead, etc...). Isn't it a problem for you?
> 
> Yes. Our setup uses only the nohz flag of isolcpus, without
> additional housekeeping affinity tuning. Context tracking and
> RCU callback offloading remain enabled when the tick is kept
> running.
> 
> We have observed a performance benefit from this nohz_full setup
> with our database workload running on pinned vCPUs.

Do you mean that your database runs better when hosts CPUs are in nohz_full?
But how does this new interface help? Ie: why is it worse to have all CPUs in
nohz_full except the housekeeping rather than shutting down nohz_full
altogether?

Or to put it another way: why is it better to have either:

- all vCPUs on nohz_full host CPUs
or
- all vCPUs on ticking CPUs

And why does it hurt to have a single vCPU running on a ticking CPU.

Thanks.

-- 
Frederic Weisbecker
SUSE Labs

  reply	other threads:[~2026-10-28 15:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-17 13:13 [RFC PATCH v2 0/2] tick/nohz: Add per-CPU control of non-idle tick suppression Peng Wang
2026-10-17 13:13 ` [RFC PATCH v2 1/2] tick/nohz: Add a policy dependency for full dynticks Peng Wang
2026-10-23 15:00   ` Frederic Weisbecker
2026-10-23 16:32     ` Peng Wang
2026-10-28 15:58       ` Frederic Weisbecker [this message]
2026-10-29  6:41         ` Peng Wang
2026-10-29 14:02           ` Frederic Weisbecker
2026-10-17 13:13 ` [RFC PATCH v2 2/2] cpu: Add per-CPU control of non-idle tick suppression Peng Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=auIbt5JAC2cHw5jr@localhost.localdomain \
    --to=frederic@kernel.org \
    --cc=anna-maria@linutronix.de \
    --cc=cgroups@vger.kernel.org \
    --cc=dakr@kernel.org \
    --cc=driver-core@lists.linux.dev \
    --cc=gregkh@linuxfoundation.org \
    --cc=herongguang@linux.alibaba.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=mingo@kernel.org \
    --cc=peng_wang@linux.alibaba.com \
    --cc=peterz@infradead.org \
    --cc=rafael@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox