From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=212.77.101.12 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795094919; b=ruGxLOPZ3spEb/Ua0wbuyjzqlW9mbhWYm/UJ7+u9X/XOaxN/Jxqxl2EMT8vevzWylPJ3 IJ03+pfohVUty6twoxiUEZEsHfaaZ+5evImTSoH7XJF9VEgr7/ehkuUrdt8GfyxpAi6sl EHAujcRb6R928kCKO+clgCJgVylKlWOHwoy+repNaNKXu+nAoWRBEq7E9F4cx02H4uDnD gHrnGWI87uxeFwtQWhjBp/J6/k6+njNgH8tMdl+35xRT1Dek2P35bVlov06bNLTVEkzcw DWJuJaA4Qo/V0YSu/xhVeAFsgEG2N6Wg6ZzhSdddLlkUoGxo57tgMxj/VEwwowSprPQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795094919; h=DMARC-Filter:Received:DKIM-Signature:Received:Date:From:To:Cc: Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:Content-Transfer-Encoding:In-Reply-To:X-WP-MailID: X-WP-AV:X-WP-SPAM; bh=nFs7LhyMy8k5jmGRKz1u70BSbgNhRCYabK2uhH/Xm0o=; b=kqMoBZAXsuENREaDR2xEvFEO0uPeY94Tli6KxEFxpP/LHejPE3sOwvb0mZP0nyk3lZiy KI6EQp5dgckah0F/elA3c4OMbrq1Nzp+laK4Ih+4m7TxoKsxcLsD1ACcJu/xwirVZuplS rRKZoDBZblJlvWO0RzXM5Tx70hVcL+W+0/geC6/ItGEJIdJ/0lKRlQFHa3q+JyOHoimJd 3EaEA6dkRse4RoVr5aJRM1doB0zFR1RKh/TmWnfWRJeIss0kYazcTbVVFVuMdvBKGUVJB wxvVIVhKnEOZQEz5GIs3Nu/WfIQjRdvM/1fLcGupe13I6JBsKz1I1EZfzwo1BMr2ymQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=wp.pl; spf=pass smtp.mailfrom=wp.pl; dkim=pass header.d=wp.pl header.i=@wp.pl header.a=rsa-sha256 header.s=s20261001 header.b=V2TDVTkp; arc=none smtp.remote-ip=212.77.101.12 Received: from mx4.wp.pl (mx4.wp.pl [212.77.101.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC6C6606AA74 for ; Thu, 19 Nov 2026 13:28:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org EC6C6606AA74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=wp.pl Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=wp.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=wp.pl header.i=@wp.pl header.a=rsa-sha256 header.s=s20261001 header.b=V2TDVTkp Received: (wp-smtpd smtp.wp.pl 40278 invoked from network); 19 Nov 2026 14:28:34 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=s20261001; t=1795094914; bh=nFs7LhyMy8k5jmGRKz1u70BSbgNhRCYabK2uhH/Xm0o=; h=From:To:Cc:Subject; b=V2TDVTkp6Twu60YGIv2NCg68IvYXBm+v+dlOqdyd/n5kGJgr51wVRE951Gash8RIs 62/x215GUrBT+jYp9l/W43PkAqXQUGT7pn/9yUUN/3Y8MAEc9GA6xXs4igFqLij4ix 0LsPtIfWP0u9JnWWd97zufqpUOKgxppFDcGP3sDIq3r/Ef/zhSdaQwE5u54lraiZXg I8YhZoQTCW+5R5EroEdhUC58nXkbDUMLEdTv9wSiPrrsCHwxzGpLoL1J9/z4hJTvBO jF+2IjGdHWzqP61HaFOSZ/bR0uH1/ioj0iUd4Qqa9wI28SLPJYY4weGVvvbSB6QKP/ DhUwwEUfL9wDg== Received: from localhost (77-236-5-223.static.play.pl [77.236.5.223]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with TLS_AES_256_GCM_SHA384 encrypted SMTP for ; 19 Nov 2026 14:28:34 +0100 Date: Thu, 19 Nov 2026 14:28:34 +0100 From: Stanislaw Gruszka To: sashiko-reviews@lists.linux.dev Cc: linux-modules@vger.kernel.org, Sami Tolvanen , Luis Chamberlain , Petr Pavlu , linux-trace-kernel@vger.kernel.org, live-patching@vger.kernel.org, Daniel Gomez , Aaron Tomlin , Steven Rostedt , Masami Hiramatsu , Jordan Rome , Viktor Malik , Petr Mladek Subject: Re: [PATCH v3 2/3] module/kallsyms: sort text symbol indices and use binary search Message-ID: References: <20261118145125.29399-1-stf_xl@wp.pl> <20261118145125.29399-3-stf_xl@wp.pl> X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-WP-MailID: 783790f8ec710f57db30d5bf09b3768a X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski X-WP-SPAM: NO 000000A [kTPk] On Wed, Nov 18, 2026 at 03:02:42PM +0000, sashiko-bot@kernel.org wrote: > > +// static void pr_tab(unsigned int *tab, unsigned int n, Elf_Sym *syms) > > +// { > > +// int i; > > +// // printk("\n"); > > +// for (i = 0; i < n; i++) { > > +// printk(KERN_CONT "%d,", tab[i]); > > +// } > > +// printk("VALUES \n"); > > +// for (i = 0; i < n; i++) { > > +// printk(KERN_CONT "0x%08llx,", > > +// (unsigned long long)syms[tab[i]].st_value); > > +// } > > +// printk("\n"); > > +// } > > +// > > [Severity: Low] > Was this commented-out pr_tab() debug helper left in by mistake? Yes. > > -- > Sashiko AI review · https://sashiko.dev/#/patchset/20261118145125.29399-1-stf_xl@wp.pl?part=2