From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.46 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795111396; b=IR2Cqayo1juHMeQDl7oB5NJsD/qJLCeNx8pHtd5zH3Z8I0yY081ND5eYwAnozJTiqPoi 6iJVScrfkvM7rJaK/HNx3nm0R0Q7d89vYmYJaZaXx0zZrJj2Um8zmhGRr0W5pPJ98KfrS xdQsJaFJLGZV5W+OZKbZnKV66zPMIaK6yMOBdkqxv6wsA/pjzRwXFVegfiX2LCJy+FfCy 7LKeQ/uEEh2hAhb4gl/QyHvzeLkJZ7L8152S0eMYEXz92st8Yj2/tXpZlCtiwjEiwH3sU rgDaUhz0HEWZg/KBFszw7iyPVfPGRp/0cP7gLoLvFQf1aD/JjsYo10PT1bZErlEIAqQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795111396; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; bh=M3aTvEzquBrOiSj2mlzWhSxH+izz4607hFK76/YmCDk=; b=VSr5d6WiXZEwKqw2sPAMbxzD7Ru/caNlgFaeZVALGWW1SwUN/w8yvgzhpWxPM+NRoZgp 8lPr9XC0UdNcpJS5R7HgAA0Dp+aGPQTQfZDKa26BMp9BPkA2XWDXopJlzEwLLCCa/GAZB GFHWR0RnTQ4Wq0EA7UtcAv6xbkpsgE/dYMdindvyBLHDEODEYJJp0z+lEzvj8CH73tfsX kgt225WDZ1aHIE3bubseyFZM3orrDtNaF4RZQxnH0tS4JVnRcrIN1Wxhac0QumWd97qBb m+QuedJUee7nFLL3cbqgM1o97P39+5paziI77RTtlWltyeoiqDwX2jWOUV0PAgHx+4A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass header.d=baylibre.com header.i=@baylibre.com header.a=rsa-sha256 header.s=google header.b=MqSC4DAg; arc=none smtp.remote-ip=209.85.221.46 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5409260A260D for ; Thu, 19 Nov 2026 18:03:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 5409260A260D Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.a=rsa-sha256 header.s=google header.b=MqSC4DAg Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-4a34ffd3e39so1496693f8f.0 for ; Thu, 19 Nov 2026 10:03:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1795111394; x=1795716194; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=M3aTvEzquBrOiSj2mlzWhSxH+izz4607hFK76/YmCDk=; b=MqSC4DAgywaLe4KR5xqH3of1cfPM/uiKIncJ6UtFG1Rz3EzgT0FwejXVHVXEB5ci/O TftKKjryaTOwn85SS2I+3aFA9HTGAdgvHGmGojzllNvS7zjClZgeo0806BhgRvBvccVj pvl8czaOEK+PvuDXD4lsl6dfvtzVKyaDgWW4eIHExXeBqxXaS5ZfSyOBf42VLPt+H7dr Xpy5nSgnEB+M+TzN25HAV+Ni3O55mUW8zFDnAALpU7+wX1zMSmRkAVqxlKqmk9SpGxvJ 1LNGqpYHPMZ+Lx24Wg53TNzDWPAcMgGZEccrcDhpAnYU6Mji9Wo8fqGAcbKjCa0G/VWx 4V8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795111394; x=1795716194; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=M3aTvEzquBrOiSj2mlzWhSxH+izz4607hFK76/YmCDk=; b=V38L58nFUFlw0PzlY36MY64ccD6ZICU/0DgFan3B6q4fhIHLAGR1oPF2bfBqpjgWM1 7kJHr/Uy4QTP9+VFYQ8klIM+ZYgrAvZ6Rv8rxd0guQ63TQS/vfjUUsntP8x5nq9xZm3p nFMp/ZGh+gyGtj7R6pF0DGvET11PGHgCy3NdFOLNutxO6WtXSYb6zSOUgAxZ0f304UbN ZkK3Nfwf3Un6yHk1ZSnZ5gZLJFTYni+VbP0XhElq1ugodQkL0eQUsqtsTmxGVs1POcRK SUsXfhAvYsondrj0Zyw3fC8c5SaovWmXU2FX8A8bTgGhX/9l0gMB8EoqxwndrZeDC2h2 vymg== X-Forwarded-Encrypted: i=1; AL+hErFi46dowm2GIh0aUaPoE49BxlDnA70ezu7stf46I8Az9yOy8iaMkNyjx6WEKzLnJwGd1VqijXjcFJHuejqjoSSRYFs=@vger.kernel.org X-Gm-Message-State: APuU4Z/afuaN7lgj4tpDsgw7jJ7IexhlL9/6LX1KvwnYFrxijBAXVsPP L6dFt2PGfk1uS37WS7O//m3GR8HkKSoenu34NkgBjReADytOPUx8sfHTUyQ+yVOTV4Y= X-Gm-Gg: AYBFou3uQVN9UJ+DyuzxYC9rFtD4/231+ktD3xPOnycn9PCGd5zaO5d1NPbCEqWJ4V6 jFeoqRW2rOGepQM443gQTZbfkabXD6jDnm0ZWh+kpLnhpQTBUNlBwn/PWLm0OXD60+u8FmhAZ6n Ypv8y4MyUzhsZTlHNs5AsE5DZ+MgXOgXtyFRfpe85H+Ggb3i6mNKpf4aFWPUpnzUVo1m7Aw8LrN zQklAiK/OzK8oQwShqeJv23XaPheqVIPy7UkZlbPtHTUm+GA4dVLasRGC8rbVXHsBeXUcxBlUSD Ccitmb7uLcHYmRjfNFmp5XKJzC73pea/Bz4OB1dxK68fM3lu4bbT//S7+J+FTG73cwbhfv+Rvdc ot05m+R8CajxqNhC0/5QRHsdXvssKZFxwtYnWcvB6SOIDGngAMnaqImFpvtyxT7GhiY9sqK4Ct5 hPRfOZLAijs3xwZjFVxJDxd4me9YARpHC9HM4HU0+uTOTuZaHQVRmhAr4ZUDm/U7PbrB0R5CDrZ iVxdgXFXLu4DL1V2wzESmdgziD2V+bM0ynq2ej06Ape9qRaTboGzT9ZKV2Ed1DlAZl3m5Vrd64l 2BeS1YYMak2DPB/kDmHREe2Dh8j7Hj9ZcjnOiLrB5o922k7uh30u2T+o6onClnQGWXUfk4s5nzJ 7J7/f+ybVksfi1A== X-Received: by 2002:a05:600c:3b9e:b0:4a1:cf60:dcc3 with SMTP id 5b1f17b1804b1-4bb88820687mr7335575e9.29.1795111393609; Thu, 19 Nov 2026 10:03:13 -0800 (PST) Received: from localhost (p200300f65f19a904994d80f004b20d71.dip0.t-ipconnect.de. [2003:f6:5f19:a904:994d:80f0:4b2:d71]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-4ab6c340df4sm1143252f8f.55.2026.11.19.10.03.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Nov 2026 10:03:12 -0800 (PST) Date: Thu, 19 Nov 2026 19:03:11 +0100 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Anthony Krowiak Cc: Alex Williamson , Greg Kroah-Hartman , Jonathan Corbet , Shuah Khan , Randy Dunlap , "Rafael J . Wysocki" , Danilo Krummrich , Johan Hovold , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , David Lechner , Armin Wolf , Thierry Reding , Mike Rapoport , Arnd Bergmann , Karl Mehltretter , "Paul E . McKenney" , Borislav Petkov , Dapeng Mi , Marco Elver , Ethan Nelson-Moore , Jeff Layton , Bradley Morgan , Andrew Morton , Petr Mladek , Pnina Feder , Mete Durlu , Aaron Tomlin , Rio , Feng Tang , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, driver-core@lists.linux.dev, linux-trace-kernel@vger.kernel.org, Mark Brown , Bjorn Helgaas , Jason Herne , Eric Farman , Matthew Rosato , Halil Pasic , linux-s390@vger.kernel.org Subject: Re: [PATCH] s390/vfio: Allow untainted use of driver_override Message-ID: References: <20261119051507.3306075-1-alex@shazbot.org> X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rnhi7e7twhetgmlw" Content-Disposition: inline In-Reply-To: --rnhi7e7twhetgmlw Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH] s390/vfio: Allow untainted use of driver_override MIME-Version: 1.0 Hello, On Thu, Nov 19, 2026 at 07:14:47AM -0500, Anthony Krowiak wrote: > On 11/19/26 12:15 AM, Alex Williamson wrote: > > diff --git a/drivers/s390/crypto/vfio_ap_drv.c b/drivers/s390/crypto/vf= io_ap_drv.c > > index 8e69ed286bb9..2d47dc643269 100644 > > --- a/drivers/s390/crypto/vfio_ap_drv.c > > +++ b/drivers/s390/crypto/vfio_ap_drv.c > > @@ -62,6 +62,7 @@ static struct ap_driver vfio_ap_drv =3D { > > .on_config_changed =3D vfio_ap_on_cfg_changed, > > .on_scan_complete =3D vfio_ap_on_scan_complete, > > .ids =3D ap_queue_ids, > > + .driver.support_driver_override =3D true, >=20 > Does this really belong here? Shouldn't it be in struct ap_driver > since driver_override is supported in the AP bus? ap_device_probe() calls device_match_driver_override with drv=3D&ap_drv->driver. So I think the assignment is fine. Best regards Uwe --rnhi7e7twhetgmlw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmr/OdwACgkQj4D7WH0S /k7x+gf9FZVgAr7FFBlDRjq6odYeaqNCOaCFNVlsdz+mmeuvFoiyhQGlFuLA5fBI RI+cAKOjVw6JQLaNWU56WyXOjyMbZ9rX1X2wiPj4dx6oWxUQ0G4oyTpMx5M9e7yX JKEEMhBjk2hmDBDO8qTnVhrPzy+7pp0orXoElqEDT46+aZRSeBMRcSLzripwP5P2 0GBczvM7k943oKVhZ/4VuYKxowT7ALpC+OTDKy3ALqIuhhIvTY0LGjWdrDU7XBx1 NWAf33X/vh9oQSepjVMFnBaOEpOdIayc4ILJCCVuX6stvlriJCTtFBVtzja/AGZ6 BrG53U8a5eWfIY/nnztu6uaaw9royQ== =LHa2 -----END PGP SIGNATURE----- --rnhi7e7twhetgmlw--