From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.53 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794415664; b=WyJjEe3gMJpa5az1wV75Nx73ISIa4lvWkyMKhHehaKTwdJnLU4Z+AQDQEucmUtKFWza7 w8WGujaSjzLkgYTbgx97PDAJnsjEWgfBAjagp0EYBSO6ZZrbA8X1BKowRkZ+m8IxfPLhe GFQ+oVC/I9gW25nSfJ+DHCSn4yMmNTBR20kBcdLKLQ48Aof3IYwIVjQKq/9g9oc+tRTdt OyHKFOKyvy4H1vZPwKTc9nq6NeKl6fIq09RJ0VOiPSUqIA9t31UEFPmKIkr95loTpiyyQ ztZMqKsNPXepbi7BT6ESq0Zxg0kjlVLAiuIhJzGa1LmiL125+3/zr+AXJDHPG/Of0Fg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794415664; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; bh=JEN1we3zUbJ34wQgamBpttlVbDethKWGuPURScqYgfU=; b=sHyg2vZDbE2+iWcWBXibgD0sIsHp2FCGYDxFHud/iftEYewXjubWDmxnqSmsYl5QiR6h cjcBWGVH1V7KCun5ORdI7mtdAB4PMm3qPEPkkCZSO5nHTjxuUXGjzwUz7j4KFlB2JrCKI hqp4uQOY8K7d+MVRzD8/l7KfL6QwhjSaUleN/reCV9spQ7NNw62lrOPoYjUG1qXRsIM4V omMbBbcs0j852tL6GpHuht9I9RUV4w8EcY8/Or1Zs+ulbzJlIM4HUoQ8N962SiymJyF0u IA+RQGxF284Uv/rTH8iKI2BzWreimms9aUCiQXbTp3743hUktxztQJ9XoSFliB+mHcw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=Arhv0r+C; arc=none smtp.remote-ip=209.85.128.53 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73328606A321 for ; Wed, 11 Nov 2026 16:47:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 73328606A321 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=Arhv0r+C Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4a9a8d6cea8so239005e9.1 for ; Wed, 11 Nov 2026 08:47:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1794415663; x=1795020463; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=JEN1we3zUbJ34wQgamBpttlVbDethKWGuPURScqYgfU=; b=Arhv0r+CzJ6kd+TulLavcwx/mGrglYS422JYKTdbpa5un1a18rj23MyxqxLhddkmnB gNcaXJ2IrojyJbxM+OgBPEAeEpsNpzWgOGqEgdEdfbdQsuKembFEQ+6KhZaeIYR30gze IooSZe2fNj/7K3ZNeH8x15dEsu+UQLaI/m1IWuoX86P9po90K2PyeQK2TvubNwe2um3L oa28twmLTolBcK1wc4TjQY120ADR9pALZ4st9GAliG4qO1r6wi1yEW2L29tlSgZjmr2h E0qSshK5f4Tgf9M06nnSpMmyfbMbMx74mcpO6fx0yDufhfISeijTTqV/EjmW0IdaeTyH ahNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794415663; x=1795020463; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=JEN1we3zUbJ34wQgamBpttlVbDethKWGuPURScqYgfU=; b=GT8Bdp1YdgG9KQN5lgMwXtTIywoksxyYVbWukbUABcCp+qogKOtTEPSDLmdnTFokb8 fdLqrBRiUJ7IDLYPa5N3b60v5TDe6Ux0/FaiL/rW2SFIN6OV0DDsxheHuUV1AvpQrMAd S0KajSzhpyIIQ3RX7JYXXdQMM69E/XenPVLKEyA3YNhQvRzzLm4yQWZUUulLmSWjHjto LCHh46MRTyzmp8y0I9KJqSTUAu9IEKumxKVigOGL2oqbr7lFFjIB+mu3syB/puYh9pp8 YPcYfipwI8dGrcdDzHmAxPrDcKcMnKfu2Aafe4tbm2DLFtnTb1abXyjpUJn33GywsKYR WrkA== X-Forwarded-Encrypted: i=1; AL+hErFR7IIs2iN2Opjb58qvThRLEW5h50KsGzxyRlsS3PbkaVFQt/yFCFLJ8hiHwdIOXZsOBQtFF+yXPugufNTFNNapFZA=@vger.kernel.org X-Gm-Message-State: APuU4Z9G7cYtWZEHmQWrqKnaMZ0d7C0oZO6NVk/r/3vo0cliKheZEGjL SI7PNZ/FEBOD0q65X3ZU7Uw49WEj5NRcpcZj8AVSFJ9T62/cKtLsnTwzydmtW2uE6w== X-Gm-Gg: AYBFou2oiJf/n54AijijuaPwlxk28Lf/7q1rNYGdTTNUcrJpyl+CozS0eEMy4WL1nKn 9gbmu7Kp1SvXOf3ZGHuX51+eh5TqXmu+y0Y32ZRwfBUEvmQVN/XEf1rAUwGsjoV3RtIgh7ogqqM K2ReVWwk/ZK4qXX9me2AKIz8BQLbuxe554w1gIsdV80PWVk/6MMsI5uE+t0bDMXojl4tci5GcJf FifArF3XmQMOW6zoufmvdnA26Xw10Y11TWjz3AKPAA0aD6yNNWYacwDoCW3hfqBdbNIeXq91KPY MxYcAvG+jcSqQKaFw0Sr+MYPFOtvTRtLLE5XsU/TtQFiDaQgezqfnJDbbyYiI/+DTEPr0c75M5P 3TAUqNMBFOVYk555qzCJETRt57Xq336un5LF/SJBJPqtrYKCN1ikmld6P769Tv39VImFTKrBmoC 3mSS32A64nvgSEg55w+ZGvkXTQ7PE9ZFJdT3Dgc07ZANPotv4x284Ny2kQ/FiHGCa6nFhp2a2m/ eJeNo7/nAzuwdAPE6AvimmXZIWNacpDn9WL8vG52FBYEFpcSbgrRBmLcvEGHtgGp8ITYEdYPrmr npfkDcAMoOKwuGXk85P8jtVMMKcxHlrvEPcSacivu/vWah9dnySBJ3tJmMf8/vnxvA== X-Received: by 2002:a05:600c:3f07:b0:4a2:18c4:61a5 with SMTP id 5b1f17b1804b1-4bb4e27994emr1100895e9.6.1794415662004; Wed, 11 Nov 2026 08:47:42 -0800 (PST) Received: from google.com (0.182.34.34.bc.googleusercontent.com. [34.34.182.0]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-498365cd06fsm11724877f8f.40.2026.11.11.08.47.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2026 08:47:41 -0800 (PST) Date: Wed, 11 Nov 2026 16:47:38 +0000 From: Vincent Donnefort To: Tao Cui Cc: akpm@linux-foundation.org, dgilbert@interlog.com, mkp@kernel.org, loberman@redhat.com, jmeneghi@redhat.com, kraxel@redhat.com, vivek.kasireddy@intel.com, mst@redhat.com, jasowangio@gmail.com, eperezma@redhat.com, stefanha@redhat.com, sgarzare@redhat.com, rostedt@goodmis.org, mhiramat@kernel.org, jgg@ziepe.ca, kevin.tian@intel.com, axboe@kernel.dk, linux-mm@kvack.org, James.Bottomley@hansenpartnership.com, sumit.semwal@linaro.org, christian.koenig@amd.com, phasta@kernel.org, joro@8bytes.org, will@kernel.org, linux-scsi@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, kvm@vger.kernel.org, virtualization@lists.linux.dev, linux-trace-kernel@vger.kernel.org, iommu@lists.linux.dev, io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, bobbyeshleman@meta.com, mathieu.desnoyers@efficios.com, robin.murphy@arm.com, mason@kernel.org, aesteve@redhat.com, tjmercier@google.com, harry@kernel.org, vbabka@suse.cz, cuitao@kylinos.cn Subject: Re: [PATCH 4/7] tracing: account ring buffer pages and trace_array metadata to memcg Message-ID: References: <20261106131829.3228926-1-cui.tao@linux.dev> <20261106131829.3228926-5-cui.tao@linux.dev> X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261106131829.3228926-5-cui.tao@linux.dev> On Fri, Nov 06, 2026 at 09:18:26PM +0800, Tao Cui wrote: > From: Tao Cui > > Creating an instance immediately allocates two full sets of per-cpu > ring buffers, array buffer plus snapshot, about 1.375MB per cpu per set > on the default config, plus the trace_array and its name. None of it > is charged: neither trace.c nor ring_buffer.c passes __GFP_ACCOUNT, > while user_events in the same directory accounts everything it > allocates. > > Instance creation is currently gated by tracefs file permissions > alone, so a > rootful container with the host tracefs bound in can create instances > until the host runs out of memory. Charge the ring buffer pages and > the trace_array metadata to the creating cgroup. > > Signed-off-by: Tao Cui > --- > kernel/trace/ring_buffer.c | 8 +++++++- > kernel/trace/trace.c | 6 +++--- > 2 files changed, 10 insertions(+), 4 deletions(-) > > diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c > index 1fd28a72e6ee..676c059c112c 100644 > --- a/kernel/trace/ring_buffer.c > +++ b/kernel/trace/ring_buffer.c > @@ -441,7 +441,13 @@ static struct buffer_data_page *alloc_cpu_data(int cpu, int order) > * gracefully without invoking oom-killer and the system is not > * destabilized. > */ > - mflags = GFP_KERNEL | __GFP_RETRY_MAYFAIL | __GFP_COMP | __GFP_ZERO; > + /* > + * The subbuffers are charged to the memcg of whoever caused the > + * allocation: the creator of a trace instance, or root at boot for > + * the global trace. > + */ > + mflags = GFP_KERNEL | __GFP_RETRY_MAYFAIL | __GFP_COMP | __GFP_ZERO | > + __GFP_ACCOUNT; > > page = alloc_pages_node(cpu_to_node(cpu), mflags, order); > if (!page) Hum, by default tracefs is root only. And even if made accessible to other users: 1. The life span of a trace instance is not tied to the caller. 2. The ring buffer is shared by multiple users. Overall I am not convinced charging the creator makes much sense. Eventually a few allocations for iterators could be GFP_ACCOUNT. -- Vincent > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c > index e8c4efa8107b..04b60b9cc4f5 100644 > --- a/kernel/trace/trace.c > +++ b/kernel/trace/trace.c > @@ -8693,11 +8693,11 @@ trace_array_create_systems(const char *name, const char *systems, > int ret; > > ret = -ENOMEM; > - tr = kzalloc_obj(*tr); > + tr = kzalloc_obj(*tr, GFP_KERNEL_ACCOUNT); > if (!tr) > return ERR_PTR(ret); > > - tr->name = kstrdup(name, GFP_KERNEL); > + tr->name = kstrdup(name, GFP_KERNEL_ACCOUNT); > if (!tr->name) > goto out_free_tr; > > @@ -8708,7 +8708,7 @@ trace_array_create_systems(const char *name, const char *systems, > goto out_free_tr; > > if (systems) { > - tr->system_names = kstrdup_const(systems, GFP_KERNEL); > + tr->system_names = kstrdup_const(systems, GFP_KERNEL_ACCOUNT); > if (!tr->system_names) > goto out_free_tr; > } > -- > 2.43.0 >