Linux Trace Kernel
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@oss.nxp.com>
To: sashiko-reviews@lists.linux.dev
Cc: Praveen Talari <praveen.talari@oss.qualcomm.com>,
	linux-trace-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
	vkoul@kernel.org, Frank.Li@kernel.org
Subject: Re: [PATCH v4 2/2] dmaengine: qcom: gpi: Convert dev_dbg() calls to tracepoints
Date: Mon, 16 Nov 2026 14:57:28 -0600	[thread overview]
Message-ID: <avtuOCLAtZEUeNg0@SMW015318> (raw)
In-Reply-To: <sashiko-outbox-204408@kernel.org>

On Mon, Nov 09, 2026 at 04:40:34AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [Medium] dmaengine: qcom: gpi: bare default label in
>   gpi_process_events()
> --
>
> commit 5129f82faa3a23c9f80811290603ff518d6e73fb
> Author: Praveen Talari <praveen.talari@oss.qualcomm.com>
>
> dmaengine: qcom: gpi: Convert dev_dbg() calls to tracepoints
>
> This commit replaces the remaining dev_dbg() calls in the Qualcomm GPI DMA
> driver with tracepoints.
>
> > diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
> > index fafe6ac848d94..8f9e55e52c616 100644
> > --- a/drivers/dma/qcom/gpi.c
> > +++ b/drivers/dma/qcom/gpi.c
>
> [ ... ]
>
> > @@ -1121,11 +1105,8 @@ static void gpi_process_events(struct gpii *gpii)
> >  							    &gpi_event->immediate_data_event);
> >  				break;
> >  			case QUP_NOTIF_EV_TYPE:
> > -				dev_dbg(gpii->gpi_dev->dev, "QUP_NOTIF_EV_TYPE\n");
> >  				break;
> >  			default:
> > -				dev_dbg(gpii->gpi_dev->dev,
> > -					"not supported event type:0x%x\n", type);
> >  			}
> >  			gpi_ring_recycle_ev_element(ev_ring);
> >  		}
>
> [Severity: Medium]
> Does removing dev_dbg() from the default: case in gpi_process_events()
> leave a label at the end of the switch block without a break statement?
> Under -std=gnu11, GCC versions prior to GCC 11 reject a bare label before
> a closing brace with a build error.

Please remove default: also

Frank

>
> --
> Sashiko AI review · https://sashiko.dev/#/patchset/20261109-add-trace-support-gpio-v4-0-85ed08134917@oss.qualcomm.com?part=2

      reply	other threads:[~2026-11-16 20:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-09  4:28 [PATCH v4 0/2] dmaengine: qcom: gpi: Add trace event support Praveen Talari
2026-11-09  4:28 ` [PATCH v4 1/2] " Praveen Talari
2026-11-09  4:40   ` sashiko-bot
2026-11-09  4:28 ` [PATCH v4 2/2] dmaengine: qcom: gpi: Convert dev_dbg() calls to tracepoints Praveen Talari
2026-11-09  4:40   ` sashiko-bot
2026-11-16 20:57     ` Frank Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avtuOCLAtZEUeNg0@SMW015318 \
    --to=frank.li@oss.nxp.com \
    --cc=Frank.Li@kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=praveen.talari@oss.qualcomm.com \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox