From: Dan Carpenter <dan.carpenter@linaro.org>
To: mhiramat@kernel.org
Cc: linux-trace-kernel@vger.kernel.org
Subject: [bug report] tracing/probes: Support $argN in return probe (kprobe and fprobe)
Date: Tue, 19 Mar 2024 10:19:09 +0300 [thread overview]
Message-ID: <b010488e-68aa-407c-add0-3e059254aaa0@moroto.mountain> (raw)
Hello Masami Hiramatsu (Google),
Commit 25f00e40ce79 ("tracing/probes: Support $argN in return probe
(kprobe and fprobe)") from Mar 4, 2024 (linux-next), leads to the
following Smatch static checker warning:
kernel/trace/trace_probe.c:856 store_trace_entry_data()
error: uninitialized symbol 'val'.
kernel/trace/trace_probe.c
846 return;
847
848 for (i = 0; i < earg->size; i++) {
849 struct fetch_insn *code = &earg->code[i];
850
851 switch (code->op) {
852 case FETCH_OP_ARG:
853 val = regs_get_kernel_argument(regs, code->param);
854 break;
855 case FETCH_OP_ST_EDATA:
--> 856 *(unsigned long *)((unsigned long)edata + code->offset) = val;
Probably the earg->code[i] always has FETCH_OP_ARG before
FETCH_OP_ST_EDATA but Smatch isn't smart enough to figure that out...
857 break;
858 case FETCH_OP_END:
859 goto end;
860 default:
861 break;
862 }
863 }
864 end:
865 return;
866 }
regards,
dan carpenter
next reply other threads:[~2024-03-19 7:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 7:19 Dan Carpenter [this message]
2024-03-19 14:10 ` [bug report] tracing/probes: Support $argN in return probe (kprobe and fprobe) Steven Rostedt
2024-03-19 14:39 ` Dan Carpenter
2024-03-20 3:44 ` Masami Hiramatsu
2024-03-20 13:22 ` Steven Rostedt
2024-03-20 8:10 ` [PATCH] tracing: probes: Fix to zero initialize a local variable Masami Hiramatsu (Google)
2024-03-20 13:26 ` Steven Rostedt
2024-03-20 13:27 ` Steven Rostedt
2024-03-20 22:56 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b010488e-68aa-407c-add0-3e059254aaa0@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox