From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Tze-nan Wu <Tze-nan.Wu@mediatek.com>,
rostedt@goodmis.org, mhiramat@kernel.org
Cc: bobule.chang@mediatek.com, wsd_upstream@mediatek.com,
stable@vger.kernel.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2] ring-buffer: Prevent inconsistent operation on cpu_buffer->resize_disabled
Date: Sun, 9 Apr 2023 19:30:53 +0700 [thread overview]
Message-ID: <b05d80ab-fd72-1346-f5d9-b80ae9b5cd1a@gmail.com> (raw)
In-Reply-To: <20230409024616.31099-1-Tze-nan.Wu@mediatek.com>
On 4/9/23 09:46, Tze-nan Wu wrote:
> This issue can be reproduced by "echo 0 > trace" and hotplug cpu at the
> same time. After reproducing success, we can find out buffer_size_kb
> will not be functional anymore.
>
Do you mean disabling tracing while hotplugging CPU? Or disabling both
tracing and hotplug CPU?
> This patch uses cpus_read_lock() to prevent cpu_online_mask being changed
> between two different "for_each_online_buffer_cpu".
>
"Use cpu_read_lock() to prevent ..."
> Changes in v2:
> Use cpus_read_lock() instead of copying cpu_online_mask at the entry of
> function
>
To resolve kernel test robot warnings ([1] and [2])? Or have they been fixed?
[1]: https://lore.kernel.org/stable/202304081615.eiaqpbV8-lkp@intel.com/
[2]: https://lore.kernel.org/stable/202304082051.Dp50upfS-lkp@intel.com/
Thanks.
--
An old man doll... just what I always wanted! - Clara
next prev parent reply other threads:[~2023-04-09 12:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-08 5:22 [PATCH] ring-buffer: Prevent inconsistent operation on cpu_buffer->resize_disabled Tze-nan Wu
2023-04-08 8:35 ` kernel test robot
2023-04-08 12:20 ` kernel test robot
2023-04-09 2:46 ` [PATCH v2] " Tze-nan Wu
2023-04-09 12:30 ` Bagas Sanjaya [this message]
2023-04-10 1:35 ` Tze-nan Wu (吳澤南)
2023-04-10 7:35 ` [PATCH v3] " Tze-nan Wu
2023-04-11 16:44 ` Steven Rostedt
2023-04-11 16:48 ` Steven Rostedt
2023-04-12 2:27 ` Tze-nan Wu (吳澤南)
2023-04-12 2:32 ` Steven Rostedt
2023-04-14 1:16 ` Tze-nan Wu (吳澤南)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b05d80ab-fd72-1346-f5d9-b80ae9b5cd1a@gmail.com \
--to=bagasdotme@gmail.com \
--cc=Tze-nan.Wu@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bobule.chang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).