From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70A9D4A11 for ; Tue, 4 Jun 2024 15:57:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717516673; cv=none; b=GGXnpXx/Qf23F7Qa53nfxG8SWruwWc7QAeO0Zn4Jlk8b3MqqyVHKPM+iOzOVu7WIUTPux8tXiHytgmRl4ixFEjEI0mOxvQQIVZuz50uzQBmggG+VJdhob6volAt4F6SLejnA2wIKW5W2GnsFONjnkUSlGXIl4i8MJwfm1bI8Bj8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717516673; c=relaxed/simple; bh=vhZYleApZN8kWLF7LONqg/TsuUedJgn2Sb+eQ5I6y7Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ey809fdFdVj1alKyIDNeF1mz31+e1gMubdr6refQx9kTlsh3rgYJ8xoHwVMgLK+ubdxZ2rGp5iDhAPZocjd3n4ohTygmtKp+5xcmI2AO4hGNDXHIODX9nQQRvxDYh30Lu0uYtEYRTGIErUrXktZitoEIWIRtfW9Mv8ed9IhVvC4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=IKbbDg05; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IKbbDg05" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717516671; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iY8Smgr4TinEDzI3seLjT/wKu7RCmTGwq48l1prhDuY=; b=IKbbDg05aeYlzeVyOGR5sTiEYHoKFphtl8FkuRmTU4qDy53FrBOKrOBiSmf2M6PeC3vWzG VpqeMKHxlUGZH5LnRLIOELPPacrtrvWziz+cjNbytBkrdBq6Ui5lXaoPJi6lXAzHBa3BJF 7YGEnwK9PrSZvb8ISJxiGyeN3rYmPW0= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-335-TsCE4RD2PBaCbN33pNukkQ-1; Tue, 04 Jun 2024 11:57:50 -0400 X-MC-Unique: TsCE4RD2PBaCbN33pNukkQ-1 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-a68f5c5f31eso128343666b.0 for ; Tue, 04 Jun 2024 08:57:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717516669; x=1718121469; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iY8Smgr4TinEDzI3seLjT/wKu7RCmTGwq48l1prhDuY=; b=jvdXyF+X7dy6SeSxEAz7RRZtTy83Xf9BgJNrEsxQdHlzNXYRZtBCFH/xYJHzAo7/zW sNNwBYybcxTfSJza/d+vR032vA7ORcBSK+5sJWab02ibSCfBDZxHpOYp0SIFaEZXfQL5 wb4t1fDm20Yra4gnRRL6Bxq3TkgEiJq/IEOkn58x4i9TGDLjG9hkCELClAyAYcM6hShQ sTcsnQCIuyNmeOTMvZNoPBmsQUGMYntG+A6R37MxavL5xR11jaEH3KNR8iQujjHd5VuF t6lDDimZUeBzmQo8WXXeM6HQLv8HtdqjTPuTgQTKTQXgMB0MjTLjPhoOglnvxeGETRLg yP5A== X-Forwarded-Encrypted: i=1; AJvYcCXv3aZbCBaCvdQf1dbxnhrRBb9PXDHTfJZO5EJSbGFcWYHOesmYY7NTprMpL8NKKSVRvfMzmNF5sz2NevfkYJE59f47k4Zeq9YNRVH9wCm0qa4/ X-Gm-Message-State: AOJu0YwhnIGx3j1KWAtl10HxJ92o9N8nBeNl12DL6cehEEo4kkHXCksT xqLPYYDQDtwoPAh1OgJMr02mhI2JmmVKEGE2gGvCDpZ4qFar/2C3lkjl4ym/QO/lFinNNNI2EOR cJmOOV/SEIilc0R8Y+QCERbbSD7M3ZfiqRYKAUTZU/4Y3y8AgBi5rEnLEoIFgTxuiXG86xw== X-Received: by 2002:a50:d65d:0:b0:578:64b9:d02e with SMTP id 4fb4d7f45d1cf-57a8bcd7c9emr10601a12.40.1717516668757; Tue, 04 Jun 2024 08:57:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHZ80kTYg345fHCJuh2+pANonRw+zjSWqYbitUEjpOBdxl6OvwCwCuHkL4bn4QKZ8cVZwCvRA== X-Received: by 2002:a50:d65d:0:b0:578:64b9:d02e with SMTP id 4fb4d7f45d1cf-57a8bcd7c9emr10582a12.40.1717516668361; Tue, 04 Jun 2024 08:57:48 -0700 (PDT) Received: from [192.168.0.161] (host-87-11-37-195.retail.telecomitalia.it. [87.11.37.195]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57a86a6a5d3sm898050a12.65.2024.06.04.08.57.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jun 2024 08:57:47 -0700 (PDT) Message-ID: Date: Tue, 4 Jun 2024 17:57:46 +0200 Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/2] sched/rt: Clean up usage of rt_task() To: Qais Yousef , Ingo Molnar , Peter Zijlstra , Juri Lelli , Steven Rostedt Cc: Vincent Guittot , Thomas Gleixner , Sebastian Andrzej Siewior , Alexander Viro , Christian Brauner , Andrew Morton , Jens Axboe , Metin Kaya , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, Phil Auld References: <20240604144228.1356121-1-qyousef@layalina.io> <20240604144228.1356121-2-qyousef@layalina.io> From: Daniel Bristot de Oliveira In-Reply-To: <20240604144228.1356121-2-qyousef@layalina.io> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US, pt-BR, it-IT Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/4/24 16:42, Qais Yousef wrote: > - (wakeup_rt && !dl_task(p) && !rt_task(p)) || > + (wakeup_rt && !realtime_task(p)) || I do not like bikeshedding, and no hard feelings... But rt is a shortened version of realtime, and so it is making *it less* clear that we also have DL here. I know we can always read the comments, but we can do without changes as well... I would suggest finding the plural version for realtime_task()... so we know it is not about the "rt" scheduler, but rt and dl schedulers. -- Daniel