From: Ben Hutchings <benh@debian.org>
To: John Kacur <jkacur@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>, linux-trace-kernel@vger.kernel.org
Subject: Re: tools/rtla: Fix installation from out-of-tree build
Date: Sun, 13 Oct 2024 22:34:49 +0200 [thread overview]
Message-ID: <c075dbb7639d1c835b5fdb867462d6b455626e03.camel@debian.org> (raw)
In-Reply-To: <5508e99b-f22e-ab01-61f0-4ae352e595d2@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1236 bytes --]
On Thu, 2024-10-10 at 13:39 -0400, John Kacur wrote:
>
> On Mon, 16 Sep 2024, Ben Hutchings wrote:
>
> > rtla now supports out-of-tree builds, but installation fails as it
> > still tries to install the rtla binary from the source tree. Use the
> > existing macro $(RTLA) to refer to the binary.
> >
> > Fixes: 01474dc706ca ("tools/rtla: Use tools/build makefiles to build rtla")
> > Signed-off-by: Ben Hutchings <benh@debian.org>
> > ---
> > --- a/tools/tracing/rtla/Makefile.rtla
> > +++ b/tools/tracing/rtla/Makefile.rtla
> > @@ -38,7 +38,7 @@ BINDIR := /usr/bin
> > .PHONY: install
> > install: doc_install
> > @$(MKDIR) -p $(DESTDIR)$(BINDIR)
> > - $(call QUIET_INSTALL,rtla)$(INSTALL) rtla -m 755 $(DESTDIR)$(BINDIR)
> > + $(call QUIET_INSTALL,rtla)$(INSTALL) $(RTLA) -m 755 $(DESTDIR)$(BINDIR)
> > @$(STRIP) $(DESTDIR)$(BINDIR)/rtla
> > @test ! -f $(DESTDIR)$(BINDIR)/osnoise || $(RM) $(DESTDIR)$(BINDIR)/osnoise
> > @$(LN) rtla $(DESTDIR)$(BINDIR)/osnoise
> >
>
> Is Debian using out of tree builds Ben?
[...]
In the linux package specifically, yes, we try to do all builds out-of-
tree.
Ben.
--
Ben Hutchings - Debian developer, member of kernel, installer and LTS
teams
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-10-13 21:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-15 23:31 tools/rtla: Fix installation from out-of-tree build Ben Hutchings
2024-09-16 11:35 ` Tomas Glozar
2024-10-10 17:39 ` John Kacur
2024-10-13 20:34 ` Ben Hutchings [this message]
2024-10-14 15:19 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c075dbb7639d1c835b5fdb867462d6b455626e03.camel@debian.org \
--to=benh@debian.org \
--cc=jkacur@redhat.com \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).