From: Jarkko Sakkinen <jarkko@kernel.org>
To: Roberto Sassu <roberto.sassu@huaweicloud.com>,
dhowells@redhat.com, dwmw2@infradead.org,
herbert@gondor.apana.org.au, davem@davemloft.net, ast@kernel.org,
daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev,
song@kernel.org, yhs@fb.com, john.fastabend@gmail.com,
kpsingh@kernel.org, sdf@google.com, haoluo@google.com,
jolsa@kernel.org, rostedt@goodmis.org, mhiramat@kernel.org,
mykolal@fb.com, shuah@kernel.org
Cc: linux-kernel@vger.kernel.org, keyrings@vger.kernel.org,
linux-crypto@vger.kernel.org, bpf@vger.kernel.org,
linux-trace-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org,
Roberto Sassu <roberto.sassu@huawei.com>
Subject: Re: [RFC][PATCH 3/6] verification: Introduce verify_umd_signature() and verify_umd_message_sig()
Date: Wed, 26 Apr 2023 21:27:00 +0300 [thread overview]
Message-ID: <c5bfefc4653226e24195f5c87499c3292ecc15f5.camel@kernel.org> (raw)
In-Reply-To: <3a1cb6691bd913cadccbfaccf5ff642460eeac83.camel@kernel.org>
On Wed, 2023-04-26 at 21:25 +0300, Jarkko Sakkinen wrote:
> On Wed, 2023-04-26 at 13:42 +0200, Roberto Sassu wrote:
> > On Wed, 2023-04-26 at 03:28 +0300, Jarkko Sakkinen wrote:
> > > On Tue Apr 25, 2023 at 8:35 PM EEST, Roberto Sassu wrote:
> > > > From: Roberto Sassu <roberto.sassu@huawei.com>
> > > >
> > > > Introduce verify_umd_signature() and verify_umd_message_sig(), to verify
> > > > UMD-parsed signatures from detached data. It aims to be used by kernel
> > > > subsystems wishing to verify the authenticity of system data, with
> > > > system-defined keyrings as trust anchor.
> > >
> > > UMD is not generic knowledge. It is a term coined up in this patch set
> > > so please open code it to each patch.
> >
> > Yes, Linus also commented on this:
> >
> > https://lwn.net/ml/linux-kernel/CAHk-=wihqhksXHkcjuTrYmC-vajeRcNh3s6eeoJNxS7wp77dFQ@mail.gmail.com/
> >
> > I will check if the full name is mentioned at least once. So far, it
> > seems that using umd for function names should be ok.
>
> Also: "UMD-based parser for the asymmetric key type"
>
> It is a tautology:
>
> UMD is based on parser which based on UMD.
>
> I.e. makes no sense.
>
> Everyone hates three letter acronyms so I would consider not
> inventing a new one out of the void.
>
> So the corrective step would be to rename Kconfig flags as
> USER_ASYMMETRIC_KEY_PARSER and USER_ASYMMETRIC_SIGNATURE_PARSER.
(or along the lines)
BR, Jarkko
next prev parent reply other threads:[~2023-04-26 18:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 17:35 [RFC][PATCH 0/6] KEYS: Introduce user mode key and signature parsers Roberto Sassu
2023-04-25 17:35 ` [RFC][PATCH 1/6] KEYS: asymmetric: Introduce UMD-based asymmetric key parser Roberto Sassu
2023-04-25 17:35 ` [RFC][PATCH 2/6] KEYS: asymmetric: Introduce UMD-based asymmetric key signature parser Roberto Sassu
2023-04-25 17:35 ` [RFC][PATCH 3/6] verification: Introduce verify_umd_signature() and verify_umd_message_sig() Roberto Sassu
2023-04-26 0:28 ` Jarkko Sakkinen
2023-04-26 11:42 ` Roberto Sassu
2023-04-26 18:25 ` Jarkko Sakkinen
2023-04-26 18:27 ` Jarkko Sakkinen [this message]
2023-04-25 17:35 ` [RFC][PATCH 4/6] bpf: Introduce bpf_verify_umd_signature() kfunc Roberto Sassu
2023-04-25 21:25 ` Yonghong Song
2023-04-26 11:44 ` Roberto Sassu
2023-04-25 17:35 ` [RFC][PATCH 5/6] selftests/bpf: Prepare a test for UMD-parsed signatures Roberto Sassu
2023-04-25 17:35 ` [RFC][PATCH 6/6] KEYS: asymmetric: Add UMD handler Roberto Sassu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5bfefc4653226e24195f5c87499c3292ecc15f5.camel@kernel.org \
--to=jarkko@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=haoluo@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mhiramat@kernel.org \
--cc=mykolal@fb.com \
--cc=roberto.sassu@huawei.com \
--cc=roberto.sassu@huaweicloud.com \
--cc=rostedt@goodmis.org \
--cc=sdf@google.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).