From: "Leonardo Brás" <leobras@redhat.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Yury Norov <yury.norov@gmail.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Nadav Amit <namit@vmware.com>,
Zhen Lei <thunder.leizhen@huawei.com>,
Chen Zhongjin <chenzhongjin@huawei.com>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [RFC PATCH 1/1] smp: Add tracepoints for functions called with smp_call_function*()
Date: Thu, 06 Apr 2023 05:42:13 -0300 [thread overview]
Message-ID: <cf8d18d80222c561da1865514734d92e0e2fb3d5.camel@redhat.com> (raw)
In-Reply-To: <20230406081501.pS4ZnWaK@linutronix.de>
On Thu, 2023-04-06 at 10:15 +0200, Sebastian Andrzej Siewior wrote:
> On 2023-04-06 04:57:18 [-0300], Leonardo Bras wrote:
> > When running RT workloads in isolated CPUs, many cases of deadline misses
> > are caused by remote CPU requests such as smp_call_function*().
> >
> > For those cases, having the names of those functions running around the
> > deadline miss moment could help finding a target for the next improvements.
> >
> > Add tracepoints for acquiring the funtion name & argument before entry and
> > after exitting the called function.
> >
> > Signed-off-by: Leonardo Bras <leobras@redhat.com>
>
> Check
> https://lore.kernel.org/20230307143558.294354-1-vschneid@redhat.com
>
> Sebastian
>
Hello Sebastian, thanks for the heads up!
IIUC Valentin is adding/improving tracepoints that are collected in the
requesting CPU, at the moment of scheduling the IPI, which are also useful.
But on my scenario, would be nice to actually have the information on the time
window in which the requested function is running in the requested CPU.
This would allow us to check how many and which IPIs took too much time to
complete, and caused the RT deadline to miss.
(I noticed there is an include/trace/events/ipi.h that could be used instead of
creating a new include/trace/events/smp.h, what is your opinion on this ? )
Please let me know if I am missing something.
Thank you!
Leo
next prev parent reply other threads:[~2023-04-06 8:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-06 7:57 [RFC PATCH 1/1] smp: Add tracepoints for functions called with smp_call_function*() Leonardo Bras
2023-04-06 8:15 ` Sebastian Andrzej Siewior
2023-04-06 8:42 ` Leonardo Brás [this message]
2023-04-06 13:49 ` Steven Rostedt
2023-04-19 4:04 ` Leonardo Brás
2023-04-06 9:55 ` Peter Zijlstra
2023-04-19 3:45 ` Leonardo Brás
2023-05-03 4:23 ` Leonardo Brás
2023-05-03 14:59 ` Peter Zijlstra
2023-05-03 15:53 ` Leonardo Bras Soares Passos
2023-05-04 11:59 ` Valentin Schneider
2023-05-04 13:34 ` Steven Rostedt
2023-05-04 15:01 ` Peter Zijlstra
2023-05-10 20:27 ` Leonardo Brás
2023-05-10 22:18 ` Leonardo Bras Soares Passos
2023-05-10 23:05 ` Leonardo Bras Soares Passos
2023-05-11 8:13 ` Valentin Schneider
2023-05-11 9:25 ` Leonardo Bras Soares Passos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf8d18d80222c561da1865514734d92e0e2fb3d5.camel@redhat.com \
--to=leobras@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=chenzhongjin@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mtosatti@redhat.com \
--cc=namit@vmware.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=thunder.leizhen@huawei.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).