Linux Trace Kernel
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
	woradorn.laon@gmail.com
Cc: rostedt@goodmis.org, linux-kernel@vger.kernel.org,
	linux-trace-kernel@vger.kernel.org,
	inux-trace-kernel@vger.kernel.org,
	linux-kernel-mentees@lists.linux.dev, shuah@kernel.org,
	me@brighamcampbell.com, jkoolstra@xs4all.nl,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] tracing/selftests: Fix incorrect invocation of exit_fail
Date: Tue, 13 Oct 2026 09:46:35 -0600	[thread overview]
Message-ID: <d1eba191-d4c3-4727-95c7-bd5736ebf8f9@linuxfoundation.org> (raw)
In-Reply-To: <20261012153601.6DDF11F0089B@smtp.kernel.org>

On 10/12/26 09:35, Masami Hiramatsu (Google) wrote:
> On Fri, 18 Sep 2026 13:19:13 +0700, Woradorn Laodhanadhaworn <woradorn.laon@gmail.com> wrote:
>> Replace all `exit fail` and `exit_fail;` with exit_fail to keep the
>> usage of exit_fail consistent across the ftrace selftests. This also
>> reduces warning messsege such as 'exit: Illegal number: fail'
>> in test logs.
>>
>> Signed-off-by: Woradorn Laodhanadhaworn <woradorn.laon@gmail.com>
> 
> Looks good to me.
> 
> Fixes: 2f84b39f4847 ("tracing: Update subbuffer with kilobytes not page order")
> Reviewed-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> 
> Shuah, can you pick this fix via your branch?
> 

Thank you. Will apply this patch for 7.4-rc1

thanks,
-- Shuah

      reply	other threads:[~2026-10-13 15:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-18  6:19 [PATCH] tracing/selftests: Fix incorrect invocation of exit_fail Woradorn Laodhanadhaworn
2026-10-12 15:35 ` Masami Hiramatsu
2026-10-13 15:46   ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d1eba191-d4c3-4727-95c7-bd5736ebf8f9@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=inux-trace-kernel@vger.kernel.org \
    --cc=jkoolstra@xs4all.nl \
    --cc=linux-kernel-mentees@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=me@brighamcampbell.com \
    --cc=mhiramat@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=shuah@kernel.org \
    --cc=woradorn.laon@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox