linux-trace-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Guillaume Morin <guillaume@morinfr.org>
Cc: oleg@redhat.com, linux-kernel@vger.kernel.org,
	linux-trace-kernel@vger.kernel.org, muchun.song@linux.dev
Subject: Re: [RFC][PATCH] uprobe: support for private hugetlb mappings
Date: Thu, 16 May 2024 21:52:12 +0200	[thread overview]
Message-ID: <d23deb4c-c1dc-4ba8-a1dc-27b7c49085f7@redhat.com> (raw)
In-Reply-To: <ZkZGGkxXNaF5JPQ5@bender.morinfr.org>

On 16.05.24 19:44, Guillaume Morin wrote:
> On 02 May  5:59, Guillaume Morin wrote:
>>
>> On 30 Apr 21:25, David Hildenbrand wrote:
>>>> I tried to get the hugepd stuff right but this was the first I heard
>>>> about it :-) Afaict follow_huge_pmd and friends were already DTRT
>>>
>>> I'll have to have a closer look at some details (the hugepd writability
>>> check looks a bit odd), but it's mostly what I would have expected!
>>
>> Ok in the meantime, here is the uprobe change on your current
>> uprobes_cow trying to address the comments you made in your previous
>> message. Some of them were not 100% clear to me, so it's a best effort
>> patch :-) Again lightly tested
> 
> David, have you had a chance to take a look at both patches?

Not in detail, last weeks were busy (currently traveling back home from 
LSF/MM). I'll try to find time within the next two weeks to polish my 
changes and send them out. It would be great if you could send your 
stuff based on top of that then.

(the merge window just opened on Saturday, so we have plenty of time to 
make it to the next one :) )

-- 
Cheers,

David / dhildenb


      reply	other threads:[~2024-05-16 19:52 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <ZiK50qob9yl5e0Xz@bender.morinfr.org>
     [not found] ` <b70a3d3a-ea8b-4b20-964b-b019c146945a@redhat.com>
2024-04-22 18:11   ` [RFC][PATCH] uprobe: support for private hugetlb mappings Guillaume Morin
2024-04-22 18:59     ` David Hildenbrand
2024-04-22 20:53       ` Guillaume Morin
2024-04-24 20:09         ` David Hildenbrand
2024-04-24 20:44           ` Guillaume Morin
2024-04-24 21:00             ` David Hildenbrand
2024-04-25 15:19               ` Guillaume Morin
2024-04-25 15:42                 ` David Hildenbrand
2024-04-25 19:56                 ` David Hildenbrand
2024-04-26  0:09                   ` Guillaume Morin
2024-04-26  7:19                     ` David Hildenbrand
2024-04-26 19:55                       ` Guillaume Morin
2024-04-30 15:22                         ` Guillaume Morin
2024-04-30 18:21                           ` David Hildenbrand
2024-04-30 18:58                             ` Guillaume Morin
2024-04-30 19:25                         ` David Hildenbrand
2024-05-02  3:59                           ` Guillaume Morin
2024-05-16 17:44                             ` Guillaume Morin
2024-05-16 19:52                               ` David Hildenbrand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d23deb4c-c1dc-4ba8-a1dc-27b7c49085f7@redhat.com \
    --to=david@redhat.com \
    --cc=guillaume@morinfr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=muchun.song@linux.dev \
    --cc=oleg@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).