From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03DA13A6B7E; Tue, 17 Mar 2026 10:35:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773743718; cv=none; b=A/7zF4jkTMm0R0yzvwW/xCdA1XH4okPtKUqNpuxb5Al7+S9u6YTJBhv19F9VSf5uwE+I8jq35NXmVCU8Dfo+Z7YocjwfhgY0cBf6rB4Q8KsjRsMXn4ZzPjOdElOCKUNIzPGs/6obNJ8MT+2SFEdorJvSisBU1rwyo/URck5WP2Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773743718; c=relaxed/simple; bh=4/IkLFplsBX9CDR3n4uqSrG68fmITpAJIJjqY1jWYAw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=N1Y5Ms4R9m8oxcBZRoA0q3TDYCZIUXo3fllnDvAeu7dSdwOAcFVMp//mMb5wi62i6K3eAWjByMu6XkQWIpxGUQbAuu7hZQhMWr8IH+MYYi/xsZaSrrQxSfQ6EABhmQRUt9p3jiHseIOkB7AkXmsn9BEF1XskqkL9se/HknCtzu8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=he5PaZ07; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="he5PaZ07" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B7E2C4CEF7; Tue, 17 Mar 2026 10:35:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773743717; bh=4/IkLFplsBX9CDR3n4uqSrG68fmITpAJIJjqY1jWYAw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=he5PaZ07HRCwRWE/JnlN46TWcmHXX4ILtqREpatB3T4GYFmyb7xNp7uPoULGSnk7W z+fvFm1bnGQkyNDFrcRVg4l00WSKcs2EZyY075PDyHOrmpoNBMriA+32okeiO4lH7E DQaVTDevzhguejSzg664RGljnqCE2TdEBfYszjvJ9SOLTXH/H8qLyX6ID+fR+tNCVv XdUrAOuH1OmleoJiDJ/uWUqkXggoQbYZpi74O6pH0I/7hA1AfPaiU7SAMzl2QtqP0y i7f49BVjIjsWNt4CyMu0B68gahsDbMbCg8fDK0H0Mht097ntEIBIajMAInC8B+aua7 trm99hxAtZoKQ== Date: Tue, 17 Mar 2026 10:35:15 +0000 From: "Lorenzo Stoakes (Oracle)" To: Nico Pache Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, aarcange@redhat.com, akpm@linux-foundation.org, anshuman.khandual@arm.com, apopple@nvidia.com, baohua@kernel.org, baolin.wang@linux.alibaba.com, byungchul@sk.com, catalin.marinas@arm.com, cl@gentwo.org, corbet@lwn.net, dave.hansen@linux.intel.com, david@kernel.org, dev.jain@arm.com, gourry@gourry.net, hannes@cmpxchg.org, hughd@google.com, jack@suse.cz, jackmanb@google.com, jannh@google.com, jglisse@google.com, joshua.hahnjy@gmail.com, kas@kernel.org, lance.yang@linux.dev, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, mathieu.desnoyers@efficios.com, matthew.brost@intel.com, mhiramat@kernel.org, mhocko@suse.com, peterx@redhat.com, pfalcato@suse.de, rakie.kim@sk.com, raquini@redhat.com, rdunlap@infradead.org, richard.weiyang@gmail.com, rientjes@google.com, rostedt@goodmis.org, rppt@kernel.org, ryan.roberts@arm.com, shivankg@amd.com, sunnanyong@huawei.com, surenb@google.com, thomas.hellstrom@linux.intel.com, tiwai@suse.de, usamaarif642@gmail.com, vbabka@suse.cz, vishal.moola@gmail.com, wangkefeng.wang@huawei.com, will@kernel.org, willy@infradead.org, yang@os.amperecomputing.com, ying.huang@linux.alibaba.com, ziy@nvidia.com, zokeefe@google.com Subject: Re: [PATCH mm-unstable v15 11/13] mm/khugepaged: avoid unnecessary mTHP collapse attempts Message-ID: References: <20260226031741.230674-1-npache@redhat.com> <20260226032631.234234-1-npache@redhat.com> Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260226032631.234234-1-npache@redhat.com> On Wed, Feb 25, 2026 at 08:26:31PM -0700, Nico Pache wrote: > There are cases where, if an attempted collapse fails, all subsequent > orders are guaranteed to also fail. Avoid these collapse attempts by > bailing out early. > > Signed-off-by: Nico Pache With David's concern addressed: Reviewed-by: Lorenzo Stoakes (Oracle) > --- > mm/khugepaged.c | 35 ++++++++++++++++++++++++++++++++++- > 1 file changed, 34 insertions(+), 1 deletion(-) > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index 1c3711ed4513..388d3f2537e2 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -1492,9 +1492,42 @@ static int mthp_collapse(struct mm_struct *mm, unsigned long address, > ret = collapse_huge_page(mm, collapse_address, referenced, > unmapped, cc, mmap_locked, > order); > - if (ret == SCAN_SUCCEED) { > + > + switch (ret) { > + /* Cases were we continue to next collapse candidate */ > + case SCAN_SUCCEED: > collapsed += nr_pte_entries; > + fallthrough; > + case SCAN_PTE_MAPPED_HUGEPAGE: > continue; > + /* Cases were lower orders might still succeed */ > + case SCAN_LACK_REFERENCED_PAGE: > + case SCAN_EXCEED_NONE_PTE: > + case SCAN_EXCEED_SWAP_PTE: > + case SCAN_EXCEED_SHARED_PTE: > + case SCAN_PAGE_LOCK: > + case SCAN_PAGE_COUNT: > + case SCAN_PAGE_LRU: > + case SCAN_PAGE_NULL: > + case SCAN_DEL_PAGE_LRU: > + case SCAN_PTE_NON_PRESENT: > + case SCAN_PTE_UFFD_WP: > + case SCAN_ALLOC_HUGE_PAGE_FAIL: > + goto next_order; > + /* Cases were no further collapse is possible */ > + case SCAN_CGROUP_CHARGE_FAIL: > + case SCAN_COPY_MC: > + case SCAN_ADDRESS_RANGE: > + case SCAN_NO_PTE_TABLE: > + case SCAN_ANY_PROCESS: > + case SCAN_VMA_NULL: > + case SCAN_VMA_CHECK: > + case SCAN_SCAN_ABORT: > + case SCAN_PAGE_ANON: > + case SCAN_PMD_MAPPED: > + case SCAN_FAIL: > + default: Agree with david, let's spell them out please :) > + return collapsed; > } > } > > -- > 2.53.0 >