From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DE341CD2B for ; Thu, 5 Dec 2024 16:06:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733414807; cv=none; b=hht/SNZd2u8sHiYsHRAYFrDfWQxe8+CnjmnXu8XRkQSfRIrSqUG8CC/W3xpgLb7BAdXdyNuX45jOSLERGwTZ6L41KomP0siEl7fabvL5zw8HrI0ANF5/jji9WD42ilcFw7gZn2zSDkp30CEEp8Mg6L38jx0ZLma0tTirQf92JVg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733414807; c=relaxed/simple; bh=A2DnTOze90pmj6g5vc3azSV/Ln9IgzLkSP0Xv7QklXw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=T9QO1IQNN26R4RbpA0dXRvMbygbJJxefzSgqBu/6V0Q33Ksc75wwGZBDpLnPamhdtJ6OIQFN+4cBxgiIK7F53ojOlRvdzyNUwo2peliQC9p73b6P+P7M//yFxFQdOLxC/8OKMesWIXv3gXPKZEvmOdU+hOpw3vUxjKSDIt9PXDE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=NK4OrzcX; arc=none smtp.client-ip=209.85.166.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="NK4OrzcX" Received: by mail-io1-f52.google.com with SMTP id ca18e2360f4ac-84194e90c0fso65763839f.2 for ; Thu, 05 Dec 2024 08:06:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1733414804; x=1734019604; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=G7E/0K/5K1BjOut5mLlzCa+24O07aK8RA1Bdk2pEJFM=; b=NK4OrzcXhegQ2guYPm8vkhfQ6ZnqrEEGeafEDW0Hy5rqNhvnm4ENDTIF9HkKheblf5 apjMe7CkhN4zFNg6BNlV1ACwu+vcqFMlThTNSlpN85rKe6R8q6232ni6jciOfFK6Vytt Dee7afaB97MHYXC3qJkTlgg74pkp0rKZ9DIRA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733414804; x=1734019604; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=G7E/0K/5K1BjOut5mLlzCa+24O07aK8RA1Bdk2pEJFM=; b=nyZCNDg1FE6QDdADZRKXBbbuaHMO4z+mIxQDmUmAnP6QNJLWdkrowXwUtFhApu+QqT vKuZqi81mAOIxT1dVJuF5GLgzmj2R0/MUemftfo9LeQLf+/gwFepPWhE+zc80+3Wdirv UIGfHFMfW4vTIM1hgmFWc/jstTLvf7nSSvMEigNLppZsAcMiTZSVPlGIKCe+ssd6X4N/ 4df6FF1foMv1dkk6KkgQSyMac3j18GPrVas/w2VK08n9Z2rnscev/+fAzs+8Hfu1/WAl PsZA0NFo3rb7XluEoN7S2CC1M67WAfKQ6IgFXJ6tqsYYzfNtwN4zxyEw22TpaSYdDHpS pkkQ== X-Forwarded-Encrypted: i=1; AJvYcCW51/qVzl7DH/dz84cg+hxCqb00j3Ozyz5iXGzz7653ADaYumRglhGfsw3+pWw2SRMfSO88Zc71H3pbhek2alUK9l4=@vger.kernel.org X-Gm-Message-State: AOJu0YwV78J+cX0iSCzZsZP7AkAf6LFnuEc+gMsgHDJ2T9PqnjDV6Jvb Ec7EDxqfmPUdUf2QzkDJPENoAgC+90Yfkf2AH/eRavCmXsvI7jQUGxoeP3Pza0w= X-Gm-Gg: ASbGncsI2KZ+M8Xnfhcl/0z9b9iB3vT+soXpZNW0785dqpa8uRn+DIciakLfypW2CJi qnEaxJ1kRBjHQr0RowzMGBym1fr85xB/m9uicNheLVxd8tGA2v24e/2dTSlVBzEW5OdeUwFa1Rr b3F/hBBtsrlnwQ17pwFukFwVu5322x5uf4AnomWCucWXQ0C5nfCeO8rYsCpHHsqjfDSctu2IvvM afdCACAHhL3wle9MdYyxQrFSW0v+7D6+B+ELp2uuYw2lUzmICvwtVJkLw5jqQ== X-Google-Smtp-Source: AGHT+IECQoo3AU1H3Cux4NWyUqkEkqx386V5pN6kVl0r6Wn3PSuY9bnBffRQmWJX+QbbsEJHmnHHEA== X-Received: by 2002:a92:c56a:0:b0:3a7:dfe4:bd33 with SMTP id e9e14a558f8ab-3a7fecc82b3mr114487405ab.6.1733414804406; Thu, 05 Dec 2024 08:06:44 -0800 (PST) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4e286224210sm337614173.161.2024.12.05.08.06.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Dec 2024 08:06:43 -0800 (PST) Message-ID: Date: Thu, 5 Dec 2024 09:06:43 -0700 Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] selftests/ftrace: adjust offset for kprobe syntax error test To: Steven Rostedt Cc: Hari Bathini , Shuah Khan , linux-kselftest@vger.kernel.org, Masami Hiramatsu , Michael Ellerman , Madhavan Srinivasan , "Naveen N. Rao" , linuxppc-dev , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20241129202621.721159-1-hbathini@linux.ibm.com> <20241202144111.75d1bb3b@gandalf.local.home> <20241203202008.1f30a266@gandalf.local.home> Content-Language: en-US From: Shuah Khan In-Reply-To: <20241203202008.1f30a266@gandalf.local.home> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/3/24 18:20, Steven Rostedt wrote: > On Tue, 3 Dec 2024 18:01:06 -0700 > Shuah Khan wrote: > >> On 12/2/24 12:41, Steven Rostedt wrote: >>> On Sat, 30 Nov 2024 01:56:21 +0530 >>> Hari Bathini wrote: >>> >>>> In 'NOFENTRY_ARGS' test case for syntax check, any offset X of >>>> `vfs_read+X` except function entry offset (0) fits the criterion, >>>> even if that offset is not at instruction boundary, as the parser >>>> comes before probing. But with "ENDBR64" instruction on x86, offset >>>> 4 is treated as function entry. So, X can't be 4 as well. Thus, 8 >>>> was used as offset for the test case. On 64-bit powerpc though, any >>>> offset <= 16 can be considered function entry depending on build >>>> configuration (see arch_kprobe_on_func_entry() for implementation >>>> details). So, use `vfs_read+20` to accommodate that scenario too. >>>> >>>> Suggested-by: Masami Hiramatsu >>>> Signed-off-by: Hari Bathini >>> >>> Acked-by: Steven Rostedt (Google) >>> >>> Shuah, >>> >>> Can you take this through your tree? >> >> Yes I can take it. I do have question about whether this is >> a fix - sounds like it is from the change log. >> >> Clearly stating that it is a fix will help so it can be picked >> up for stables. > > I would say it's a fix, as the test currently fails in certain scenarios > for powerpc. > > You can add: > > Fixes: 4231f30fcc34a ("selftests/ftrace: Add BTF arguments test cases") > I applied this to linux-kselftest fixes - will send it up for rc2 or rc3 thanks, -- Shuah