From: Shuah Khan <skhan@linuxfoundation.org>
To: Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kselftest@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2] tracing: selftests: Add testing a user string to filters
Date: Tue, 22 Apr 2025 10:59:03 -0600 [thread overview]
Message-ID: <de2a5e52-8061-4907-bd48-0d6d28b83b75@linuxfoundation.org> (raw)
In-Reply-To: <20250418101208.38dc81f5@gandalf.local.home>
On 4/18/25 08:12, Steven Rostedt wrote:
> From: Steven Rostedt <rostedt@goodmis.org>
>
> Running the following commands was broken:
>
> # cd /sys/kernel/tracing
> # echo "filename.ustring ~ \"/proc*\"" > events/syscalls/sys_enter_openat/filter
> # echo 1 > events/syscalls/sys_enter_openat/enable
> # ls /proc/$$/maps
> # cat trace
>
> And would produce nothing when it should have produced something like:
>
> ls-1192 [007] ..... 8169.828333: sys_openat(dfd: ffffffffffffff9c, filename: 7efc18359904, flags: 80000, mode: 0)
>
> Add a test to check this case so that it will be caught if it breaks
> again.
>
> Link: https://lore.kernel.org/linux-trace-kernel/20250417183003.505835fb@gandalf.local.home/
>
> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> ---
> Changes since v1: https://lore.kernel.org/20250417223323.3edb4f6c@batman.local.home
>
> - Use $TMPDIR instead of $TESTDIR as test file (Masami Hiramatsu)
>
Steve, Masami
Do you want me to take this for rc4?
thanks,
-- Shuah
next prev parent reply other threads:[~2025-04-22 16:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 14:12 [PATCH v2] tracing: selftests: Add testing a user string to filters Steven Rostedt
2025-04-22 16:59 ` Shuah Khan [this message]
2025-04-22 18:08 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de2a5e52-8061-4907-bd48-0d6d28b83b75@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox