Linux Trace Kernel
 help / color / mirror / Atom feed
From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Sean Christopherson <seanjc@google.com>,
	Ackerley Tng <ackerleytng@google.com>
Cc: "David Hildenbrand (Arm)" <david@kernel.org>,
	aik@amd.com, andrew.jones@linux.dev, binbin.wu@linux.intel.com,
	brauner@kernel.org, chao.p.peng@linux.intel.com,
	jmattson@google.com, jthoughton@google.com, michael.roth@amd.com,
	oupton@kernel.org, pankaj.gupta@amd.com, qperret@google.com,
	rick.p.edgecombe@intel.com, rientjes@google.com,
	shivankg@amd.com, steven.price@arm.com, tabba@google.com,
	willy@infradead.org, wyihan@google.com, yan.y.zhao@intel.com,
	forkloop@google.com, pratyush@kernel.org,
	aneesh.kumar@kernel.org, liam@infradead.org,
	Paolo Bonzini <pbonzini@redhat.com>,
	Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Shuah Khan <shuah@kernel.org>,
	Vishal Annapurve <vannapurve@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Chris Li <chrisl@kernel.org>, Kairui Song <kasong@tencent.com>,
	Kemeng Shi <shikemeng@huaweicloud.com>,
	Nhat Pham <nphamcs@gmail.com>, Barry Song <baohua@kernel.org>,
	Axel Rasmussen <axelrasmussen@google.com>,
	Yuanchu Xie <yuanchu@google.com>, Wei Xu <weixugc@google.com>,
	Youngjun Park <youngjun.park@lge.com>,
	Qi Zheng <qi.zheng@linux.dev>,
	Shakeel Butt <shakeel.butt@linux.dev>,
	Kiryl Shutsemau <kas@kernel.org>,
	Baoquan He <baoquan.he@linux.dev>, Jason Gunthorpe <jgg@ziepe.ca>,
	John Hubbard <jhubbard@nvidia.com>, Peter Xu <peterx@redhat.com>,
	Vlastimil Babka <vbabka@kernel.org>,
	"hughd@google.com" <hughd@google.com>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kselftest@vger.kernel.org, linux-mm@kvack.org,
	linux-coco@lists.linux.dev
Subject: Re: [PATCH v9 14/41] mm: swap: Introduce lru_add_drain_progressive()
Date: Tue, 4 Aug 2026 22:41:32 +0100	[thread overview]
Message-ID: <de780cc3-8c43-46f8-b8e6-3ddfe93d753d@arm.com> (raw)
In-Reply-To: <anJbMf5GBe0Pxh_x@google.com>

On 04/08/2026 22:35, Sean Christopherson wrote:
> On Tue, Aug 04, 2026, Ackerley Tng wrote:
>> "David Hildenbrand (Arm)" <david@kernel.org> writes:
>>> Andrew wants to give it some more time in -next, so I'm expecting it to
>>> land for 7.3.
>>>
>>>> 7.2 or 7.3, then I would strongly prefer to base v10 on linux-next (where
>>>> the fix will presumably land soonish), and target 7.4 for in-place
>>>> conversion. Then v10 can be applied against an early 7.3-rcN and we don't
>>>> need to juggle branches (assuming Andrew is ok taking the proposed patch
>>>> through the KVM tree).
>>>
>>> Agreed. We'd also have to get the actual preparation patch into 7.3. I can
>>> send it out and coordinate with Andrew.
>>>
>>
>> Thank you!
>>
>> When we were discussing this earlier at guest_memfd biweekly, before
>> deciding to refactor out a function like lru_cache_drain_for_folio(), we
>> did say that the likelihood of actually draining in practice is low,
>> especially on a machine with heavy load making allocations all the time.
>>
>> I think the threads with Xiaoyao have resolved, I can put v10 out
>> tomorrow. Would it be okay to go with the following from v8, and then
>> clean up later when lru_cache_drain_for_folio() is available?
> 
> No.
> 
>> I'm hoping not to push this back by a full cycle to 7.4,
>   
> Sorry, but we've missed 7.3, irrespective of the lru_cache_drain_for_folio() fix.
> Even if v10 is perfect, applying tomorrow means it will get ~3 business days in
> linux-next before I send pull requests to Paolo.  That's just not enough soak
> time for land a 40+ patch series, even if half of those patches are selftests.
> 
>> and also hold back other series dependent on this one.
> 
> Eh, I don't think there will be meaningful impact in practice.  If v10 is good
> to go, I'll get it applied on 7.3-r1, and will also get an early pull request
> over to Paolo (probably around 7.3-rc4).  I.e. folks can start posting against
> the landed series shortly after rc1, and I'll have a set-in-stone base on which
> to apply more stuff around rc4/rc5.

For the record, Arm CCA KVM support depends on this series and that
being a big series (around 40+ patches), it is an inconvenience for the
Maintainers to make an effort to review the series.  That said,  we are
happy with the way this is progressing and next cycle merge for this
series would be perfect for us.


> 
> And if v10 has issues, then *not* rushing it into 7.3 will likely be the fastest
> path forward.

Absolutely !Like any work, if it is not ready to merge, it is not.

Cheers
Suzuki


  reply	other threads:[~2026-08-04 21:41 UTC|newest]

Thread overview: 82+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-29  0:34 [PATCH v9 00/41] guest_memfd: In-place conversion support Ackerley Tng via B4 Relay
2026-07-29  0:35 ` [PATCH v9 01/41] KVM: guest_memfd: Introduce per-gmem attributes, use to guard user mappings Ackerley Tng via B4 Relay
2026-07-31  8:57   ` Xiaoyao Li
2026-07-31 16:08     ` Sean Christopherson
2026-08-04 13:46       ` Ackerley Tng
2026-07-29  0:35 ` [PATCH v9 02/41] KVM: Rename KVM_GENERIC_MEMORY_ATTRIBUTES to KVM_VM_MEMORY_ATTRIBUTES Ackerley Tng via B4 Relay
2026-07-29  0:35 ` [PATCH v9 03/41] KVM: Enumerate support for PRIVATE memory iff kvm_arch_has_private_mem is defined Ackerley Tng via B4 Relay
2026-07-30  9:57   ` Xiaoyao Li
2026-07-30 20:34     ` Ackerley Tng
2026-08-05  8:51       ` Xiaoyao Li
2026-07-29  0:35 ` [PATCH v9 04/41] KVM: Rename memory attribute APIs to prepare for in-place gmem conversion Ackerley Tng via B4 Relay
2026-07-30  8:19   ` Xiaoyao Li
2026-07-29  0:35 ` [PATCH v9 05/41] KVM: Provide generic interface for checking memory private/shared status Ackerley Tng via B4 Relay
2026-07-29  0:35 ` [PATCH v9 06/41] KVM: guest_memfd: Introduce function to check GFN " Ackerley Tng via B4 Relay
2026-07-29  0:35 ` [PATCH v9 07/41] KVM: guest_memfd: Wire up core private/shared attribute interfaces Ackerley Tng via B4 Relay
2026-07-30 11:05   ` Xiaoyao Li
2026-07-30 20:42     ` Ackerley Tng
2026-07-30 23:49       ` Xiaoyao Li
2026-07-31 16:26         ` Sean Christopherson
2026-08-03  2:43           ` Xiaoyao Li
2026-08-03 15:33             ` Sean Christopherson
2026-08-04  2:11               ` Xiaoyao Li
2026-07-29  0:35 ` [PATCH v9 08/41] KVM: Consolidate private memory and guest_memfd ifdeffery in kvm_host.h Ackerley Tng via B4 Relay
2026-07-29  0:35 ` [PATCH v9 09/41] KVM: guest_memfd: Filter both shared and private when invalidating Ackerley Tng via B4 Relay
2026-07-29  0:35 ` [PATCH v9 10/41] KVM: guest_memfd: Add base support for KVM_SET_MEMORY_ATTRIBUTES2 Ackerley Tng via B4 Relay
2026-07-30 22:22   ` Ackerley Tng
2026-07-30 22:26   ` Ackerley Tng
2026-08-03 15:53   ` Suzuki K Poulose
2026-07-29  0:35 ` [PATCH v9 11/41] KVM: guest_memfd: Ensure pages are not in use before conversion Ackerley Tng via B4 Relay
2026-07-29  0:35 ` [PATCH v9 12/41] KVM: guest_memfd: Call arch make_shared callback for to-shared conversion Ackerley Tng via B4 Relay
2026-07-30 10:35   ` Fuad Tabba
2026-07-29  0:35 ` [PATCH v9 13/41] KVM: guest_memfd: Return early if range already has requested attributes Ackerley Tng via B4 Relay
2026-07-30 22:31   ` Ackerley Tng
2026-07-29  0:35 ` [PATCH v9 14/41] mm: swap: Introduce lru_add_drain_progressive() Ackerley Tng via B4 Relay
2026-07-30 10:21   ` David Hildenbrand (Arm)
2026-07-30 22:20     ` Ackerley Tng
2026-07-31 10:22       ` David Hildenbrand (Arm)
2026-07-31 11:59         ` David Hildenbrand (Arm)
2026-07-31 13:03           ` Ackerley Tng
2026-07-31 14:09             ` David Hildenbrand (Arm)
2026-07-31 21:04               ` David Hildenbrand (Arm)
2026-08-03 15:03                 ` Sean Christopherson
2026-08-03 15:12                   ` David Hildenbrand (Arm)
2026-08-04 15:26                     ` Ackerley Tng
2026-08-04 21:35                       ` Sean Christopherson
2026-08-04 21:41                         ` Suzuki K Poulose [this message]
2026-08-04 22:20                           ` Ackerley Tng
2026-08-04 23:15                             ` Sean Christopherson
2026-07-29  0:35 ` [PATCH v9 15/41] KVM: guest_memfd: Handle lru_add fbatch refcounts during conversion safety check Ackerley Tng via B4 Relay
2026-07-29  0:35 ` [PATCH v9 16/41] KVM: guest_memfd: Zero page while getting pfn Ackerley Tng via B4 Relay
2026-07-31  8:49   ` Xiaoyao Li
2026-07-29  0:35 ` [PATCH v9 17/41] KVM: SEV: Make 'uaddr' parameter optional for KVM_SEV_SNP_LAUNCH_UPDATE Ackerley Tng via B4 Relay
2026-07-29  0:35 ` [PATCH v9 18/41] KVM: TDX: Make source page optional for KVM_TDX_INIT_MEM_REGION Ackerley Tng via B4 Relay
2026-07-31  8:26   ` Xiaoyao Li
2026-07-31 16:11     ` Sean Christopherson
2026-08-04  2:21       ` Xiaoyao Li
2026-07-29  0:35 ` [PATCH v9 19/41] KVM: Move KVM_VM_MEMORY_ATTRIBUTES config definition to x86 Ackerley Tng via B4 Relay
2026-07-29  0:35 ` [PATCH v9 20/41] KVM: Let userspace disable per-VM mem attributes, enable per-gmem attributes Ackerley Tng via B4 Relay
2026-07-31  8:48   ` Xiaoyao Li
2026-08-04 15:39     ` Ackerley Tng
2026-08-04 21:26       ` Sean Christopherson
2026-07-29  0:35 ` [PATCH v9 21/41] KVM: guest_memfd: Enable INIT_SHARED on guest_memfd for x86 Coco VMs Ackerley Tng via B4 Relay
2026-07-29  0:35 ` [PATCH v9 22/41] KVM: selftests: Create gmem fd before "regular" fd when adding memslot Ackerley Tng via B4 Relay
2026-07-29  0:35 ` [PATCH v9 23/41] KVM: selftests: Rename guest_memfd{,_offset} to gmem_{fd,offset} Ackerley Tng via B4 Relay
2026-07-29  0:35 ` [PATCH v9 24/41] KVM: selftests: Add support for mmap() on guest_memfd in core library Ackerley Tng via B4 Relay
2026-07-29  0:35 ` [PATCH v9 25/41] KVM: selftests: Add selftests global for guest memory attributes capability Ackerley Tng via B4 Relay
2026-07-29  0:35 ` [PATCH v9 26/41] KVM: selftests: Add helpers for calling ioctls on guest_memfd Ackerley Tng via B4 Relay
2026-07-29  0:35 ` [PATCH v9 27/41] KVM: selftests: Test basic single-page conversion flow Ackerley Tng via B4 Relay
2026-07-29  0:35 ` [PATCH v9 28/41] KVM: selftests: Test conversion flow when INIT_SHARED Ackerley Tng via B4 Relay
2026-07-29  0:35 ` [PATCH v9 29/41] KVM: selftests: Test conversion precision in guest_memfd Ackerley Tng via B4 Relay
2026-07-29  0:35 ` [PATCH v9 30/41] KVM: selftests: Test conversion before allocation Ackerley Tng via B4 Relay
2026-07-29  0:35 ` [PATCH v9 31/41] KVM: selftests: Convert with allocated folios in different layouts Ackerley Tng via B4 Relay
2026-07-29  0:35 ` [PATCH v9 32/41] KVM: selftests: Test that truncation does not change shared/private status Ackerley Tng via B4 Relay
2026-07-29  0:35 ` [PATCH v9 33/41] KVM: selftests: Test that shared/private status is consistent across processes Ackerley Tng via B4 Relay
2026-07-29  0:35 ` [PATCH v9 34/41] KVM: selftests: Add helpers to pin pages with CONFIG_GUP_TEST Ackerley Tng via B4 Relay
2026-07-29  0:35 ` [PATCH v9 35/41] KVM: selftests: Test conversion with elevated page refcount Ackerley Tng via B4 Relay
2026-07-29  0:35 ` [PATCH v9 36/41] KVM: selftests: Reset shared memory after hole-punching Ackerley Tng via B4 Relay
2026-07-29  0:35 ` [PATCH v9 37/41] KVM: selftests: Provide function to look up guest_memfd details from gpa Ackerley Tng via B4 Relay
2026-07-29  0:35 ` [PATCH v9 38/41] KVM: selftests: Provide common function to set memory attributes Ackerley Tng via B4 Relay
2026-07-29  0:35 ` [PATCH v9 39/41] KVM: selftests: Make TEST_EXPECT_SIGBUS thread-safe Ackerley Tng via B4 Relay
2026-07-29  0:35 ` [PATCH v9 40/41] KVM: selftests: Update private_mem_conversions_test to mmap() guest_memfd Ackerley Tng via B4 Relay
2026-07-29  0:35 ` [PATCH v9 41/41] KVM: selftests: Update private memory exits test to work with per-gmem attributes Ackerley Tng via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de780cc3-8c43-46f8-b8e6-3ddfe93d753d@arm.com \
    --to=suzuki.poulose@arm.com \
    --cc=ackerleytng@google.com \
    --cc=aik@amd.com \
    --cc=akpm@linux-foundation.org \
    --cc=andrew.jones@linux.dev \
    --cc=aneesh.kumar@kernel.org \
    --cc=axelrasmussen@google.com \
    --cc=baohua@kernel.org \
    --cc=baoquan.he@linux.dev \
    --cc=binbin.wu@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=brauner@kernel.org \
    --cc=chao.p.peng@linux.intel.com \
    --cc=chrisl@kernel.org \
    --cc=corbet@lwn.net \
    --cc=dave.hansen@linux.intel.com \
    --cc=david@kernel.org \
    --cc=forkloop@google.com \
    --cc=hpa@zytor.com \
    --cc=hughd@google.com \
    --cc=jgg@ziepe.ca \
    --cc=jhubbard@nvidia.com \
    --cc=jmattson@google.com \
    --cc=jthoughton@google.com \
    --cc=kas@kernel.org \
    --cc=kasong@tencent.com \
    --cc=kvm@vger.kernel.org \
    --cc=liam@infradead.org \
    --cc=linux-coco@lists.linux.dev \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=michael.roth@amd.com \
    --cc=mingo@redhat.com \
    --cc=nphamcs@gmail.com \
    --cc=oupton@kernel.org \
    --cc=pankaj.gupta@amd.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=pratyush@kernel.org \
    --cc=qi.zheng@linux.dev \
    --cc=qperret@google.com \
    --cc=rick.p.edgecombe@intel.com \
    --cc=rientjes@google.com \
    --cc=rostedt@goodmis.org \
    --cc=seanjc@google.com \
    --cc=shakeel.butt@linux.dev \
    --cc=shikemeng@huaweicloud.com \
    --cc=shivankg@amd.com \
    --cc=shuah@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=steven.price@arm.com \
    --cc=tabba@google.com \
    --cc=tglx@kernel.org \
    --cc=vannapurve@google.com \
    --cc=vbabka@kernel.org \
    --cc=weixugc@google.com \
    --cc=willy@infradead.org \
    --cc=wyihan@google.com \
    --cc=x86@kernel.org \
    --cc=yan.y.zhao@intel.com \
    --cc=youngjun.park@lge.com \
    --cc=yuanchu@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox