Re: [PATCH blktrace v2 05/22] blktrace: add definitions for blk_io_trace2

[Damien Le Moal <dlemoal@kernel.org>]

On 9/26/25 00:04, Johannes Thumshirn wrote:
> Add 'struct blk_io_trace2' which represents the extended version of the
> blktrace protocol.
> 
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> ---
>  blktrace_api.h | 35 +++++++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
> 
> diff --git a/blktrace_api.h b/blktrace_api.h
> index 9f435a5..bbf075f 100644
> --- a/blktrace_api.h
> +++ b/blktrace_api.h
> @@ -27,8 +27,19 @@ enum {
>  	BLK_TC_END	= 1 << 15,	/* we've run out of bits! */
>  };
>  
> +enum blktrace_cat2 {
> +	BLK_TC_ZONE_APPEND      = 1 << 1ull,    /* zone append */

Kernel side starts this at 1ULL << 16. SO I think you are out of sync with the
kernel side with these user patches...


> +	BLK_TC_ZONE_RESET       = 1 << 2ull,    /* zone reset */
> +	BLK_TC_ZONE_RESET_ALL   = 1 << 3ull,    /* zone reset all */
> +	BLK_TC_ZONE_FINISH      = 1 << 4ull,    /* zone finish */
> +	BLK_TC_ZONE_OPEN        = 1 << 5ull,    /* zone open */
> +	BLK_TC_ZONE_CLOSE       = 1 << 6ull,    /* zone close */
> +};

-- 
Damien Le Moal
Western Digital Research