Re: [PATCH v1] tools/rtla: Fix --dump-task option name to --dump-tasks

Crystal Wood
2026-04-14T18:07:17Z

On Tue, 2026-04-14 at 17:06 +0300, Costa Shulyupin wrote:
> The option was inconsistently named --dump-task in the usage
> string and getopt_long table while the actual implementation
> uses --dump-tasks. Fix both occurrences to match.

How is the getopt_long table not the "actual implementation"?

Wouldn't it make more sense to fix the one place in the documentation
that says --dump-tasks to match what the current behavior is?

...except that apparently timerlat top does use --dump-tasks[1], so
maybe we want to make that consistent, but the changelog should be clear
that this is an interface change for timerlat hist.

We should also probably be making sure we have test coverage for both
hist and top, which would have caught this, rather than picking one or
the other for most tests.

-Crystal

[1] Oddly, timerlat_top.c is missing --dump-tasks from msg_start[],
which is the one place that timerlat_hist.c has the plural --dump-tasks.