Re: [PATCH v4] tracing: Support to dump instance traces by ftrace_dump_on_oops

[Huang Yiwei <quic_hyiwei@quicinc.com>]

On 2/7/2024 10:13 PM, Joel Fernandes wrote:
> On Wed, Feb 7, 2024 at 6:14 AM Steven Rostedt <rostedt@goodmis.org> wrote:
>>
>> On Wed, 7 Feb 2024 05:24:58 -0500
>> Joel Fernandes <joel@joelfernandes.org> wrote:
>>
>>> Btw, hopefully the "trace off on warning" and related boot parameters also apply
>>> to instances, I haven't personally checked but I often couple those with the
>>> dump-on-oops ones.
>>
>> Currently they do not. It would require an updated interface to do so,
>> as sometimes instances can be used to continue tracing after a warning,
>> so I don't want to make it for all instances.
> 
> Thanks for clarifying.
> 
>> Perhaps we need an option for these too, and have all options be
>> updated via the command line. That way we don't need to make special
>> boot line parameters for this. If we move these to options (keeping the
>> proc interface for backward compatibility) it would make most features
>> available to all with one change.
It's a good idea that "traceoff_on_warning" also has instance support, 
but we will use another patchset to do this, right?

And for this patchset, shall I fix the typo and resend again? Thanks.
> 
> Agreed, that would be nice!!
> 
>   - Joel
Regards,
Huang Yiwei