From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout.efficios.com (smtpout.efficios.com [167.114.26.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D00F4D512; Fri, 4 Oct 2024 00:17:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=167.114.26.122 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728001049; cv=none; b=egzb3s1DHKBGcmT1n0VWSrhV+OUtE1sRaQ7ZWqtut1DgmevBbJX0NzjS3YipjKVUv8iartH4PDozFe3eTIGzEd5Twz3z52QCs2aHsCGqXcN8O37cILj1ZlnYQidxVBDAWJW5eugXn0Mwe87KkQhgJ2TQK7SbAf8JVicyBaeDx2A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728001049; c=relaxed/simple; bh=jmW2HGBbFkE17QqfiLtrCSeJqp5SHid1v0vpQMeMyRA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TmhEuZztt2ekLRSU9eETqEGys57z6j3VX2xHAyvUD/pPX6qeCVtxhyPd+CSTo/0G+wat+/2HpyxExoOo1xWlQzL4XNhNcKSyHDnvoZ6Hb9nV6V2GsrfP5YWM/AokjwYBO88V+RniMOXrgkWvJvK0O5nAUwcRI9Q+BObWTegxh7g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com; spf=pass smtp.mailfrom=efficios.com; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b=SVGmsUoB; arc=none smtp.client-ip=167.114.26.122 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=efficios.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b="SVGmsUoB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com; s=smtpout1; t=1728001046; bh=jmW2HGBbFkE17QqfiLtrCSeJqp5SHid1v0vpQMeMyRA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=SVGmsUoBaJPKqwAbYfRtcjNt6EwoNCPYa40wX5c85IoTO4xit15QX7fPTwISPbk6z 8s0XZGHRHpHlZH/F9kga9rKXO0fTYUyvTKbCtAzC4q3Cp5fLuKp4PgiZW/BIM5WfQN q9wKRZzy6rZzTfrLNdrGjMXf9eT+7RfujTejPGlitRxWcWIx7pvhiudcabStjhK6rd skX154L2SlHMyUeGbM2fQsOq8EkHoWsVKOrlQ/mbgIspalNXh2IeV9bjdkQG8LL0bx 0/W72vOCsyj5u6R3bF59QFuBD5//TQtmm3eE9yr07jU30E/9Namq1Pywb30vKOprWt nhBxh0YJlNAnw== Received: from [IPV6:2606:6d00:100:4000:cacb:9855:de1f:ded2] (unknown [IPv6:2606:6d00:100:4000:cacb:9855:de1f:ded2]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4XKTdL4NR6zBcG; Thu, 3 Oct 2024 20:17:26 -0400 (EDT) Message-ID: Date: Thu, 3 Oct 2024 20:15:25 -0400 Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/8] tracing: Declare system call tracepoints with TRACE_EVENT_SYSCALL To: Steven Rostedt Cc: Masami Hiramatsu , linux-kernel@vger.kernel.org, Peter Zijlstra , Alexei Starovoitov , Yonghong Song , "Paul E . McKenney" , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Namhyung Kim , Andrii Nakryiko , bpf@vger.kernel.org, Joel Fernandes , linux-trace-kernel@vger.kernel.org, Michael Jeanson References: <20241003151638.1608537-1-mathieu.desnoyers@efficios.com> <20241003151638.1608537-2-mathieu.desnoyers@efficios.com> <20241003173225.7670a4f0@gandalf.local.home> Content-Language: en-US From: Mathieu Desnoyers In-Reply-To: <20241003173225.7670a4f0@gandalf.local.home> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2024-10-03 23:32, Steven Rostedt wrote: > On Thu, 3 Oct 2024 11:16:31 -0400 > Mathieu Desnoyers wrote: > >> @@ -283,8 +290,13 @@ static inline struct tracepoint *tracepoint_ptr_deref(tracepoint_ptr_t *p) >> "RCU not watching for tracepoint"); \ >> } \ >> } \ >> - __DECLARE_TRACE_RCU(name, PARAMS(proto), PARAMS(args), \ >> - PARAMS(cond)) \ >> + static inline void trace_##name##_rcuidle(proto) \ >> + { \ >> + if (static_key_false(&__tracepoint_##name.key)) \ >> + __DO_TRACE(name, \ >> + TP_ARGS(args), \ >> + TP_CONDITION(cond), 1); \ >> + } \ >> static inline int \ >> register_trace_##name(void (*probe)(data_proto), void *data) \ >> { \ > > Looking at this part of your change, I realized it's time to nuke the > rcuidle() variant. > > Feel free to rebase on top of this patch: > > https://lore.kernel.org/all/20241003173051.6b178bb3@gandalf.local.home/ > I will. But you realize that you could have done all this SRCU and rcuidle nuking on top of my own series rather than pull the rug under my feet and require me to re-do this series again ? Grumpily, Mathieu -- Mathieu Desnoyers EfficiOS Inc. https://www.efficios.com