From: "Naik, Avadhut" <avadnaik@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Avadhut Naik <avadhut.naik@amd.com>,
x86@kernel.org, linux-edac@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, tony.luck@intel.com,
rafael@kernel.org, tglx@linutronix.de, mingo@redhat.com,
rostedt@goodmis.org, lenb@kernel.org, mchehab@kernel.org,
james.morse@arm.com, airlied@gmail.com, yazen.ghannam@amd.com,
john.allen@amd.com
Subject: Re: [PATCH v2 4/4] EDAC/mce_amd: Add support for FRU Text in MCA
Date: Tue, 9 Jul 2024 01:29:13 -0500 [thread overview]
Message-ID: <efa65048-e176-4bad-aac8-0147d26b1362@amd.com> (raw)
In-Reply-To: <20240626182013.GEZnxb3TpU6VgROX8g@fat_crate.local>
On 6/26/2024 13:20, Borislav Petkov wrote:
> On Wed, Jun 26, 2024 at 01:00:30PM -0500, Naik, Avadhut wrote:
>>>
>>> Why are you clearing it if you're overwriting it immediately?
>>>
>> Since its a local variable, wanted to ensure that the memory is zeroed out to prevent
>> any issues with the %s specifier, used later on.
>
> What issues?
>
Its a locally defined string of 17 bytes. We are doing memcpy() into the first 16 bytes.
Don't we need to ensure that it is NULL-terminated to prevent undefined behavior when its
given to pr_emerg()? Am I missing something here?
>> Would you recommend removing that and using initializer instead for the string?
>
> I'd recommend looking at what the code does and then really thinking whether
> that makes any sense.
>
--
Thanks,
Avadhut Naik
prev parent reply other threads:[~2024-07-09 6:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 19:56 [PATCH v2 0/4] MCE wrapper and support for new SMCA syndrome MSRs Avadhut Naik
2024-06-25 19:56 ` [PATCH v2 1/4] x86/mce: Add wrapper for struct mce to export vendor specific info Avadhut Naik
2024-06-26 10:44 ` Borislav Petkov
2024-06-26 17:11 ` Luck, Tony
2024-06-26 18:10 ` Borislav Petkov
2024-06-25 19:56 ` [PATCH v2 2/4] x86/mce, EDAC/mce_amd: Add support for new MCA_SYND{1,2} registers Avadhut Naik
2024-06-26 11:10 ` Borislav Petkov
2024-06-26 17:24 ` Naik, Avadhut
2024-06-26 18:18 ` Borislav Petkov
2024-07-09 6:27 ` Naik, Avadhut
2024-07-10 9:38 ` Borislav Petkov
2024-07-10 22:59 ` Naik, Avadhut
2024-06-25 19:56 ` [PATCH v2 3/4] x86/mce/apei: Handle variable register array size Avadhut Naik
2024-06-26 11:57 ` Borislav Petkov
2024-06-26 17:28 ` Naik, Avadhut
2024-06-25 19:56 ` [PATCH v2 4/4] EDAC/mce_amd: Add support for FRU Text in MCA Avadhut Naik
2024-06-26 12:04 ` Borislav Petkov
2024-06-26 18:00 ` Naik, Avadhut
2024-06-26 18:20 ` Borislav Petkov
2024-06-27 16:20 ` Yazen Ghannam
2024-07-09 6:29 ` Naik, Avadhut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efa65048-e176-4bad-aac8-0147d26b1362@amd.com \
--to=avadnaik@amd.com \
--cc=airlied@gmail.com \
--cc=avadhut.naik@amd.com \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=john.allen@amd.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mingo@redhat.com \
--cc=rafael@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).