From: Dan Carpenter <dan.carpenter@linaro.org>
To: Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: [PATCH] tracing/probes: Delete dead code in trace_eprobe_tp_update_arg()
Date: Mon, 26 Jun 2023 16:35:06 +0300 [thread overview]
Message-ID: <f657e0c7-46c3-4e8f-a472-35ec98229660@moroto.mountain> (raw)
This code was recently refactored and now the "ret" variable is always
zero. Delete the check for non-zero.
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
This code was changed in 1b8b0cd754cd (tracing/probes: Move event
parameter fetching code to common parser)
kernel/trace/trace_eprobe.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/kernel/trace/trace_eprobe.c b/kernel/trace/trace_eprobe.c
index cb0077ba2b49..b5181d690b4d 100644
--- a/kernel/trace/trace_eprobe.c
+++ b/kernel/trace/trace_eprobe.c
@@ -797,10 +797,7 @@ static int trace_eprobe_tp_update_arg(struct trace_eprobe *ep, const char *argv[
return ret;
/* Handle symbols "@" */
- if (!ret)
- ret = traceprobe_update_arg(&ep->tp.args[i]);
-
- return ret;
+ return traceprobe_update_arg(&ep->tp.args[i]);
}
static int trace_eprobe_parse_filter(struct trace_eprobe *ep, int argc, const char *argv[])
--
2.39.2
next reply other threads:[~2023-06-26 13:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-26 13:35 Dan Carpenter [this message]
2023-07-01 23:02 ` [PATCH] tracing/probes: Delete dead code in trace_eprobe_tp_update_arg() Masami Hiramatsu
2023-07-06 15:52 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f657e0c7-46c3-4e8f-a472-35ec98229660@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox